summaryrefslogtreecommitdiff
path: root/spec/features
Commit message (Collapse)AuthorAgeFilesLines
* Enable all feature flags by default in specsbvl-enable-features-in-testBob Van Landuyt2017-07-132-0/+9
| | | | | | | | | Otherwise some features would go untested in non-specific contexts I did need to disable the `gitlab_git_diff_size_limit_increase`-feature in some specs since we depend on diffs being expandable while the file we are testing on is smaller than the increased limit.
* Replace 'browse_files.feature' spinach test with an rspec analogblackst0ne2017-07-128-57/+787
|
* Merge branch '34907-dont-show-pipeline-schedule-button-for-non-member' into ↵Kamil Trzciński2017-07-111-127/+161
|\ | | | | | | | | | | | | | | | | 'master' Do not show pipeline schedule button for non-member Closes #34907 See merge request !12757
| * Do not show pipeline schedule button for non-memberTakuya Noguchi2017-07-111-127/+161
| |
* | Support multiple Redis instances based on queue typePaul Charlton2017-07-115-8/+8
|/
* Change `sign_out` usage to `gitlab_sign_out` in one specRobert Speicher2017-07-071-2/+2
| | | | | | For reasons that are still unclear, the EE version (but only the EE version) of this spec was failing reliably, and changing these calls seemed to resolve it. So we're making the change here for parity.
* Merge branch 'master' into rs-sign_inRobert Speicher2017-07-075-11/+144
|\
| * Merge branch '30281-report-abusive-content-from-an-issue-or-merge-request' ↵Jacob Schatz2017-07-072-1/+117
| |\ | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Resolve "Report abusive content from an issue or merge request" Closes #30281 See merge request !11786
| | * Fix close_reopen_report_toggle_spec.rb path helpers rubocop offenseLuke "Jared" Bennett2017-07-071-4/+4
| | |
| | * Added issuables_helper.js, tidied up droplab-dropdown JS, fixed filtered ↵Luke "Jared" Bennett2017-07-072-33/+33
| | | | | | | | | | | | search specs
| | * Added specsLuke "Jared" Bennett2017-07-071-0/+116
| | |
| * | Merge branch 'issue-description-gfm' into 'master'Filipa Lacerda2017-07-071-0/+12
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | Fixed GFM references not being included when update issue inline Closes gitlab-ee#2878 See merge request !12720
| | * | Fixed GFM references not being included when update issue inlineissue-description-gfmPhil Hughes2017-07-071-0/+12
| | | | | | | | | | | | | | | | Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/2878
| * | | Merge branch '33929-allow-to-enable-perf-bar-for-a-group' into 'master'Sean McGivern2017-07-071-9/+14
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow to enable the performance bar per user or Feature group Closes #33929 and #34528 See merge request !12362
| | * \ \ Merge branch 'master' into '33929-allow-to-enable-perf-bar-for-a-group'Sean McGivern2017-07-076-28/+133
| | |\ \ \ | | | |/ / | | | | | | | | | | # Conflicts: # db/schema.rb
| | * | | Fix performance bar specsSean McGivern2017-07-071-5/+10
| | | | |
| | * | | Merge branch 'master' into 33929-allow-to-enable-perf-bar-for-a-groupSean McGivern2017-07-073-8/+198
| | |\ \ \ | | | | |/ | | | |/|
| | * | | Allow to enable the Performance Bar for a group from the admin areaRémy Coutable2017-07-061-8/+8
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | Merge branch '34737-authentiq-oauth-feature-spec' into 'master'Douwe Maan2017-07-071-1/+1
| |\ \ \ \ | | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | Test logging in via the Authentiq OAuth provider in a feature spec Closes #34737 See merge request !12694
| | * | | Test logging in via the Authentiq OAuth provider in a feature spec.34737-authentiq-oauth-feature-specTimothy Andrew2017-07-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - The `migration:path-pg` build was previously failing when the Authentiq feature spec was enabled by placing Authentiq configuration in the `test` section of `gitlab.yml` - The `migration:path-pg` task checks out an old revision of the codebase (`v8.14.10`) and runs a `schema:load`. It then checks out the commit under test, and runs `db:migrate`, to verify that migrations run without errors. - The problem here is that `v8.14.10` does not have the Authentiq module installed, but is run with the `gitlab.yml` for `master`, which would contain the `Authentiq` configuration in the `test` section. - The solution was to use the `v8.14.10` `gitlab.yml` for the `schema:load`, rather than the `gitlab.yml` from master.
* | | | | Merge branch 'master' into rs-sign_inRobert Speicher2017-07-078-36/+219
|\ \ \ \ \ | |/ / / /
| * | | | Merge branch ↵Kamil Trzciński2017-07-071-17/+78
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'feature/intermediate/32568-adding-variables-to-pipelines-schedules' into 'master' Add variables to pipelines schedules Closes #32568 See merge request !12372
| | * \ \ \ Merge from master(Fix conflicts)Shinya Maeda2017-07-072-8/+86
| | |\ \ \ \ | | | | |_|/ | | | |/| |
| | * | | | merge from masterShinya Maeda2017-07-07233-912/+1011
| | |\ \ \ \ | | | | |/ / | | | |/| |
| | * | | | zj nice catchies 3Shinya Maeda2017-07-051-0/+2
| | | | | |
| | * | | | Fix specShinya Maeda2017-07-051-1/+1
| | | | | |
| | * | | | Fix policy by new guild lineShinya Maeda2017-07-051-21/+20
| | | | | |
| | * | | | Fix feature testsShinya Maeda2017-07-051-80/+21
| | | | | |
| | * | | | Schedule pipelines with variablesEric Eastwood2017-07-051-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/32568
| | * | | | Fix specShinya Maeda2017-07-051-1/+1
| | | | | |
| | * | | | Fix policy by new guild lineShinya Maeda2017-07-051-21/+20
| | | | | |
| | * | | | Fix feature testsShinya Maeda2017-07-051-59/+59
| | | | | |
| | * | | | Schedule pipelines with variablesEric Eastwood2017-07-051-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/32568
| * | | | | Native group milestonesFelipe Artur2017-07-072-4/+47
| | | | | |
| * | | | | Resolve "Inconsistent location of members page between groups and projects"Tim Zallmann2017-07-072-5/+6
| | | | | |
| * | | | | Merge branch 'tc-follow-up-mia' into 'master'Douwe Maan2017-07-071-2/+2
| |\ \ \ \ \ | | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow-up from "Namespace license checks for multiple assignees" Closes gitlab-ee#2839 See merge request !12701
| | * | | | Remove CE from spec example descriptionsToon Claes2017-07-071-2/+2
| | | |/ / | | |/| | | | | | | | | | | | They are confusing.
| * | | | Fix to Variable was successfully createdShinya Maeda2017-07-071-3/+3
| | | | |
| * | | | Basic BE changeShinya Maeda2017-07-072-5/+83
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix static-snalysis Move the precedence of group secure variable before project secure variable. Allow project_id to be null. Separate Ci::VariableProject and Ci::VariableGroup Add the forgotton files Add migration file to update type of ci_variables Fix form_for fpr VariableProject Fix test Change the table structure according to the yorik advice Add necessary migration files. Remove unnecessary migration spec. Revert safe_model_attributes.yml Fix models Fix spec Avoid self.variable. Use becomes for correct routing. Use unique index on group_id and key Add null: false for t.timestamps Fix schema version Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable Rename the rest of them Add the rest of files Basic BE change Fix static-snalysis Move the precedence of group secure variable before project secure variable. Allow project_id to be null. Separate Ci::VariableProject and Ci::VariableGroup Add the forgotton files Add migration file to update type of ci_variables Fix form_for fpr VariableProject Fix test Change the table structure according to the yorik advice Add necessary migration files. Remove unnecessary migration spec. Revert safe_model_attributes.yml Fix models Fix spec Avoid self.variable. Use becomes for correct routing. Use unique index on group_id and key Add null: false for t.timestamps Fix schema version Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable Rename the rest of them Add the rest of files Implement CURD Rename codes related to VariableGroup and VariableProject FE part Remove unneccesary changes Make Fe code up-to-date Add protected flag to migration file Protected group variables essential package Update schema Improve doc Fix logic and spec for models Fix logic and spec for controllers Fix logic and spec for views(pre feature) Add feature spec Fixed bugs. placeholder. reveal button. doc. Add changelog Remove unnecessary comment godfat nice catches Improve secret_variables_for arctecture Fix spec Fix StaticAnlysys & path_regex spec Revert "Improve secret_variables_for arctecture" This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1. Use ayufan suggestion for secret_variables_for Use find instead of find_by Fix spec message for variable is invalid Fix spec remove variable.group_id = group.id godffat spec nitpicks Use include Gitlab::Routing.url_helpers for presenter spec
* | | | Merge branch 'master' into rs-sign_inRobert Speicher2017-07-0639-121/+390
|\ \ \ \ | |/ / /
| * | | Merge branch '18000-remember-me-for-oauth-login' into 'master'Douwe Maan2017-07-061-0/+112
| |\ \ \ | | |_|/ | |/| | | | | | | | | | | | | | | | | | Fix `migration:path` build for "Honor the 'Remember me' parameter for OAuth-based login" Closes #34713 See merge request !12668
| | * | Remove Authentiq from the OAuth login integration tests.Timothy Andrew2017-07-061-1/+1
| | | | | | | | | | | | | | | | | | | | - This is causing autoload-related errors in the `migration:path` builds. We need to find a better way of testing this provider.
| | * | Implement review comments for !11963 from @adamniedzielski.Timothy Andrew2017-07-061-14/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Change double quotes to single quotes. - Why is `OmniAuth.config.full_host` being reassigned in the integration test? - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task - Other minor changes
| | * | Add Omniauth OAuth config to the test section of `gitlab.yml`Timothy Andrew2017-07-061-51/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - I tried to get this to work by stubbing out portions of the config within the test. This didn't work as expected because Devise/Omniauth loaded before the stub could run, and the stubbed config was ignored. - I attempted to fix this by reloading Devise/Omniauth after stubbing the config. This successfully got Devise to load the stubbed providers, but failed while trying to access a route such as `user_gitlab_omniauth_authorize_path`. - I spent a while trying to figure this out (even trying `Rails.application.reload_routes!`), but nothing seemed to work. - I settled for adding this config directly to `gitlab.yml` rather than go down this path any further.
| | * | Add more providers to the OAuth login integration tests.Timothy Andrew2017-07-061-2/+41
| | | | | | | | | | | | | | | | | | | | - Added saml, authentiq, cas3, and auth0 - Crowd seems to be a special case that will be handled separately.
| | * | Test the "Remember Me" flow for OAuth-based login.Timothy Andrew2017-07-061-2/+59
| | | |
| | * | Add integration tests around OAuth login.Timothy Andrew2017-07-061-0/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - There was previously a test for `saml` login in `login_spec`, but this didn't seem to be passing. A lot of things didn't seem right here, and I suspect that this test hasn't been running. I'll investigate this further. - It took almost a whole working day to figure out this line: OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') } As always, it's obvious in retrospect, but it took some digging to figure out tests were failing and returning 404s during the callback phase. - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
| * | | Merge branch '34698-fix-transient-failure' into 'master'Grzegorz Bizon2017-07-061-8/+17
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a nasty transient failure happening is a subsequent spec Closes #34698 See merge request !12664
| | * | | Fix project_path helper arguments in wiki specs34698-fix-transient-failureGrzegorz Bizon2017-07-061-1/+1
| | | | |
| | * | | Fix a nasty transient failure happening is a subsequent specRémy Coutable2017-07-051-9/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://gitlab.com/gitlab-org/gitlab-ce/issues/34698#note_34276286 for the thorough explanation. Signed-off-by: Rémy Coutable <remy@rymai.me>