summaryrefslogtreecommitdiff
path: root/spec/controllers
Commit message (Collapse)AuthorAgeFilesLines
* Standardize remote_ip and path keys for auth.log and api_json.logStan Hu2019-08-202-4/+4
| | | | | | | | Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses `remote_ip` and `path` for the same fields. Let's standardize these namings to make it easier for people working with the data. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
* Merge branch 'fix-deprecation-warnings-change-success-to-successful' into ↵Douglas Barbosa Alexandre2019-08-2019-53/+49
|\ | | | | | | | | | | | | 'master' Change `be_success` to `be_successful` in specs See merge request gitlab-org/gitlab-ce!31969
| * Change `be_success` to `be_successful` in specsfix-deprecation-warnings-change-success-to-successfulVitali Tatarintev2019-08-1919-53/+49
| | | | | | | | | | | | | | | | | | | | Fixes deprecation warning: ``` DEPRECATION WARNING: The success? predicate is deprecated and will be removed in Rails 6.0. Please use successful? as provided by Rack::Response::Helpers. ```
* | Merge branch 'mc/bug/nplusone-pipelines-show' into 'master'Stan Hu2019-08-191-7/+11
|\ \ | | | | | | | | | | | | Improve nplusone spec for PipelinesController#show See merge request gitlab-org/gitlab-ce!31976
| * | Improve nplusone spec for PipelinesController#showMatija Čupić2019-08-191-7/+11
| | |
* | | Fix N+1s queries while loading usersDouglas Barbosa Alexandre2019-08-191-0/+14
| |/ |/|
* | Merge branch '66023-starrers-count-do-not-match-after-searching' into 'master'Stan Hu2019-08-161-40/+112
|\ \ | |/ |/| | | | | Fix starrers counts after searching See merge request gitlab-org/gitlab-ce!31823
| * Fix starrers counters after searchingDouglas Barbosa Alexandre2019-08-151-40/+112
| |
* | Merge branch ↵Grzegorz Bizon2019-08-162-4/+125
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | '47003-user-onboarding-replace-current-email-confirmation-flow-with-a-soft-email-confirmation-flow' into 'master' Soft email confirmation flow Closes #47003 See merge request gitlab-org/gitlab-ce!31245
| * | Don't redirect to the Almost there pageAlex Buijs2019-08-081-4/+27
| | | | | | | | | | | | | | | Don't redirect to the Almost there page after registration and after resending confirmation instructions
| * | Add ConfirmEmailWarning concernAlex Buijs2019-08-081-0/+98
| | |
* | | Merge branch '24705-multi-selection-for-delete-on-registry-page' into 'master'Thong Kuah2019-08-151-0/+33
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Resolve "Multi selection for delete on registry page" Closes #24705 See merge request gitlab-org/gitlab-ce!30837
| * | Support bulk registry tag deleteGiorgenes Gelatti2019-07-301-0/+33
| | |
* | | Merge branch 'dblessing-fix-public-project-ssh-only-ci-failure' into 'master'Douglas Barbosa Alexandre2019-08-151-0/+11
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Allow CI to clone public projects when HTTP protocol is disabled Closes #65805 See merge request gitlab-org/gitlab-ce!31632
| * | | Allow CI to clone public projects when HTTP protocol is disabledDrew Blessing2019-08-141-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GitLab has a mechanism that allows CI to clone repositories via HTTP even when the HTTP protocol is disabled. This works as expected when a project is private or internal. However, when a project is public CI gets an error message that HTTP is not allowed. This happens because Git only sends auth in a subsequent request after a 401 is returned first. For public projects, GitLab grabs onto that unauthenticated request and sends it through since it recognizes that Guests are ordinarily allowed to access the repository. Later on this leads to a 403 since HTTP protocol is disabled. Fix this by only continuing with unauthenticated requests when HTTP is allowed.
* | | | Merge branch 'georgekoltsov/48854-fix-empty-flash-message' into 'master'ce-update-ff-permissions-for-new-strategiesStan Hu2019-08-151-10/+18
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Exclude json content type from workhorse interception See merge request gitlab-org/gitlab-ce!31809
| * | | | Exclude json content type from workhorse interceptionGeorge Koltsov2019-08-141-10/+18
| | | | |
* | | | | Merge branch ↵Stan Hu2019-08-141-0/+86
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | '46548-open-source-alternative-to-recaptcha-for-gitlab-com-registration' into 'master' Open source alternative to reCAPTCHA for GitLab.com registration See merge request gitlab-org/gitlab-ce!31625
| * | | | Add logging and counter for invisible captcha46548-open-source-alternative-to-recaptcha-for-gitlab-com-registrationAlex Buijs2019-08-141-19/+45
| | | | |
| * | | | Add invisible captchaAlex Buijs2019-08-101-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With a time treshold of 4 seconds and a firstname and lastname honeypot input fields when signing up
* | | | | Track page views for cycle analytics show pageAdam Hegyi2019-08-141-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | This change adds a new counter 'cycle_analytics_views' to the usage data metrics to count the page views for cycle analytics show page.
* | | | | Return 429 on rate limiter on raw endpointMayra Cabrera2019-08-131-3/+3
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | It was originally returning 302 when the rate limit kicks in, because using the the correct status code makes it easier to track rate limiting events Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/65974
* | | | Load search result counts asynchronouslyMarkus Koller2019-08-121-90/+112
| | | | | | | | | | | | | | | | | | | | | | | | Querying all counts for the different search results in the same request led to timeouts, so we now only calculate the count for the *current* search results, and request the others in separate asynchronous calls.
* | | | Add BitbucketServerController filtering specGeorge Koltsov2019-08-121-1/+13
| | | |
* | | | Merge branch 'sh-break-out-invited-group-members' into 'master'Ash McKenzie2019-08-121-0/+33
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make it easier to find invited group members Closes #61948 See merge request gitlab-org/gitlab-ce!28436
| * \ \ \ Merge branch 'master' into sh-break-out-invited-group-membersStan Hu2019-08-094-8/+222
| |\ \ \ \ | | |/ / /
| * | | | Merge branch 'master' into sh-break-out-invited-group-membersStan Hu2019-08-072-22/+18
| |\ \ \ \
| * | | | | Make it easier to find invited group membersStan Hu2019-08-051-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We had a number of team members struggle to find invited members of a group. Searching for the e-mail address did not work because search only works with members with user accounts. This commit changes two things: 1. Breaks out the invited members into a separate table. 2. Adds search capability for the invited members. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61948
* | | | | | Split MR widget into cached and non-cached serializersIgor2019-08-091-15/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Splits auto-refreshing of MR widget into 2 requests: - the one which uses etag-caching and invalidates the fields on change - the one without caching The idea is to gradually move all the fields to etag-cached endpoint
* | | | | | Merge branch 'spec-differences' into 'master'Robert Speicher2019-08-091-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport EE code for OAuth applications spec See merge request gitlab-org/gitlab-ce!31670
| * | | | | | Backport EE code for OAuth applications specspec-differencesYorick Peterse2019-08-091-1/+1
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | This spec used a different title for a spec in EE, while CE duplicated the same title. This ensures that CE uses the EE version.
* | | | | | Remove gfm_embed_metrics flag from BETristan Read2019-08-091-32/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | Removes the feature flag that controls whether metrics dashboard urls unfurl the metrics dashboard charts.
* | | | | Bring scoped environment variables to coreHordur Freyr Yngvason2019-08-081-0/+65
| |_|_|/ |/| | | | | | | | | | | As decided in https://gitlab.com/gitlab-org/gitlab-ce/issues/53593
* | | | Fix public/private starrers counts in special cases20137-starrersCamil Staps2019-08-071-5/+38
| | | |
* | | | Handle reviewer comments on !24690Camil Staps2019-08-071-0/+2
| | | |
* | | | Add tests for starrers viewsCamil Staps2019-08-071-0/+75
| | | |
* | | | Support dashboard params for metrics dashboardSarah Yasonik2019-08-071-7/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/62971 Adds support to EnvironmentsController#metrics_dashboard for the following params: group, title, y_label These params are used to uniquely identify a panel on the metrics dashboard. Metrics are stored in several places, so this adds utilities to find a specific panel from the database or filesystem depending on the metric specified. Also moves some shared utilities into separate classes, notably default values and errors.
* | | | Clean tmpdirs in metrics endpoint specsPeter Leitzen2019-08-071-1/+8
| |/ / |/| |
* | | Use separate Kubernetes namespaces per environmentTiger Watson2019-08-071-8/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Kubernetes deployments on new clusters will now have a separate namespace per project environment, instead of sharing a single namespace for the project. Behaviour of existing clusters is unchanged. All new functionality is controlled by the :kubernetes_namespace_per_environment feature flag, which is safe to enable/disable at any time.
* | | Rewrite issues show spec as a feature specfix-design-management-router-ceLuke Duncalfe2019-08-051-14/+7
|/ / | | | | | | | | | | | | | | This spec needs to run as a request-style spec in order to invoke the Rails router. A controller-style spec matches the wrong route, and `session['user_return_to']` becomes incorrect.
* | Prevent empty classes in ansi2html conversionLukas '+ alert('Eipi') + ' Eipert2019-08-021-1/+1
| | | | | | | | | | | | | | Currently we write out empty CSS classes (`class=""`) every time we create a new tag. This adds 9 unnecessary bytes per span element. In a recent trace, I have counted 11950 span elements. So we transported 105 unnecessary kilobytes!
* | Add can_merge option to autocomplete responseIgor2019-08-011-0/+14
| | | | | | | | It's used only if merge_request_iid param is provided
* | Merge branch '52123-issuable-actions-notesfinder-pderichs' into 'master'Stan Hu2019-08-014-1/+108
|\ \ | | | | | | | | | | | | | | | | | | Use NotesFinder to fetch notes on API and Controllers Closes #52123 See merge request gitlab-org/gitlab-ce!31300
| * | Use NotesFinder in IssuableActions modulePatrick Derichs2019-08-014-1/+108
| |/ | | | | | | | | | | | | | | | | | | Remove project from NotesFinder constructor Add project parameter to specs Also look for methods in private scope Fix specs to match new NotesFinder constructor
* | Fix broken spec from file renameThong Kuah2019-08-011-1/+1
| | | | | | | | b36323f3d26131405925bf86742b2b4acd786230
* | Merge branch '65297-fix-typo-on-clusters_applications_cert_managers-factory' ↵Thong Kuah2019-07-312-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Resolve "Fix typo on clusters_applications_cert_managers factory" Closes #65297 See merge request gitlab-org/gitlab-ce!31278
| * | Remove typo from factory name65297-fix-typo-on-clusters_applications_cert_managers-factoryJoão Cunha2019-07-302-2/+2
| |/ | | | | | | | | - the typo in this factory name was precluding us from properly creating dynamic code to remove duplciation.
* | Merge branch 'ajk-handle-gql-errors' into 'master'Sean McGivern2019-07-311-0/+21
|\ \ | | | | | | | | | | | | Propagate argument errors as execution errors See merge request gitlab-org/gitlab-ce!31249
| * | Propagate argument errors as execution errorsajk-handle-gql-errorsAlex Kalderimis2019-07-301-0/+21
| |/
* | Use spec_helper than rails_helper65317-adapt-tae-role-name-changeLin Jen-Shin2019-07-301-1/+1
|/