| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses
`remote_ip` and `path` for the same fields. Let's standardize these
namings to make it easier for people working with the data.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
|
|\
| |
| |
| |
| |
| |
| | |
'master'
Change `be_success` to `be_successful` in specs
See merge request gitlab-org/gitlab-ce!31969
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes deprecation warning:
```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```
|
|\ \
| | |
| | |
| | |
| | | |
Improve nplusone spec for PipelinesController#show
See merge request gitlab-org/gitlab-ce!31976
|
| | | |
|
| |/
|/| |
|
|\ \
| |/
|/|
| |
| | |
Fix starrers counts after searching
See merge request gitlab-org/gitlab-ce!31823
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
'47003-user-onboarding-replace-current-email-confirmation-flow-with-a-soft-email-confirmation-flow' into 'master'
Soft email confirmation flow
Closes #47003
See merge request gitlab-org/gitlab-ce!31245
|
| | |
| | |
| | |
| | |
| | | |
Don't redirect to the Almost there page after registration
and after resending confirmation instructions
|
| | | |
|
|\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | | |
Resolve "Multi selection for delete on registry page"
Closes #24705
See merge request gitlab-org/gitlab-ce!30837
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Allow CI to clone public projects when HTTP protocol is disabled
Closes #65805
See merge request gitlab-org/gitlab-ce!31632
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
GitLab has a mechanism that allows CI to clone repositories via HTTP
even when the HTTP protocol is disabled. This works as expected
when a project is private or internal. However, when a project is
public CI gets an error message that HTTP is not allowed. This
happens because Git only sends auth in a subsequent request after a
401 is returned first. For public projects, GitLab grabs onto that
unauthenticated request and sends it through since it recognizes
that Guests are ordinarily allowed to access the repository.
Later on this leads to a 403 since HTTP protocol is disabled.
Fix this by only continuing with unauthenticated requests when
HTTP is allowed.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Exclude json content type from workhorse interception
See merge request gitlab-org/gitlab-ce!31809
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
'46548-open-source-alternative-to-recaptcha-for-gitlab-com-registration' into 'master'
Open source alternative to reCAPTCHA for GitLab.com registration
See merge request gitlab-org/gitlab-ce!31625
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
With a time treshold of 4 seconds
and a firstname and lastname honeypot
input fields when signing up
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This change adds a new counter 'cycle_analytics_views' to the usage data
metrics to count the page views for cycle analytics show page.
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It was originally returning 302 when the rate limit kicks in, because
using the the correct status code makes it easier to track rate limiting
events
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/65974
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Querying all counts for the different search results in the same request
led to timeouts, so we now only calculate the count for the *current*
search results, and request the others in separate asynchronous calls.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Make it easier to find invited group members
Closes #61948
See merge request gitlab-org/gitlab-ce!28436
|
| |\ \ \ \
| | |/ / / |
|
| |\ \ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We had a number of team members struggle to find invited members of a
group. Searching for the e-mail address did not work because search only
works with members with user accounts.
This commit changes two things:
1. Breaks out the invited members into a separate table.
2. Adds search capability for the invited members.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61948
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Splits auto-refreshing of MR widget into 2 requests:
- the one which uses etag-caching and invalidates the fields on change
- the one without caching
The idea is to gradually move all the fields to etag-cached endpoint
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Backport EE code for OAuth applications spec
See merge request gitlab-org/gitlab-ce!31670
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | | |
This spec used a different title for a spec in EE, while CE duplicated
the same title. This ensures that CE uses the EE version.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Removes the feature flag that controls whether
metrics dashboard urls unfurl the metrics dashboard
charts.
|
| |_|_|/
|/| | |
| | | |
| | | | |
As decided in https://gitlab.com/gitlab-org/gitlab-ce/issues/53593
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://gitlab.com/gitlab-org/gitlab-ce/issues/62971
Adds support to EnvironmentsController#metrics_dashboard
for the following params: group, title, y_label
These params are used to uniquely identify a panel on
the metrics dashboard.
Metrics are stored in several places, so this adds
utilities to find a specific panel from the database
or filesystem depending on the metric specified.
Also moves some shared utilities into separate classes,
notably default values and errors.
|
| |/ /
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Kubernetes deployments on new clusters will now have
a separate namespace per project environment, instead
of sharing a single namespace for the project.
Behaviour of existing clusters is unchanged.
All new functionality is controlled by the
:kubernetes_namespace_per_environment feature flag,
which is safe to enable/disable at any time.
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
This spec needs to run as a request-style spec in order to invoke the
Rails router.
A controller-style spec matches the wrong route, and
`session['user_return_to']` becomes incorrect.
|
| |
| |
| |
| |
| |
| |
| | |
Currently we write out empty CSS classes (`class=""`) every time we
create a new tag. This adds 9 unnecessary bytes per span element. In a
recent trace, I have counted 11950 span elements. So we transported 105
unnecessary kilobytes!
|
| |
| |
| |
| | |
It's used only if merge_request_iid param is provided
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Use NotesFinder to fetch notes on API and Controllers
Closes #52123
See merge request gitlab-org/gitlab-ce!31300
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Remove project from NotesFinder constructor
Add project parameter to specs
Also look for methods in private scope
Fix specs to match new NotesFinder constructor
|
| |
| |
| |
| | |
b36323f3d26131405925bf86742b2b4acd786230
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
into 'master'
Resolve "Fix typo on clusters_applications_cert_managers factory"
Closes #65297
See merge request gitlab-org/gitlab-ce!31278
|
| |/
| |
| |
| |
| | |
- the typo in this factory name was precluding us from properly
creating dynamic code to remove duplciation.
|
|\ \
| | |
| | |
| | |
| | | |
Propagate argument errors as execution errors
See merge request gitlab-org/gitlab-ce!31249
|
| |/ |
|
|/ |
|