summaryrefslogtreecommitdiff
path: root/spec/controllers/snippets
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup usages of `JSON.parse` in specsPeter Leitzen2019-07-161-3/+3
| | | | Prefer `json_response` where applicable.
* Correctly check permissions when creating snippet notesMarkus Koller2019-06-061-0/+113
| | | | | | | | | | In the Snippets::NotesController the noteable was resolved and authorized through the :snippet_id, so by passing a :target_id for a different snippet it was possible to create a note on a snippet where the user would be unauthorized to do so otherwise. This fixes the problem by ignoring the :target_id and :target_type from the request, and using the same noteable for creation and authorization.
* Add some frozen string to spec/**/*.rbgfyoung2019-04-151-0/+2
| | | | | | | | | | Adds frozen string to the following: * spec/bin/**/*.rb * spec/config/**/*.rb * spec/controllers/**/*.rb xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
* Update specs to rails5 formatblackst0ne-convert-specs-rails5-styleblackst0ne2018-12-191-14/+14
| | | | | | | | | | Updates specs to use new rails5 format. The old format: `get :show, { some: params }, { some: headers }` The new format: `get :show, params: { some: params }, headers: { some: headers }`
* Refactor `have_http_status` into `have_gitlab_http_status` in the specsJacopo2017-10-201-10/+10
|
* Enable the Layout/SpaceBeforeBlockBraces coprc/enable-the-Layout/SpaceBeforeBlockBraces-copRémy Coutable2017-08-091-3/+3
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Display comments for personal snippets12910-personal-snippets-notes-showJarka Kadlecova2017-05-021-0/+196