summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
...
| | | | * | | | | | | | Track total query/view timings in transactionsYorick Peterse2016-01-042-0/+23
| | | | | | | | | | | |
| | | | * | | | | | | | Ability to increment custom transaction valuesYorick Peterse2016-01-041-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will be used to store/increment the total query/view rendering timings on a per transaction basis. This in turn can greatly reduce the amount of metrics stored.
| | | | * | | | | | | | Removed tracking of hostnames for metricsYorick Peterse2015-12-312-10/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This isn't hugely useful and mostly wastes InfluxDB space. We can re-add this whenever needed (but only once we really need it).
| | | | * | | | | | | | Use separate series for Rails/Sidekiq transactionsYorick Peterse2015-12-314-8/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the need for tagging all metrics with a "process_type" tag.
| | | | * | | | | | | | Cache InfluxDB settings after the first useYorick Peterse2015-12-311-14/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures we don't need to load anything from either PostgreSQL or the Rails cache whenever creating new InfluxDB connections.
| | | | * | | | | | | | Removed tracking of raw SQL queriesYorick Peterse2015-12-312-95/+0
| | | | |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This particular setup had 3 problems: 1. Storing SQL queries as tags is very inefficient as InfluxDB ends up indexing every query (and they can get pretty large). Storing these as values instead means we can't always display the SQL as easily. 2. We already instrument ActiveRecord query methods, thus we already have timing information about database queries. 3. SQL obfuscation is difficult to get right and I'd rather not expose sensitive data by accident.
| | | * | | | | | | | Add DEBUG_BANZAI_CACHE env var to debug Banzai cache issue.debug-banzai-cacheDouwe Maan2016-01-041-7/+14
| | | | | | | | | | |
| | | * | | | | | | | Merge branch 'autocomplete-performance' into 'master' Dmitriy Zaporozhets2016-01-045-5/+33
| | | |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improving autocomplete performance part 2 Related issue: gitlab-org/gitlab-ce#3507 See merge request !2253
| | | | * | | | | | | | Optimize CSS expressions produced by Nokogiriautocomplete-performanceYorick Peterse2015-12-313-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nokogiri produces inefficient XPath expressions when given CSS expressions such as "a.gfm". Luckily these expressions can be optimized quite easily while still achieving the same results. In the two cases where this optimization is applied the run time has been reduced from around 170 ms to around 15 ms.
| | | | * | | | | | | | Don't use delegate to delegate trivial methodsYorick Peterse2015-12-311-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Around 300 ms (in total) would be spent in these delegated methods due to the extra stuff ActiveSupport adds to the compiled methods. Because these delegations are so simple we can just manually define the methods, saving around 275 milliseconds.
| | | | * | | | | | | | Use XPath for searching link nodesYorick Peterse2015-12-311-2/+2
| | | | |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a tad faster than letting Nokogiri figure out whether it should evaluate the query as CSS or XPath and then actually evaluating it.
| | | * | | | | | | | Simplify `ContributionsCalendar#starting_year` and `#starting_month`Robert Speicher2016-01-011-2/+2
| | | |/ / / / / / /
| | * | | | | | | | Added housekeeping for git repositoriesJeroen Nijhof2015-10-211-0/+12
| | | | | | | | | |
| * | | | | | | | | Add some fixes after reviewTomasz Maczukin2016-01-132-13/+6
| | | | | | | | | |
| * | | | | | | | | Change 'trigger_id' to 'token' as resource ID in triggers APITomasz Maczukin2016-01-072-18/+9
| | | | | | | | | |
| * | | | | | | | | Get show details feature to triggers APITomasz Maczukin2016-01-051-0/+26
| | | | | | | | | |
| * | | | | | | | | Add create feature to triggers APITomasz Maczukin2016-01-051-0/+16
| | | | | | | | | |
| * | | | | | | | | Add delete feature to triggers APITomasz Maczukin2016-01-051-0/+19
| | | | | | | | | |
| * | | | | | | | | Add triggers feature to APITomasz Maczukin2016-01-042-0/+28
| | |/ / / / / / / | |/| | | | | | |
| * | | | | | | | Removed various default metrics tagsreduce-influxdb-tagsYorick Peterse2015-12-311-5/+2
| | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While it's useful to keep track of the different versions (Ruby, GitLab, etc) doing so for every point wastes disk space and possibly also RAM (which InfluxDB is all to eager to gobble up). If we want to see the performance differences between different GitLab versions simply looking at the performance since the last release date should suffice.
| * | | | | | | Make sure that is no pending migrations in Gitlab::CurrentSettingsfix-buildDouglas Barbosa Alexandre2015-12-301-1/+3
| | |_|_|_|_|/ | |/| | | | |
| * | | | | | Merge branch 'upvote_count_to_api' into 'master' Valery Sizov2015-12-291-1/+0
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert upvotes and downvotes params back to MR API issue https://gitlab.com/gitlab-org/gitlab-ce/issues/3672 See merge request !2212
| | * | | | | | Revert upvotes and downvotes params to MR APIValery Sizov2015-12-281-1/+0
| | | |_|_|_|/ | | |/| | | |
| * | | | | | Use Gitlab::CurrentSettings for InfluxDBYorick Peterse2015-12-291-25/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures we can still start up even when not connecting to a database.
| * | | | | | Write to InfluxDB directly via UDPYorick Peterse2015-12-296-13/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the need for Sidekiq and any overhead/problems introduced by TCP. There are a few things to take into account: 1. When writing data to InfluxDB you may still get an error if the server becomes unavailable during the write. Because of this we're catching all exceptions and just ignore them (for now). 2. Writing via UDP apparently requires the timestamp to be in nanoseconds. Without this data either isn't written properly. 3. Due to the restrictions on UDP buffer sizes we're writing metrics one by one, instead of writing all of them at once.
| * | | | | | Strip newlines from obfuscated SQLYorick Peterse2015-12-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Newlines aren't really needed and they may mess with InfluxDB's line protocol.
| * | | | | | Merge branch 'feature/recaptcha_settings' into 'master' Dmitriy Zaporozhets2015-12-291-0/+14
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes reCAPTCHA configurable through Application Settings screen Following the work made by @stanhu here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2216, made it configurable without needing to restart Gitlab See merge request !2231
| | * | | | | | reCAPTCHA is configurable through Admin Settings, no reload needed.Gabriel Mazetto2015-12-281-0/+14
| | | | | | | |
* | | | | | | | More refactoring from last code review. #3945Rubén Dávila2016-01-142-7/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use commit objects instead of IDs when generating diffs * Use proper references when generating MR's source and target * Update broken specs
* | | | | | | | Add inline diff markers in highlighted diffs.Douwe Maan2016-01-143-34/+181
| | | | | | | |
* | | | | | | | Refactor highlighting linesDouwe Maan2016-01-141-25/+4
| | | | | | | |
* | | | | | | | Remove duplication around highlighting.Douwe Maan2016-01-142-12/+24
| | | | | | | |
* | | | | | | | Use #sub instead of #gsub!. #3945Rubén Dávila2016-01-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * This is because is not a good idea to modify the original lines * Also I run into this issue https://gitlab.com/gitlab-org/gitlab_git/issues/14 which is returning Diff Lines with the same @new_pos value.
* | | | | | | | Little refactor for usage of html_safe. #3945Rubén Dávila2016-01-131-2/+2
| | | | | | | |
* | | | | | | | Fix broken specs. #3945Rubén Dávila2016-01-121-1/+1
| | | | | | | |
* | | | | | | | Remove no longer required code. #3945Rubén Dávila2016-01-121-42/+9
| | | | | | | |
* | | | | | | | Small fixes from code review. #3945Rubén Dávila2016-01-121-4/+0
| | | | | | | |
* | | | | | | | Fix broken spec for submodule commit. #3945Rubén Dávila2016-01-091-2/+10
| | | | | | | |
* | | | | | | | Fix broken specs. #3945Rubén Dávila2016-01-081-5/+5
| | | | | | | |
* | | | | | | | Remove custom Lexer. #3945 [ci skip]Rubén Dávila2016-01-082-28/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Inline diff is going to be generated client side now. #3945
* | | | | | | | Change strategy to highlight diffs. #3945Rubén Dávila2016-01-072-20/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now we apply syntax highlighting to the whole old and new files. This basically help us to highlight adequately multiline content.
* | | | | | | | Don't process inline diffs on backend. #3945Rubén Dávila2016-01-072-108/+1
| | | | | | | |
* | | | | | | | Apply syntax highlighting when expanding diff plus some refactor. #3945Rubén Dávila2015-12-311-12/+43
| | | | | | | |
* | | | | | | | Don't modify "match" diff lines. #3945Rubén Dávila2015-12-301-1/+6
| | | | | | | |
* | | | | | | | A bit of refactoring. #3945Rubén Dávila2015-12-303-9/+11
| | | | | | | |
* | | | | | | | Fix broken spec and small refactor. #3945Rubén Dávila2015-12-302-3/+3
| | | | | | | |
* | | | | | | | Fix Rubocop complain. #3945Rubén Dávila2015-12-301-5/+5
| | | | | | | |
* | | | | | | | New implementation for highlighting diff files. #3945Rubén Dávila2015-12-304-1/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * It is more performant given now we process all the diff file instead of processing line by line. * Multiline comments are highlighted correctly.
* | | | | | | | Set initial state on parent Lexer. #3945Rubén Dávila2015-12-281-0/+4
| | | | | | | |
* | | | | | | | Add syntax highlighting to diff view. #3945Rubén Dávila2015-12-281-0/+20
|/ / / / / / /