| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix N+1 with source_projects in merge requests API
See merge request gitlab-org/gitlab-ce!19346
|
| | |/ / /
| | | | |
| | | | |
| | | | |
| | | | | |
Now that we are checking `MergeRequest#for_fork?`, we also need
the source project preloaded for a merge request.
|
| | | | | |
|
| |\ \ \ \
| | |/ / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
cleared between requests
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| | | | | |
|
| | |\ \ \
| | | |_|/
| | |/| |
| | | | |
| | | | |
| | | | |
| | | | | |
'master'
Improve validations for Ci::Runner#runner_type
See merge request gitlab-org/gitlab-ce!18901
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | |\ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Resolve "A lot of constants redefinition warnings"
Closes #46481
See merge request gitlab-org/gitlab-ce!19286
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Which could extend from EE
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* Replace `require` or `require_relative` with `require_dependency`
* Remove unneeded `autoload`
|
| | | | |/
| | | |/| |
|
| | |/ /
| | | |
| | | |
| | | | |
because of SSRF
|
| |\ \ \
| | |/ / |
|
| | |\ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Make ActiveRecordSubscriber rails 5 compatible
Closes #44702
See merge request gitlab-org/gitlab-ce!19276
|
| | | |/ |
|
| | | | |
|
| | |\ \
| | | | |
| | | | |
| | | | |
| | | | | |
Take two for MR metrics population background migration
See merge request gitlab-org/gitlab-ce!19097
|
| | | | | |
|
| | | | | |
|
| | |\ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Eliminate cached N+1 queries for projects in Issue API
See merge request gitlab-org/gitlab-ce!19269
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In CE, every `Issue` entity is also a `ProjectEntity`, which calls
`entity&.project.try(:id)` to show the project ID. In an API
request with 100 issues, this would hit the Rails statement cache 100 times
for the same project and cause unnecessary overhead as related models would
also be loaded.
In EE, we call `Issue#supports_weight?` for each issue, which then calls
`project&.feature_available?(:issue_weights)`. If the project is not
preloaded, this incurs additional overhead, as each individual Project
object has to be queried. This can lead to a significant performance hit.
In loading the CE project with 100 issues, this contributed to at least 22%
of the load time.
See https://gitlab.com/gitlab-org/gitlab-ce/issues/47031 for why testing this
is a bit tricky.
|
| | |\ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Replace .having with .where in calendar query
Closes #46964
See merge request gitlab-org/gitlab-ce!19230
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
the current syntax doesn't work properly in Rails 5, the resulting query
looks like:
HAVING "events"."project_id" IN (0)
instead of:
HAVING "events"."project_id" IN (SELECT "projects"."id" FROM...
Also we should not use ActiveRecord internal methods. In this case we
can filter projects in WHERE clause instead of doing this in HAVING
clause. Usage of WHERE should be also more efficient because grouping
is then done on much smaller subset of records.
|
| | |\ \ \ \ \
| | | |_|_|_|/
| | |/| | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fix encoding bug in Gitaly::Commit::TreeEntry
Closes #46445 and gitaly#1208
See merge request gitlab-org/gitlab-ce!19243
|
| | | | |_|/
| | | |/| | |
|
| | |\ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Removal of API v3 from the codebase
Closes #36819
See merge request gitlab-org/gitlab-ce!18970
|
| | | |/ / / |
|
| | |\ \ \ \
| | | |_|_|/
| | |/| | |
| | | | | |
| | | | | | |
Fix various bugs related to relative_url_root in development
See merge request gitlab-org/gitlab-ce!19213
|
| | | | | | |
|
| | |\ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Add missing usage_ping_enabled to API settings
See merge request gitlab-org/gitlab-ce!19263
|
| | | | |/ /
| | | |/| |
| | | | | |
| | | | | | |
Identified while resolving conflicts in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5906
|
| | |\ \ \ \
| | | |/ / /
| | |/| | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Line profiling modal width
Closes #46999
See merge request gitlab-org/gitlab-ce!19253
|
| | | | | | |
|
| | |\ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Only preload member records for the relevant projects/groups/user in projects API
See merge request gitlab-org/gitlab-ce!18945
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
projects API
|
| | |\ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Replace grape-route-helpers with our own grape-path-helpers
Closes #45718
See merge request gitlab-org/gitlab-ce!19240
|
| | | | |_|_|/
| | | |/| | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This gem (https://gitlab.com/gitlab-org/grape-path-helpers) makes a number of changes:
1. Brings in @mdelaossa's changes in https://github.com/reprah/grape-route-helpers/pull/21
2. Fixes some broken specs and code for Grape 1.0+
3. Optimizes the generation of paths by bringing in @dblessing's
HashWithIndifferentAccess changes in https://gitlab.com/gitlab-org/gitlab-ce/issues/45718#note_70123793
Closes #45718
|
| | |\ \ \ \ \
| | | |_|/ / /
| | |/| | | |
| | | | | | |
| | | | | | | |
Extracted auxiliary methods from storage.rake into specific RakeHelper
See merge request gitlab-org/gitlab-ce!18962
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | |\ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Import bitbucket issues that are reported by an anonymous user
Closes #44381
See merge request gitlab-org/gitlab-ce!18199
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
For these kind of issues, the "reporter" field is present but zero.
In such a case, "fetch" will not return the default value, but it will
return nil.
Hence, importing fails, because the "username" field of nil is referenced
Fixes issue #44381
|
| | |\ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Updated Mattermost integration to use Mattermost API v4
Closes #41631
See merge request gitlab-org/gitlab-ce!19043
|