| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Detect if pipeline runs for a GitHub pull request
When using a mirror for CI/CD only we register a pull_request
webhook. When a pull_request webhook is received, if the
source branch SHA matches the actual head of the branch in the
repository we create immediately a new pipeline for the
external pull request. Otherwise we store the
pull request info for when the push webhook is received.
When using "only/except: external_pull_requests" we can detect
if the pipeline has a open pull request on GitHub and create or
not the job based on that.
|
| | |
|
| |\
| |
| |
| |
| | |
Avoid calling freeze on already frozen strings in lib/gitlab
See merge request gitlab-org/gitlab-ce!32637
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
Now, when the dns rebinging setting is disabled, we will
allow urls that are not resolvable.
|
| | |
| |
| |
| |
| |
| | |
- `edge_nodes` needs to get called on the object
- added `include GlobalID::Identification` in a couple places
- renamed `object` to `item` in spec due to conflict
|
| | |
| |
| |
| |
| | |
When using /due quick action with an invalid date a meaninful error
message is shown.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
- Due to https://github.com/exAspArk/batch-loader/pull/32,
we changed BatchLoader.for into BatchLoader::GraphQL.for
- since our results are wrapped in a BatchLoader::GraphQL,
calling `sync` during authorization is required to get real object
- `graphql` now has it's own authorization system. Our
`authorized?` method conflicted and required renaming
|
| | |
| |
| |
| |
| | |
The current state of group issue boards does not show the "Add issues"
button on the UI for users that are reporters of group child projects.
|
| | |
| |
| |
| | |
(cherry picked from commit 0bf7fecdee5a200eeb4f27b4888a57ceee63bde9)
|
| |\ \
| | |
| | |
| | |
| | | |
Persist `needs:` validation as config error
See merge request gitlab-org/gitlab-ce!32648
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In case when `needs:` is missing, but when requested by service,
we would not save the pipeline with config_error.
This makes it explicit that we want to persist the error
as `config_error` failure reason.
|
| | | |
| | |
| | |
| | | |
Improve diff lines count efficiency
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Extract Workhorse <-> GitLab JWT authentication to make it reusable
See merge request gitlab-org/gitlab-ce!32623
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | | |
Introduce JWTAutheticatable module that can be reused for ai=uthtication
between Pages and GitLab (the same way we use do now for Workhorse).
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/61927.
|
| |/ /
| |
| |
| |
| |
| | |
so that we can use API::Internal namespace.
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/61927.
|
| |\ \
| | |
| | |
| | |
| | | |
Fix performance bar thresholds
See merge request gitlab-org/gitlab-ce!32587
|
| | | |
| | |
| | |
| | |
| | | |
These were written in seconds but are supposed to be in
milliseconds. The total Gitaly time was wrong for the same reason.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Resolve "Typo in RELEASE_ENDPOINT_REQUIREMETS constant"
Closes #66464
See merge request gitlab-org/gitlab-ce!32468
|
| | | |/
| |/| |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Improve GC_REPORT_BUCKETS granularity
See merge request gitlab-org/gitlab-ce!32586
|
| | | | | |
|
| |/ / / |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Modified schema via migrations.
Added one-to-one relationship between the two models.
Added changelog file
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Backport retries options for cancel_running
See merge request gitlab-org/gitlab-ce!32525
|
| | | |/
| |/| |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Remove all references to Gitlab::CorrelationId
See merge request gitlab-org/gitlab-ce!32228
|
| | | | |
| | | |
| | | |
| | | | |
This class has been replaced with Labkit::Correlation::CorrelationId
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Extends the permission of $CI_REGISTRY_USER to allow them
to delete tags in addition to just pushing.
https://gitlab.com/gitlab-org/gitlab-ce/issues/40096
|
| | | | |
| | | |
| | | | |
This allows overriding `only.refs` to something else if needed.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Prometheus listen_address can be in formats of :9090 and 0.0.0.0:9090.
But before these can be used to connect a project to Prometheus, they
have to converted into absolute URIs.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Fix permissions check in `RelativeLinkFilter`
See merge request gitlab-org/gitlab-ce!32448
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes RelativeLinkFilter for users that don't have access
to the project's repository
|
| | |_|/ /
|/| | |
| | | |
| | | | |
as requested by the reviewer
|
| | | | |
| | | |
| | | |
| | | | |
Wrong format on MS Teams integration push events with multi line commit messages
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix Peek on Puma
Closes #66528
See merge request gitlab-org/gitlab-ce!32213
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously, we called the `peek_enabled?` method like so:
prepend_before_action :set_peek_request_id, if: :peek_enabled?
Now we don't have a `set_peek_request_id` method, so we don't need that
line. However, the `peek_enabled?` part had a side-effect: it would also
populate the request store cache for whether the performance bar was
enabled for the current request or not.
This commit makes that side-effect explicit, and replaces all uses of
`peek_enabled?` with the more explicit
`Gitlab::PerformanceBar.enabled_for_request?`. There is one spec that
still sets `SafeRequestStore[:peek_enabled]` directly, because it is
contrasting behaviour with and without a request store enabled.
The upshot is:
1. We still set the value in one place. We make it more explicit that
that's what we're doing.
2. Reading that value uses a consistent method so it's easier to find in
future.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Peek's `Peek.request_id` method doesn't work well with a multi-threaded
server and concurrent requests, because requests can 'steal' another
request's ID, or unset it before it was due.
The upstream change resolves this; the commit here is just to ensure
that GitLab works with that upstream change, mostly by not using
`Peek.request_id` any more (as the method doesn't exist).
|
| | | | | | |
|
| | |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Pass in a nil project to Gitlab::SlashCommands::ApplicationHelp.new
if the chatops command is help.
- Modify the Gitlab::SlashCommands::Presenters::Help message to skip
printing out project information.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix 500 error in CI lint when included templates are an array
Closes #66605
See merge request gitlab-org/gitlab-ce!32232
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously the following syntax would fail in the linter with an
error 500:
```
include:
template:
- License-Management.gitlab-ci.yml
- Dependency-Scanning.gitlab-ci.yml
- SAST.gitlab-ci.yml
```
Now the error will call out specifically that the value
is not a string.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66605
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Move generic k8s services out of GCP namespace
See merge request gitlab-org/gitlab-ce!32310
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
These services aren't specific to GCP, and will be used for AWS
as part of https://gitlab.com/gitlab-org/gitlab-ce/issues/46686
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Improve chatops help output
See merge request gitlab-org/gitlab-ce!32208
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This improves the output produced when running an unknown command,
running the "help" command, and when trying to run a command you are not
allowed to run. The new help output includes links to the project of the
chatops integration, and a link to the chatops documentation.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
All avatars now visible in commit trailers.
|
| | |_|_|_|_|/
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This fixes a bug in which sidekiq histograms contain invalid labels.
See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/7729
for more details.
|
| | | | | | | |
|