summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* CE port for pipelines for external pull requestsce-detect-github-pull-requestsFabio Pitino2019-09-053-1/+4
| | | | | | | | | | | | | | | Detect if pipeline runs for a GitHub pull request When using a mirror for CI/CD only we register a pull_request webhook. When a pull_request webhook is received, if the source branch SHA matches the actual head of the branch in the repository we create immediately a new pipeline for the external pull request. Otherwise we store the pull request info for when the push webhook is received. When using "only/except: external_pull_requests" we can detect if the pipeline has a open pull request on GitHub and create or not the job based on that.
* Add .gitlab/ci/frontend.gitlab-ci.yml to frontend review rouletteWinnie Hellmann2019-09-051-1/+2
|
* Merge branch 'remove-unnecessary-freeze-in-lib-gitlab' into 'master'Jan Provaznik2019-09-0561-117/+119
|\ | | | | | | | | Avoid calling freeze on already frozen strings in lib/gitlab See merge request gitlab-org/gitlab-ce!32637
| * Avoid calling freeze on already frozen strings in lib/gitlabdineshpanda2019-09-0461-117/+119
| |
* | Add spaces to devops ci template to reduce warningsMarcel Amirault2019-09-051-11/+11
| |
* | Allow not resolvable urls when rebinding setting is disabledFrancisco Javier López2019-09-051-2/+6
| | | | | | | | | | Now, when the dns rebinging setting is disabled, we will allow urls that are not resolvable.
* | Upgrade graphql gem to 1.9.10Brett Walker2019-09-043-2/+6
| | | | | | | | | | | | - `edge_nodes` needs to get called on the object - added `include GlobalID::Identification` in a couple places - renamed `object` to `item` in spec due to conflict
* | Show meaningful message on /due quick action with invalid date🙈 jacopo beschi 🙉2019-09-041-1/+5
| | | | | | | | | | When using /due quick action with an invalid date a meaninful error message is shown.
* | Upgrade GraphQL gem to 1.8.17Brett Walker2019-09-047-11/+17
| | | | | | | | | | | | | | | | | | - Due to https://github.com/exAspArk/batch-loader/pull/32, we changed BatchLoader.for into BatchLoader::GraphQL.for - since our results are wrapped in a BatchLoader::GraphQL, calling `sync` during authorization is required to get real object - `graphql` now has it's own authorization system. Our `authorized?` method conflicted and required renaming
* | Let project reporters create issue from group boardsFelipe Artur2019-09-041-0/+2
| | | | | | | | | | The current state of group issue boards does not show the "Add issues" button on the UI for users that are reporters of group child projects.
* | Add epic_iid to issue API entityWinnie Hellmann2019-09-041-1/+4
| | | | | | | | (cherry picked from commit 0bf7fecdee5a200eeb4f27b4888a57ceee63bde9)
* | Merge branch 'persist-needs-error' into 'master'Grzegorz Bizon2019-09-042-2/+7
|\ \ | | | | | | | | | | | | Persist `needs:` validation as config error See merge request gitlab-org/gitlab-ce!32648
| * | Persist `needs:` validation as config errorpersist-needs-errorKamil Trzciński2019-09-042-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | In case when `needs:` is missing, but when requested by service, we would not save the pipeline with config_error. This makes it explicit that we want to persist the error as `config_error` failure reason.
* | | Backport EE changes for productivity analyticsPavel Shutsin2019-09-041-0/+6
| | | | | | | | | | | | Improve diff lines count efficiency
* | | Merge branch '61927-internal-api-jwt-auth' into 'master'Kamil Trzciński2019-09-042-26/+44
|\ \ \ | | | | | | | | | | | | | | | | Extract Workhorse <-> GitLab JWT authentication to make it reusable See merge request gitlab-org/gitlab-ce!32623
| * | | Extract Workhorse <-> GitLab authentication to make it reusable61927-internal-api-jwt-authKrasimir Angelov2019-09-042-26/+44
| | |/ | |/| | | | | | | | | | | | | | | | Introduce JWTAutheticatable module that can be reused for ai=uthtication between Pages and GitLab (the same way we use do now for Workhorse). Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/61927.
* | | Rename API::Internal class to API::Internal::Base61927-internal-api-namespaceKrasimir Angelov2019-09-043-295/+297
|/ / | | | | | | | | | | so that we can use API::Internal namespace. Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/61927.
* | Merge branch 'fix-performance-bar-thresholds' into 'master'Stan Hu2019-09-032-9/+9
|\ \ | | | | | | | | | | | | Fix performance bar thresholds See merge request gitlab-org/gitlab-ce!32587
| * | Fix performance bar thresholdsfix-performance-bar-thresholdsSean McGivern2019-09-032-9/+9
| | | | | | | | | | | | | | | These were written in seconds but are supposed to be in milliseconds. The total Gitaly time was wrong for the same reason.
* | | Merge branch '66464-typo-in-release_endpoint_requiremets-constant' into 'master'Michael Kozono2019-09-032-6/+6
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Typo in RELEASE_ENDPOINT_REQUIREMETS constant" Closes #66464 See merge request gitlab-org/gitlab-ce!32468
| * | | Correct typo in constant66464-typo-in-release_endpoint_requiremets-constantSean Carroll2019-09-022-6/+6
| | |/ | |/|
* | | Merge branch '65509-improve-gc-report-buckets-granularity' into 'master'Kamil Trzciński2019-09-031-1/+1
|\ \ \ | | | | | | | | | | | | | | | | Improve GC_REPORT_BUCKETS granularity See merge request gitlab-org/gitlab-ce!32586
| * | | Improve GC_REPORT_BUCKETS granularity65509-improve-gc-report-buckets-granularityAleksei Lipniagov2019-09-031-1/+1
| | | |
* | | | Remove outdated mail_room checkWinnie Hellmann2019-09-032-27/+0
|/ / /
* | | Added relationships between Release and MilestoneEtienne Baqué2019-09-032-0/+3
| | | | | | | | | | | | | | | | | | Modified schema via migrations. Added one-to-one relationship between the two models. Added changelog file
* | | Merge branch 'ce-12996-cancel-redundant-pipelines' into 'master'Lin Jen-Shin2019-09-031-1/+2
|\ \ \ | | | | | | | | | | | | | | | | Backport retries options for cancel_running See merge request gitlab-org/gitlab-ce!32525
| * | | Backport EE issue 12996ce-12996-cancel-redundant-pipelinesSean Carroll2019-09-021-1/+2
| | |/ | |/|
* | | Merge branch 'an-use-labkit-correlation-id' into 'master'Ash McKenzie2019-09-032-41/+1
|\ \ \ | | | | | | | | | | | | | | | | Remove all references to Gitlab::CorrelationId See merge request gitlab-org/gitlab-ce!32228
| * | | Remove all references to Gitlab::CorrelationIdan-use-labkit-correlation-idAndrew Newdigate2019-08-262-41/+1
| | | | | | | | | | | | | | | | This class has been replaced with Labkit::Correlation::CorrelationId
* | | | If user can push to docker then it can delete tooGiorgenes Gelatti2019-09-031-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Extends the permission of $CI_REGISTRY_USER to allow them to delete tags in addition to just pushing. https://gitlab.com/gitlab-org/gitlab-ce/issues/40096
* | | | Update Code-Quality.gitlab-ci.yml to use `only.refs`Rémy Coutable2019-09-021-2/+3
| | | | | | | | | | | | This allows overriding `only.refs` to something else if needed.
* | | | Handle :9090 and 0.0.0.0:9090 listen_address formatsReuben Pereira2019-09-021-14/+26
| | | | | | | | | | | | | | | | | | | | | | | | Prometheus listen_address can be in formats of :9090 and 0.0.0.0:9090. But before these can be used to connect a project to Prometheus, they have to converted into absolute URIs.
* | | | Merge branch '66803-fix-uploads-relative-link-filter' into 'master'Grzegorz Bizon2019-09-021-10/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix permissions check in `RelativeLinkFilter` See merge request gitlab-org/gitlab-ce!32448
| * | | | Fix upload URLs in Markdown66803-fix-uploads-relative-link-filterHeinrich Lee Yu2019-09-021-10/+3
| | | | | | | | | | | | | | | | | | | | | | | | | Fixes RelativeLinkFilter for users that don't have access to the project's repository
* | | | | Remove reference of external examplemdhtr2019-09-021-0/+29
| |_|/ / |/| | | | | | | | | | | as requested by the reviewer
* | | | Fixing #65389Massimeddu Cireddu2019-09-022-1/+5
| | | | | | | | | | | | | | | | Wrong format on MS Teams integration push events with multi line commit messages
* | | | Merge branch 'fix-peek-on-puma' into 'master'Rémy Coutable2019-09-026-21/+13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix Peek on Puma Closes #66528 See merge request gitlab-org/gitlab-ce!32213
| * | | | Make performance bar enabled checks consistentSean McGivern2019-08-286-20/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, we called the `peek_enabled?` method like so: prepend_before_action :set_peek_request_id, if: :peek_enabled? Now we don't have a `set_peek_request_id` method, so we don't need that line. However, the `peek_enabled?` part had a side-effect: it would also populate the request store cache for whether the performance bar was enabled for the current request or not. This commit makes that side-effect explicit, and replaces all uses of `peek_enabled?` with the more explicit `Gitlab::PerformanceBar.enabled_for_request?`. There is one spec that still sets `SafeRequestStore[:peek_enabled]` directly, because it is contrasting behaviour with and without a request store enabled. The upshot is: 1. We still set the value in one place. We make it more explicit that that's what we're doing. 2. Reading that value uses a consistent method so it's easier to find in future.
| * | | | Fix Peek on PumaSean McGivern2019-08-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Peek's `Peek.request_id` method doesn't work well with a multi-threaded server and concurrent requests, because requests can 'steal' another request's ID, or unset it before it was due. The upstream change resolves this; the commit here is just to ensure that GitLab works with that upstream change, mostly by not using `Peek.request_id` any more (as the method doesn't exist).
* | | | | Tidy up conditional messagecharlieablett2019-09-021-5/+7
| | | | |
* | | | | Handle projectless `help` commands to chatopscharlieablett2019-09-021-4/+10
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | - Pass in a nil project to Gitlab::SlashCommands::ApplicationHelp.new if the chatops command is help. - Modify the Gitlab::SlashCommands::Presenters::Help message to skip printing out project information.
* | | | Merge branch 'sh-fix-ci-lint-500-error' into 'master'Ash McKenzie2019-09-021-1/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix 500 error in CI lint when included templates are an array Closes #66605 See merge request gitlab-org/gitlab-ce!32232
| * | | | Fix 500 error in CI lint when included templates are an arraysh-fix-ci-lint-500-errorStan Hu2019-08-311-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the following syntax would fail in the linter with an error 500: ``` include: template: - License-Management.gitlab-ci.yml - Dependency-Scanning.gitlab-ci.yml - SAST.gitlab-ci.yml ``` Now the error will call out specifically that the value is not a string. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66605
* | | | | Merge branch '46686-move-k8s-services-out-of-gcp-namespace' into 'master'66783-usage-ping-for-slack-integrationsThong Kuah2019-09-011-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Move generic k8s services out of GCP namespace See merge request gitlab-org/gitlab-ce!32310
| * | | | | Move generic k8s services out of GCP namespace46686-move-k8s-services-out-of-gcp-namespaceTiger2019-08-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These services aren't specific to GCP, and will be used for AWS as part of https://gitlab.com/gitlab-org/gitlab-ce/issues/46686
* | | | | | Merge branch 'improve-chatops-help' into 'master'Nick Thomas2019-09-015-25/+75
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve chatops help output See merge request gitlab-org/gitlab-ce!32208
| * | | | | | Improve chatops help outputimprove-chatops-helpYorick Peterse2019-08-295-25/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This improves the output produced when running an unknown command, running the "help" command, and when trying to run a command you are not allowed to run. The new help output includes links to the project of the chatops integration, and a link to the chatops documentation.
* | | | | | | Fix for #56295, https://gitlab.com/gitlab-org/gitlab-ce/issues/56295.Jesse Hall2019-08-301-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | All avatars now visible in commit trailers.
* | | | | | | Fix for histogram corruption in SidekiqAndrew Newdigate2019-08-301-1/+1
| |_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a bug in which sidekiq histograms contain invalid labels. See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/7729 for more details.
* | | | | | Resolve "Use "moved" instead of "closed" in issue references"Juliette de Rancourt2019-08-301-1/+6
| | | | | |