| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |\
| |
| |
| |
| | |
Remove deprecated field from workhorse API responses
See merge request !13567
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
Related to !13108. Mostly this is just running the rake task and
changing the task a bit to catch cases like the project already existing
or so. The rake task moves archives to the vendor/project_template
directory, which are checked in too.
|
| |\ \
| | |
| | |
| | |
| | | |
Handle missing .gitmodules when getting submodule urls
See merge request !13509
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Migrate `Git::Repository.ls_files` to Gitaly
Closes gitaly#404
See merge request !13302
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix: Thread safe GPGME tmp directory
Closes #35986
See merge request !13481
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
setting of the gpg home directory is not thread safe, as the directoy
gets stored on the class.
if multiple threads change the directory at the same time, one of the
threads will be working in the wrong directory.
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Don't rename system when migrating from 9.x -> 9.4
Closes #35525 and #36148
See merge request !13228
|
| | | |_|/
| |/| |
| | | |
| | | |
| | | | |
Update the markdown unconditionally since the move might have been
done before, but the markdown not updated.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Migrate force push check to Gitaly
See merge request !13406
|
| | | |_|/
| |/| | |
|
| | |/ /
|/| |
| | |
| | | |
Also marks a few things as uncovered, and removes an unused class.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Use a separate table for storing push events
See merge request !12463
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This changes various controllers to use the new EventCollection class
for retrieving events. This class uses a JOIN LATERAL query on
PostgreSQL to retrieve queries in a more efficient way, while falling
back to a simpler / less efficient query for MySQL.
The EventCollection class also includes a limit on the number of events
to display to prevent malicious users from cycling through all events,
as doing so could put a lot of pressure on the database.
JOIN LATERAL is only supported on PostgreSQL starting with version 9.3.0
and as such this optimisation is only used when using PostgreSQL 9.3 or
newer.
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit migrates events data in such a way that push events are
stored much more efficiently. This is done by creating a shadow table
called "events_for_migration", and a table called "push_event_payloads"
which is used for storing push data of push events. The background
migration in this commit will copy events from the "events" table into
the "events_for_migration" table, push events in will also have a row
created in "push_event_payloads".
This approach allows us to reclaim space in the next release by simply
swapping the "events" and "events_for_migration" tables, then dropping
the old events (now "events_for_migration") table.
The new table structure is also optimised for storage space, and does
not include the unused "title" column nor the "data" column (since this
data is moved to "push_event_payloads").
== Newly Created Events
Newly created events are inserted into both "events" and
"events_for_migration", both using the exact same primary key value. The
table "push_event_payloads" in turn has a foreign key to the _shadow_
table. This removes the need for recreating and validating the foreign
key after swapping the tables. Since the shadow table also has a foreign
key to "projects.id" we also don't have to worry about orphaned rows.
This approach however does require some additional storage as we're
duplicating a portion of the events data for at least 1 release. The
exact amount is hard to estimate, but for GitLab.com this is expected to
be between 10 and 20 GB at most. The background migration in this commit
deliberately does _not_ update the "events" table as doing so would put
a lot of pressure on PostgreSQL's auto vacuuming system.
== Supporting Both Old And New Events
Application code has also been adjusted to support push events using
both the old and new data formats. This is done by creating a PushEvent
class which extends the regular Event class. Using Rails' Single Table
Inheritance system we can ensure the right class is used for the right
data, which in this case is based on the value of `events.action`. To
support displaying old and new data at the same time the PushEvent class
re-defines a few methods of the Event class, falling back to their
original implementations for push events in the old format.
Once all existing events have been migrated the various push event
related methods can be removed from the Event model, and the calls to
`super` can be removed from the methods in the PushEvent model.
The UI and event atom feed have also been slightly changed to better
handle this new setup, fortunately only a few changes were necessary to
make this work.
== API Changes
The API only displays push data of events in the new format. Supporting
both formats in the API is a bit more difficult compared to the UI.
Since the old push data was not really well documented (apart from one
example that used an incorrect "action" nmae) I decided that supporting
both was not worth the effort, especially since events will be migrated
in a few days _and_ new events are created in the correct format.
|
| | | |
| | |
| | |
| | |
| | | |
Not all diffs in st_diffs had the too_large attribute set at all, but the column
is non-nullable. Explicitly cast to boolean to avoid that problem.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Expose the raw_log method
See merge request !13434
|
| | | |/
| |/| |
|
| | | |
| | |
| | |
| | |
| | | |
Ensure user and hostnames begin with an alnum character in UrlBlocker
See merge request !2138
|
| | |/
|/|
| |
| |
| | |
Fix file disclosure via hidden symlinks using the project import (9.3)
See merge request !2164
|
| | | |
|
| | |
| |
| |
| | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |/
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Incorporate Gitaly's CommitService.FindCommit RPC
Closes gitaly#402
See merge request !13094
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
This helps keep the abstraction layers simpler, and also keep the
interface of those methods consistent, in case of implementation
changes.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It is recommended that we set this to 50:
https://gitlab.com/gitlab-org/gitlab-ce/issues/35098#note_35036746
In this particular issue, the confidence was 42 for Shift JIS,
but in fact that's encoded in UTF-8 just with a single bad
character. In this case, we shouldn't try to treat it as Shift JIS,
but just treat it as UTF-8 and remove invalid bytes.
Treating it like Shift JIS would corrupt the whole data.
Unfortunately, the diff which would cause this could not be
disclosed therefore we can't use it as a test example.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Resolve "Store MergeWorker JID on merge request, and clean up stuck merges"
Closes #31207
See merge request !13207
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Migrate Repository#find_commits_by_message to Gitaly
Closes gitaly#443
See merge request !13268
|
| | |/ /
| | |
| | |
| | | |
Closes gitaly#443
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Migrate Gitlab::Git::Repository#size to Gitaly
Closes gitaly#437
See merge request !13259
|
| | |/ /
| | |
| | |
| | | |
Closes gitaly#437
|
| |\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | | |
Backport changes in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2551 to CE
Closes #21391
See merge request !13275
|
| | | |
| | |
| | |
| | | |
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2551 to CE
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Add Gitlab::Git::Blob.batch method
See merge request !13225
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Improve GitHub importer
Closes #27429
See merge request !12886
|
| | | |_|/
| |/| | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Allow projects to be started from a template
Closes #32420
See merge request !13108
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Originally picked as: 3fc0dbcbebcd470fe14f8b5fb7ad55dc3912402e. But
given the internals changed, this was changed now. The changelog was
removed too.
|
