| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This reverts commit 7549102bb727daecc51da84af39956b32fc41537.
Apparently I was wrong about
ActiveSupport::Notifications::Event#duration returning the duration in
seconds, instead it returns it in milliseconds already.
|
|
|
|
|
| |
InfluxDB over UDP doesn't use authentication, thus there's no need for
these settings.
|
|
|
|
|
| |
Transaction timings are also already stored in milliseconds, this keeps
things consistent.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Tuning of metrics data to store
This removes data we don't really need, as well as making sure we don't overload any cache stores or databases.
See merge request !2265
|
| |
| |
| |
| |
| | |
This ensures Rails and Sidekiq transactions are split into the series
"rails_transactions" and "sidekiq_transactions" respectively.
|
| |
| |
| |
| |
| | |
This removes the need for any tags to differentiate between Sidekiq and
Rails statistics while still being able to separate the two.
|
| |
| |
| |
| |
| | |
This makes it easier to see where time is spent without having to
aggregate all the individual points in the method_calls series.
|
| | |
|
| |
| |
| |
| |
| |
| | |
This will be used to store/increment the total query/view rendering
timings on a per transaction basis. This in turn can greatly reduce the
amount of metrics stored.
|
| |
| |
| |
| |
| | |
This isn't hugely useful and mostly wastes InfluxDB space. We can re-add
this whenever needed (but only once we really need it).
|
| |
| |
| |
| | |
This removes the need for tagging all metrics with a "process_type" tag.
|
| |
| |
| |
| |
| | |
This ensures we don't need to load anything from either PostgreSQL or
the Rails cache whenever creating new InfluxDB connections.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This particular setup had 3 problems:
1. Storing SQL queries as tags is very inefficient as InfluxDB ends up
indexing every query (and they can get pretty large). Storing these
as values instead means we can't always display the SQL as easily.
2. We already instrument ActiveRecord query methods, thus we already
have timing information about database queries.
3. SQL obfuscation is difficult to get right and I'd rather not expose
sensitive data by accident.
|
|/ |
|
|
|
|
|
|
|
|
| |
While it's useful to keep track of the different versions (Ruby, GitLab,
etc) doing so for every point wastes disk space and possibly also RAM
(which InfluxDB is all to eager to gobble up). If we want to see the
performance differences between different GitLab versions simply looking
at the performance since the last release date should suffice.
|
| |
|
|
|
|
|
| |
This ensures we can still start up even when not connecting to a
database.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the need for Sidekiq and any overhead/problems introduced
by TCP. There are a few things to take into account:
1. When writing data to InfluxDB you may still get an error if the
server becomes unavailable during the write. Because of this we're
catching all exceptions and just ignore them (for now).
2. Writing via UDP apparently requires the timestamp to be in
nanoseconds. Without this data either isn't written properly.
3. Due to the restrictions on UDP buffer sizes we're writing metrics one
by one, instead of writing all of them at once.
|
|
|
|
|
| |
Newlines aren't really needed and they may mess with InfluxDB's line
protocol.
|
|\
| |
| |
| |
| |
| |
| | |
Makes reCAPTCHA configurable through Application Settings screen
Following the work made by @stanhu here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2216, made it configurable without needing to restart Gitlab
See merge request !2231
|
| | |
|
|/
|
|
|
| |
This ensures we can still boot, even when the "application_settings"
table doesn't exist.
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Storing of application metrics in InfluxDB
This adds support for tracking metrics in InfluxDB, which in turn can be visualized using Grafana. For more information see #2936.
See merge request !2042
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
This allows us to track the counts of actual classes instead of "T_XXX"
nodes. This is only enabled on CRuby as it uses CRuby specific APIs.
|
| |
| |
| |
| | |
This will be used to (for example) instrument all ActiveRecord models.
|
| |
| |
| |
| |
| |
| |
| | |
This ensures we don't end up wasting resources by tracking method calls
that only take a few microseconds. By default the threshold is 10
milliseconds but this can be changed using the gitlab.yml configuration
file.
|
| |
| |
| |
| |
| | |
This makes it possible to determine if a method should be instrumented
or not using a block.
|
| |
| |
| |
| |
| |
| | |
This allows the information to be displayed when using certain functions
(e.g. top()) as well as making it easier to aggregate on a per file
basis.
|
| |
| |
| |
| |
| |
| |
| | |
InfluxDB escapes double quotes upon output which makes it a pain to deal
with. This ensures that if we're using PostgreSQL we don't store any
queries containing double quotes in InfluxDB, solving the escaping
problem.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When using instrument_methods/instrument_instance_methods we only want
to instrument methods defined directly in a class, not those included
via mixins (e.g. whatever RSpec throws in during development).
In case an externally included method _has_ to be instrumented we can
still use the regular instrument_method/instrument_instance_method
methods.
|
| |
| |
| |
| |
| | |
This makes it easier to instrument multiple modules without having to
type the full namespace over and over again.
|
| |
| |
| |
| |
| |
| | |
The methods Instrumentation.instrument_methods and
Instrumentation.instrument_instance_methods can be used to instrument
all methods of a module at once.
|
| |
| |
| |
| |
| | |
This ensures that methods such as "==" can be instrumented without
producing syntax errors.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The use of ActiveSupport would slow down instrumented method calls by
about 180x due to:
1. ActiveSupport itself not being the fastest thing on the planet
2. caller_locations() having quite some overhead
The use of caller_locations() has been removed because it's not _that_
useful since we already know the full namespace of receivers and the
names of the called methods.
The use of ActiveSupport has been replaced with some custom code that's
generated using eval() (which can be quite a bit faster than using
define_method).
This new setup results in instrumented methods only being about 35-40x
slower (compared to non instrumented methods).
|
| |
| |
| |
| |
| | |
This is faster than using define_method since we don't have to keep
block bindings around.
|