summaryrefslogtreecommitdiff
path: root/lib/banzai
Commit message (Collapse)AuthorAgeFilesLines
* DRY up caching in AbstractReferenceFilterSean McGivern2017-08-071-40/+20
| | | | | We had a lot of copied and pasted code, when the different elements were very small and easy to get wrong.
* Support references to group milestonesSean McGivern2017-08-072-11/+64
| | | | | Group milestones can only be referred to by name, not IID. They also do not support cross-project references.
* Don't bother going through an entire Banzai pipeline for empty textrs-minor-banzai-perfRobert Speicher2017-08-031-0/+2
| | | | | | | | | | This bails out of `cacheless_render` immediately unless the provided text is present, since there's no point. This is a slight improvement in our test performance. Across the creation of 1,000 `Namespace` records, which caches the `description` field and which is blank by default in its factory, this saves about four seconds, which... sure. Why not.
* Rename more path_with_namespace -> full_path or disk_pathGabriel Mazetto2017-08-011-1/+1
|
* Rename many path_with_namespace -> full_pathGabriel Mazetto2017-08-012-3/+3
|
* Resolve "Lazy load images on the Frontend"Tim Zallmann2017-07-245-2/+20
|
* Support both internal and external issue trackersJarka Kadlecova2017-07-242-4/+8
|
* Merge branch 'acet-fix-tooltip-placement' into 'master'Jacob Schatz2017-07-061-0/+2
|\ | | | | | | | | | | | | Fix markdown preview tooltip cut off issue Closes #31748 See merge request !12367
| * Banzai: Add tooltip attributes to reference filter.acet-fix-tooltip-placementFatih Acet2017-07-031-0/+2
| |
* | Create and use project path helpers that only need a project, no namespaceDouwe Maan2017-07-057-8/+7
|/
* Improve support for external issue referencesadam-external-issue-references-spikeAdam Niedzielski2017-06-304-49/+5
|
* Enable Style/DotPosition Rubocop :cop:Grzegorz Bizon2017-06-213-6/+6
|
* Don't return nil for missing objects from parser cachedm-fix-parser-cacheDouwe Maan2017-06-141-1/+1
|
* Merge branch '25934-project-snippet-vis' into 'security-9-2'DJ Mountney2017-06-089-10/+14
| | | | | | Fix visibility when referencing snippets See merge request !2101
* Fix /unsubscribe slash command creating extra todos33032-invalid-you-directly-addressed-yourself-todo-when-using-unsubscribeSean McGivern2017-05-301-2/+3
| | | | | | | | | | | | | | | | | | | | | | The /unsubscribe slash command means that we check if the current user is subscribed to the issuable without having an explicit subscription. That means that we use the UserParser to find references to them in the notes. The UserParser (and all parsers inheriting from BaseParser) use RequestStore to cache ActiveRecord objects, so that we don't need to load the User object each time, if we're parsing references a bunch of times in the same request. However, it was always returning _all_ of the previously cached items, not just the ones matching the IDs passed. This would mean that we did two runs through with UserParser if you were mentioned in a comment, and then mentioned someone else in your comment while using /unsubscribe: 1. Because /unsubscribe was used, we see if you were mentioned in any comments. 2. Because you mentioned someone, we find them - but we would also get back your user, even if you didn't mention yourself. This would have the effect of creating a mention or directly addressed todo for yourself incorrectly. The fix is simple: only return values from the cache matching the IDs passed.
* Merge branch '29852-latex-formatting' into 'master'Robert Speicher2017-05-243-0/+31
|\ | | | | | | | | | | | | Fix LaTeX formatting for AsciiDoc wiki Closes #29852 See merge request !11212
| * Fix LaTeX formatting for AsciiDoc wikiJarka Kadlecova2017-05-243-0/+31
| |
* | Catch all URI errors in ExternalLinkFilterdm-catch-uri-errorsDouwe Maan2017-05-181-1/+1
|/
* Merge branch 'bvl-security-9-1-validate-urls-in-markdown-using-uri'Robert Speicher2017-05-101-18/+18
| | | | | | (security-9-1) Add correct `rel` attributes to external links when rendering markdown See merge request !2097
* Merge branch 'bvl-security-9-1-markup-pipeline'Robert Speicher2017-05-101-0/+13
| | | | | | (security-9-1) Render asciidoc & other markup using banzai in a pipeline See merge request !2098
* Backport of multiple_assignees_feature [ci skip]Valery Sizov2017-05-041-1/+1
|
* Remove N+1 queries when checking nodes visible to userfix-n-plus-one-project-featuresSean McGivern2017-05-021-1/+2
| | | | | | | N in this case is low, as it's the number of distinct projects referenced from MRs, rather than the number of MRs referenced (issues use their own optimization). Still, on issues or MRs which are often referenced from MRs, it will save a few queries.
* Merge branch 'blackst0ne/gitlab-ce-fix_emoji_parser'Sean McGivern2017-04-271-1/+4
|\
| * Fix rendering emoji inside a stringblackst0ne2017-04-251-1/+4
| |
* | issues_for_nodes => issuables_for_nodes31280-skip-issueables-without-projectLin Jen-Shin2017-04-261-3/+3
| |
* | Follow feedback on the reviewLin Jen-Shin2017-04-261-4/+4
| |
* | Skip issuable without a project in IssuableExtractor#extractLin Jen-Shin2017-04-251-1/+5
| | | | | | | | Closes #31280
* | Start versioning cached markdown fieldsNick Thomas2017-04-211-14/+7
| |
* | Remove a use of module_functionNick Thomas2017-04-211-12/+10
| |
* | Merge branch 'issuable-state-custom-links' into 'master' Sean McGivern2017-04-201-2/+2
|\ \ | | | | | | | | | | | | | | | | | | Do not append issuable state to links with custom anchor Closes #30916 See merge request !10782
| * | Do not append issuable state to links with custom anchorissuable-state-custom-linksAdam Niedzielski2017-04-191-2/+2
| | | | | | | | | | | | | | | Closes #30916 Change the presentation from [closed] to (closed)
* | | Merge branch 'plantuml-filter-after-highlight' into 'master' Sean McGivern2017-04-201-4/+4
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Fix PlantUML integration in GFM Closes #30557 See merge request !10651
| * | Fix PlantUML integration in GFMplantuml-filter-after-highlightAdam Niedzielski2017-04-191-4/+4
| | | | | | | | | | | | | | | Fixes #30557 Use "lang" attribute instead of "class" in PlantumlFilter.
* | | Display issuable state only in notes and issuable descriptionAdam Niedzielski2017-04-191-0/+2
|/ / | | | | | | Closes #30964
* | Fix regression in rendering Markdown references that do not existsh-fix-base-parserStan Hu2017-04-151-1/+2
| | | | | | | | Closes #30972
* | Fix appending state to issuable referencesfix-appending-state-to-issuable-referencesAdam Niedzielski2017-04-131-2/+2
|/ | | | | | | Closes #30874. Ignore nodes with no children. Append directly to the node instead of the last child of the node to avoid inheriting formatting from the last child
* Reuse "merge_requests_for_nodes" in "MergeRequestParser"merge-request-parser-merge-requests-for-nodesAdam Niedzielski2017-04-101-11/+30
|
* Add indication for closed or merged issuables in GFMadam-finish-5993-closed-issuableAdam Buckland2017-04-079-40/+124
| | | | | | | | | | | | | | | Example: for issues that are closed, the links will now show '[closed]' following the issue number. This is done as post-process after the markdown has been loaded from the cache as the status of the issue may change between the cache being populated and the content being displayed. In order to avoid N+1 queries problem when rendering notes ObjectRenderer populates the cache of referenced issuables for all notes at once, before the post processing phase. As a part of this change, the Banzai BaseParser#grouped_objects_for_nodes method has been refactored to return a Hash utilising the node itself as the key, since this was a common pattern of usage for this method.
* Merge branch '30125-markdown-security'Robert Speicher2017-04-055-25/+16
| | | | | | Remove class from SanitizationFilter whitelist See merge request !2079
* Merge branch 'make_user_mentions_case_insensitive' into 'master' Sean McGivern2017-03-291-2/+2
|\ | | | | | | | | | | | | Make user mentions case-insensitive Closes #24493 See merge request !10285
| * Make user mentions case-insensitiveblackst0ne2017-03-291-2/+2
| |
* | Get rid of a third N+1 query problemRémy Coutable2017-03-281-1/+3
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Get rid of second N+1 query problemRémy Coutable2017-03-281-0/+4
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Get rid of a first N+1 query problemRémy Coutable2017-03-281-2/+21
|/ | | | | | | Use the same approach in Banzai::Filter::MergeRequestReferenceFilter as we do with issues. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch 'fix-links-target-blank' into 'security'Jacob Schatz2017-03-202-2/+3
| | | | | | Adds rel="noopener noreferrer" to all links with target="_blank" See merge request !2071
* Use Enumerable#index_by where possibledm-use-index-byDouwe Maan2017-03-163-13/+3
|
* remove all references to the .es6 in our config files and documentationremove-es6-extension-configurationMike Greiling2017-03-151-2/+2
|
* Copy code as GFM from diffs, blobs and GFM code blocksDouwe Maan2017-03-141-12/+1
|
* use a magic default :global symbol instead of nilhttp://jneen.net/2017-03-091-1/+1
| | | | to make sure we mean the global permissions
* Merge branch '26371-native-emojis-v3' into 'master' Filipa Lacerda2017-03-071-53/+11
|\ | | | | | | | | | | | | Add emoji images - Base Native Unicode Emojis Closes #26371 See merge request !9569
View Lorry Controller Status