summaryrefslogtreecommitdiff
path: root/lib/banzai/pipeline
Commit message (Collapse)AuthorAgeFilesLines
* Fix description and GFM pipelines conflictingfix-markdown-specSean McGivern2016-06-131-12/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Consider this command: bundle exec rails r "include GitlabMarkdownHelper puts markdown('<span>this is a span</span>', pipeline: :description) puts markdown('<span>this is a span</span>')" And the same in the opposite order: bundle exec rails r "include GitlabMarkdownHelper puts markdown('<span>this is a span</span>') puts markdown('<span>this is a span</span>', pipeline: :description)" Before this change, they would both output: <p><span>this is a span</span></p> <p>this is a span</p> That's because `span` is added to the list of whitelisted elements in the `SanitizationFilter`, but this method tries not to make the same changes multiple times. Unfortunately, `HTML::Pipeline::SanitizationFilter::LIMITED`, which is used by the `DescriptionPipeline`, uses the same Ruby objects for all of its hash values _except_ `:elements`. That means that whichever of `DescriptionPipeline` and `GfmPipeline` is called first would have `span` in its whitelisted elements, and the second wouldn't. Fix this by creating an entirely separate hash, before either pipeline is invoked.
* Split Markdown rendering & reference gatheringYorick Peterse2016-05-261-11/+0
| | | | | | | | | | This splits the Markdown rendering and reference extraction phases into two distinct code bases. The reference extraction phase no longer relies on the html-pipeline Gem (and any related code) and allows for extracting of references from multiple HTML nodes in a single pass. This means that if you want to extract user references from 200 comments you no longer need to run 200 times N number of queries, instead only a handful of queries may be needed.
* Create DiffFilter and change SystemNoteService#change_title to use ↵Adam Butler2016-05-181-1/+2
| | | | Gitlab::Diff::InlineDiff
* Merge branch 'patch/fix-markdown-preview-wikis' into 'master' Robert Speicher2016-04-071-2/+4
|\ | | | | | | | | | | | | | | | | | | | | Wiki preview URL converting problem [via Markdown] Current implementation when rendering the preview, thinks relative links are for project repository files. We are creating a new preview route that will define correct context data to render for wikis instead. Fixes #2380, #1184 See merge request !3461
| * Ensure correct filter order to validate with our markdown specpatch/fix-markdown-preview-wikisGabriel Mazetto2016-04-061-1/+1
| |
| * Fixed WikiPipeline and specsGabriel Mazetto2016-04-061-1/+1
| |
| * Added WikiLinkFilterGabriel Mazetto2016-04-011-2/+4
| |
* | Wrap images in discussions and wikis with a link to the image source using ↵connorshea2016-04-041-0/+1
|/ | | | | | | | ImageLinkFilter. Resolves #14411. See merge request !3464
* Remove redundant `require`s from Banzai filesrs-banzai-requiresRobert Speicher2016-03-242-4/+0
| | | | We're trying to avoid circular dependency errors.
* Add YamlFrontMatterFilter to the PreProcessPipelineRobert Speicher2016-03-041-1/+2
| | | | | This filter will detect YAML Front Matter and convert it to an HTML table for prettier formatting.
* Add a PreProcessPipelineRobert Speicher2016-03-021-0/+16
|
* Add FilterArray class to Banzairs-filter-arrayRobert Speicher2016-03-019-13/+10
|
* Replace Gollum `[[_TOC_]]` tag with result of TableOfContentsFilterrs-wiki-tocRobert Speicher2016-02-231-1/+5
| | | | Closes #2494
* Fix relative links in other markup formatsben.boeckel/gitlab-ce-fixup-links-in-generic-docsBen Boeckel2016-02-121-11/+0
| | | | | | | | - Apply the RelativeLinkFilter filter to other formats, e.g., reStructuredText so links from the Files view or the Project view work - Remove the AsciidocPipeline pipeline Fixes #3533.
* Allow limited Markdown in Broadcast Messagesrs-broadcast-markdownRobert Speicher2016-02-061-0/+16
| | | | Closes #11853
* Make Pipelines responsible for defining their custom whitelistrs-whitelist-in-pipelineRobert Speicher2016-02-031-1/+12
| | | | | This allows for future pipelines to more easily define a custom whitelist.
* Merge branch 'backport-ee' into 'master' Robert Speicher2016-01-1413-25/+0
|\ | | | | | | | | | | | | Backport two commits from EE Backport part of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/110 See merge request !2424
| * Prevent circular reference error in BanzaiDouwe Maan2016-01-1413-25/+0
| |
* | Remove GollumTagsPipelineDouglas Barbosa Alexandre2016-01-142-15/+4
| |
* | Use the WikiPipeline when rendering the wiki markdown contentDouglas Barbosa Alexandre2016-01-142-0/+22
|/
* Merge branch 'milestone-ref' into 'master' Robert Speicher2016-01-071-0/+1
|\ | | | | | | | | | | | | Link to milestone in "Milestone changed" system note Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/4141 See merge request !2203
| * Render milestone links as referencesDouwe Maan2015-12-241-0/+1
| |
* | Define a limited set of filters for SingleLinePipeliners-issue-1697Robert Speicher2016-01-051-0/+16
|/ | | | | | | | | | | | Removes the following filters from its parent GfmPipeline: - SyntaxHighlightFilter - UploadLinkFilter - TableOfContentsFilter - LabelReferenceFilter - TaskListFilter Closes #1697
* Move Markdown/reference logic from Gitlab::Markdown to BanzaiDouwe Maan2015-12-1513-0/+230