| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| |
| | |
# Conflicts:
# spec/models/project_spec.rb
|
| | |\
| | |
| | |
| | |
| | | |
Remove PersonalAccessTokensFinder#find_by method
See merge request gitlab-org/gitlab-ce!22617
|
| | | |
| | |
| | |
| | |
| | |
| | | |
find_by_token is overriden by TokenAuthenticatable which can be easily
missed or confused with #find_by(:token) defined by ActiveRecord. First
step for safer usage is to remove #find_by.
|
| | | | |
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This completely rewrites the SnippetsFinder class from the ground up in
order to improve its performance. The old code was beyond salvaging. It
was complex, included various Rails 5 workarounds, comments that
shouldn't be necessary, and most important of all: it produced a really
poorly performing database query.
As a result, I opted for rewriting the finder from scratch, instead of
trying to patch the existing code. Instead of trying to reuse as many
existing methods as possible, I opted for defining new methods
specifically meant for the SnippetsFinder. This requires some extra code
here and there, but allows us to have much more control over the
resulting SQL queries. It is these changes that then allow us to produce
a _much_ more efficient query.
To illustrate how bad the old query was, we will use my own snippets as
an example. Currently I have 52 snippets, most of which are global ones.
To retrieve these, you would run the following Ruby code:
user = User.find_by(username: 'yorickpeterse')
SnippetsFinder.new(user, author: user).execute
On GitLab.com the resulting query will take between 10 and 15 seconds to
run, producing the query plan found at
https://explain.depesz.com/s/Y5IX. Apart from the long execution time,
the total number of buffers (the sum of all shared hits) is around 185
GB, though the real number is probably (hopefully) much lower as I doubt
simply summing these numbers produces the true total number of buffers
used.
The new query's plan can be found at https://explain.depesz.com/s/wHdN,
and this query takes between 10 and 100-ish milliseconds to run. The
total number of buffers used is only about 30 MB.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/52639
|
| |\ \
| |/
|/|
| |
| | |
Split CE and EE params in issues API
See merge request gitlab-org/gitlab-ce!22689
|
| | | |
|
| |\ \
| |/ |
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
'42790-improve-feedback-for-internal-git-access-checks-timeouts' into 'master'
Adds trace of each access check when git push times out
Closes #42790
See merge request gitlab-org/gitlab-ce!22265
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Whenever a git push takes more than 50 seconds the user
will receive a trace from each check performed along with
their timings
|
| | | | |
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Resolve "Filter by `None`/`Any` for assignee_id in issues/mrs API"
Closes #52384
See merge request gitlab-org/gitlab-ce!22598
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | |/ |
|
| | |/ |
|
| |\ \
| |/
|/|
| |
| | |
[master] Validate Wiki attachments are valid temporary files
See merge request gitlab/gitlabhq!2568
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A malicious attacker could craft a request to read arbitrary files on
the system. This change adds a Grape validation to ensure that the
tempfile parameter delivered by the Rack multipart uploader is a
Tempfile type to prevent users from being able to specify arbitrary
filenames.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53072
|
| |\ \
| |/
|/|
| |
| |
| |
| | |
Add Applications API endpoints for listing and deleting entries.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52559
See merge request https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22296
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Remove ForkedProjectLink model
Closes #38883
See merge request gitlab-org/gitlab-ce!22226
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This removes the `ForkedProjectLink` model that has been replaced by
the `ForkNetworkMember` and `ForkNetwork` combination. All existing
relations have been adjusted to use these new models.
The `forked_project_link` table has been dropped.
The "Forks" count on the admin dashboard has been updated to count all
`ForkNetworkMember` rows and deduct the number of `ForkNetwork`
rows. This is because now the "root-project" of a fork network also
has a `ForkNetworkMember` row. This count could become inaccurate when
the root of a fork network is deleted.
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Remove Koding integration and documentation
Closes #39697
See merge request gitlab-org/gitlab-ce!22334
|
| | |/
| |
| |
| |
| |
| | |
This integration no longer works and does not appear to be supported.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/39697
|
| |/
|
|
|
| |
As we now support getting the merge base for multiple revisions in
gitaly, we can provide this functionality in our API
|
| |
|
|
|
|
|
| |
Was introduced in the time that GitLab still used NFS, which is not
required anymore in most cases. By removing this, the API it calls will
return empty responses. This interface has to be removed in the next
major release, expected to be 12.0.
|
| |\ |
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
'master'
[master] Confidential issue/private snippet titles can be read by unauthenticated user through GFM markdown API
Closes #2706
See merge request gitlab/gitlabhq!2507
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Add a new project-specific templates API endpoint
See merge request gitlab-org/gitlab-ce!22118
|
| | |/ / |
|
| |\ \ \ |
|
| | |/ / |
|
| | |\ \
| | | |
| | | |
| | | |
| | | | |
List public ssh keys by id or username without authentication
See merge request gitlab-org/gitlab-ce!20118
|
| | | | | |
|
| |\ \ \ \
| |/ / / |
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Fix todo cops
See merge request gitlab-org/gitlab-ce!21850
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| |/ / / / |
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Adds Web IDE commits to usage ping
Closes #45016
See merge request gitlab-org/gitlab-ce!22007
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This makes a temporary implementation of the
Web IDE commits counter using Redis while
https://gitlab.com/gitlab-org/gitlab-ce/issues/52096
is being discussed further for a more generic
approach to counters
|
