summaryrefslogtreecommitdiff
path: root/features
Commit message (Collapse)AuthorAgeFilesLines
* Changes after reviewFilipa Lacerda2016-12-212-11/+0
| | | | | | Fix broken test Remove spinach tests for the builds tab
* Merge branch 'move-admin-projects-spinach-tests-to-rspec' into 'master' Rémy Coutable2016-12-202-151/+0
|\ | | | | | | | | | | | | Move admin projects spinach tests to RSpec Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/23036 See merge request !8174
| * Move admin projects spinach tests to rspecSemyon Pupkov2016-12-192-151/+0
| | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | Merge branch 'zj-kamil-slack-slash-commands' into 'master' Grzegorz Bizon2016-12-202-8/+8
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Slack slash commands ## What does this MR do? Implement Slack Slash Commands by utilizing generalized Mattermost presenter to fulfill Slack requirements. ## Why was this MR needed? We want to expose Slack Slash Commands as a first-class service. ## What are the relevant issue numbers? Supersedes !8007 Closes #22182 See merge request !8126
| * | Fix specszj-kamil-slack-slash-commandsKamil Trzcinski2016-12-192-6/+6
| | |
| * | Improve after feedbackKamil Trzcinski2016-12-192-7/+7
| | |
* | | Merge branch 'move-admin-appearance-feature-to-rspec' into 'master' Rémy Coutable2016-12-193-113/+0
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Move Admin Appearance spinach feature to RSpec Part of #23036 See merge request !8063
| * | | Move Admin Appearance spinach feature to rspecjurre2016-12-193-113/+0
| | | |
* | | | Move admin broadcast messages spinach feature to rspecjurre2016-12-192-99/+0
|/ / /
* | | Merge branch 'move-admin-label-spinach-test-to-rspec' into 'master' Rémy Coutable2016-12-192-155/+0
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Move admin labels spinach test to RSpec Part of #23036 See merge request !8166
| * | Move admin labels spinach test to rspecSemyon Pupkov2016-12-192-155/+0
| |/ | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | Merge branch 'move-admin-application-spinach-test-to-rspec' into 'master' Rémy Coutable2016-12-193-77/+0
|\ \ | | | | | | | | | | | | | | | | | | Move admin application spinach test to RSpec Part of #23036 See merge request !8140
| * | Move admin application spinach test to rspecSemyon Pupkov2016-12-173-77/+0
| |/ | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | Move admin deploy keys spinach test to rspecSemyon Pupkov2016-12-172-62/+0
|/ | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* Merge branch 'move-admin-active-tab-spinach-tests-to-rspec' into 'master' Rémy Coutable2016-12-152-95/+0
|\ | | | | | | | | Move admin active tab spinach tests to RSpec See merge request !8037
| * Move admin active tab spinach tests to rspecSemyon Pupkov2016-12-122-95/+0
| | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | Merge branch 'jej-24637-move-issue-visible_to_user-to-finder' into 'security' Sean McGivern2016-12-152-1/+3
| | | | | | | | | | | | | | Issue#visible_to_user moved to IssuesFinder Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24637. See merge request !2039
* | Merge branch 'dz-fix-admin-routes' into 'master' Sean McGivern2016-12-141-1/+1
|\ \ | | | | | | | | | | | | Add support for nested groups to admin routing See merge request !8008
| * | Add support for nested groups to admin routingdz-fix-admin-routesDmitriy Zaporozhets2016-12-111-1/+1
| |/ | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | Merge branch 'move-admin-settings-feature-to-rspec' into 'master' Rémy Coutable2016-12-133-85/+0
|\ \ | | | | | | | | | | | | | | | | | | Replace the Spinach specs for admin settings with RSpec feature specs as per #23036 Part of #23036 See merge request !8058
| * | Move admin settings spinach feature to rspecjurre2016-12-133-85/+0
| |/
* | fix failing testsMike Greiling2016-12-101-1/+1
|/
* Group links spec updatePhil Hughes2016-12-091-1/+1
|
* Updated members dropdownsPhil Hughes2016-12-072-2/+11
| | | | This ports some code over from EE to reduce conflicts
* Merge branch 'move-admin-hooks-spinach-test-to-rspec' into 'master' Rémy Coutable2016-12-072-24/+0
|\ | | | | | | | | | | | | Move admin hooks spinach to RSpec https://gitlab.com/gitlab-org/gitlab-ce/issues/23036 See merge request !7942
| * Move admin hooks spinach to rspecSemyon Pupkov2016-12-062-24/+0
| | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | Merge branch 'move-admin-logs-spinach-test-to-rspec' into 'master' Rémy Coutable2016-12-072-19/+0
|\ \ | | | | | | | | | | | | | | | | | | Move admin logs spinach test to RSpec https://gitlab.com/gitlab-org/gitlab-ce/issues/23036 See merge request !7945
| * | Move admin logs spinach test to rspecSemyon Pupkov2016-12-062-19/+0
| |/ | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | Update effected testszj-guest-reads-public-buildsZ.J. van de Weg2016-12-041-1/+1
|/
* Merge branch '22781-user-generated-permalinks' into 'master' Fatih Acet2016-12-011-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "User-generated permalink IDs collide with GitLab interface" ## What does this MR do? Prevents ID values automatically generated by headers in [GitLab Flavored Markdown](https://github.com/gitlabhq/gitlabhq/blob/master/doc/user/markdown.md#header-ids-and-links) from colliding with IDs used elsewhere in the GitLab interface. This can cause confusion when, for instance, a selector looks for a merge request tab with `id="pipelines"` and there is a header with the same ID earlier in the DOM. How this works: * All header IDs generated with GitLab Flavored Markdown are namespaced with `id="user-content_foo"` * All anchor links which point to these IDs continue to use the non-namespaced hash `<a href="#foo">...</a>` * When a page is loaded or when the `hashchange` event is triggered, javascript will automatically search for `#user-content_foo` if `#foo` cannot be found, and scroll to that position instead. ## Before ![2016-11-21-13.00.28](/uploads/e3be2cd6a9142dfd6e64db5462a6aa76/2016-11-21-13.00.28.gif) ## After: ![2016-11-21-13.12.45](/uploads/f7ae3f3a30c91325eaa3665591b6a850/2016-11-21-13.12.45.gif) ![2016-11-21-13.03.00](/uploads/3a6a782c081ecaa05b8781548d794909/2016-11-21-13.03.00.gif) ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - Tests - [x] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #22781 See also prior attempts to address this issue: #3908, !2023, !2024 See merge request !7631
| * remove underscore from user-content id namespace22781-user-generated-permalinksMike Greiling2016-11-301-1/+1
| |
| * update gitlab flavored markdown tests to reflect namespaced idsMike Greiling2016-11-301-1/+1
| |
* | fix tests broken by new wiki page designMike Greiling2016-11-303-18/+9
|/
* Homogenize dropdowns on Issue pageDavid Wagner2016-11-281-3/+3
| | | | | | | Make sort and filter dropdowns look the same and tweak their icon and colors according to #24150. Signed-off-by: David Wagner <david@marvid.fr>
* Pass `--load-images=no` to PhantomJS via Capybara/Poltergeistrs-phantomjs-disable-imagesRobert Speicher2016-11-281-1/+9
| | | | | | We were unintentionally hitting `gravatar.com` whenever a test that used Poltergeist was run. This was certainly wasting their resources and slowing down our tests even further, for no reason.
* Merge branch 'rephrase-system-notes' into 'master' Robert Speicher2016-11-252-2/+2
|\ | | | | | | | | Rephrase some system notes to be compatible with new system note style See merge request !7692
| * Rephrase some system notes to be compatible with new system note stylerephrase-system-notesDouwe Maan2016-11-242-2/+2
| |
* | Merge branch 'move-admin-spam-spinach-test-to-rspec' into 'master' Rémy Coutable2016-11-242-36/+0
|\ \ | | | | | | | | | | | | Move admin spam spinach test to RSpec See merge request !7708
| * | Move admin spam spinach test to RspecSemyon Pupkov2016-11-232-36/+0
| |/ | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | Merge branch 'dz-allow-nested-group-routing' into 'master' Douwe Maan2016-11-243-2/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add nested groups support to the routing ## What does this MR do? It allows routing with `/` in namespace name ## Why was this MR needed? For nested groups feature(https://gitlab.com/gitlab-org/gitlab-ce/issues/2772). We need URI like `/group/subgroup/project` be routed correctly ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - ~~API support added~~ - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/2772 See merge request !7459
| * | Add nested groups support to the routingdz-allow-nested-group-routingDmitriy Zaporozhets2016-11-233-2/+9
| |/ | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | Merge branch 'move-admin-abuse-report-spinach-test-to-rspec' into 'master' Rémy Coutable2016-11-242-23/+0
|\ \ | | | | | | | | | | | | | | | | | | Move admin abuse report spinach test to RSpec https://gitlab.com/gitlab-org/gitlab-ce/issues/23036 See merge request !7691
| * | Move admin abuse report spinach test to rspecSemyon Pupkov2016-11-232-23/+0
| |/ | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | Move abuse report spinach test to rspecSemyon Pupkov2016-11-232-49/+0
|/ | | | part of https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* Merge branch '20840-getting-started-better-empty-state-for-issues-view' into ↵Jacob Schatz2016-11-221-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Issues empty state ## What does this MR do? Adds the empty state for the project, dashboard and group issues. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? ## Screenshots (if relevant) ### Filtered to show no issues (on group issues page in this case but also dashboard and projects) ![Screen_Shot_2016-11-08_at_20.55.56](/uploads/b598af4a8a5e2c9fbb859abf36e70e4b/Screen_Shot_2016-11-08_at_20.55.56.png) ### Project with no issues ![Screen_Shot_2016-11-08_at_20.57.08](/uploads/8f54fdf1b3101c46299249fa2944207d/Screen_Shot_2016-11-08_at_20.57.08.png) ![Screen_Shot_2016-11-08_at_20.57.17](/uploads/1d2d162e1d845dd05e945d8ebb1d2101/Screen_Shot_2016-11-08_at_20.57.17.png) ### Group with no projects with any issues ![Screen_Shot_2016-11-08_at_20.54.55](/uploads/f28dc2038839d5bda0eb37f37927d5db/Screen_Shot_2016-11-08_at_20.54.55.png) ## Does this MR meet the acceptance criteria? - [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #20840 Closes #20850 See merge request !7309
| * Added empty state svg and set up blank conditional20840-getting-started-better-empty-state-for-issues-viewLuke "Jared" Bennett2016-11-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added new spec step Added empty state to dashboard Split empty and filtered empty states Moved empty_state icons into their own folder and DRY up empty state html Fixed failing spec Added to groups page Review changes
* | Merge branch '24010-Add-named-anchors-for-diffs-in-the-commit-page' into ↵Sean McGivern2016-11-171-9/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Adds hash anchors to diff_files to make possible linking exact file in commit Closes #24010 See merge request !7298
| * | Unify anchor link format for MR diff files !7298Yar2016-11-151-9/+9
| |/ | | | | | | | | | | | | | | Right now, the following naming scheme for diff files is used: diff-1, diff-2, ... and also we have "internal" format which is file-path-HASH, where HASH is sha1 of file path. Besides, we have HASH_lineA_lineB format to link exact line number in MR diff. It makes sence to unify the way we link diff from outside, while leave "file-path-HASH" format for internal (js) usage. Changes in this commit allow to link diff just by HASH, if we don't want specify exact lines, also it changes "file-path-HASH" and "diff-NUMBER" links in code to this unified format. Inspired by #24010 and !7298
* | Merge branch 'move-snippet-discover-spinach-test-to-rspec' into 'master' Dmitriy Zaporozhets2016-11-162-34/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move 'Explore Snippets' Spinach feature to Rspec ## What does this MR do? It moves the `features/snippets/discover.feature` Spinach test to a Rspec feature. ## Are there points in the code the reviewer needs to double check? The original feature was called 'Discover Snippets', but the UI no longer reflects this wording. The new Rspec feature is called 'Explore Snippets' to reflect UI/Controller/View naming in use. ## Why was this MR needed? As part of deprecating the Spinach test suite. ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [-] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [-] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [-] API support added - Tests - [x] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? #23036 See merge request !7349
| * | Move 'Explore Snippets' Spinach feature to Rspecthe-undefined2016-11-082-34/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit moves the `snippets/discover.feature` Spinach test to a Rspec feature, as part of deprecating the Spinach test suite. The original feature was called 'Discover Snippets', but the UI no longer reflects this wording. The new Rspec feature is called 'Explore Snippets' to reflect UI/Controller/View naming in use. - Remove Spinach discover snippets feature and steps - Add Rspec feature test
View Lorry Controller Status