summaryrefslogtreecommitdiff
path: root/features/steps/shared
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | | | | more spinach fixesPhil Hughes2017-08-301-1/+1
| | | | | | |
| | * | | | | spinach test updatesPhil Hughes2017-08-301-1/+1
| | | | | | |
| | * | | | | layout-nav test check fixPhil Hughes2017-08-291-4/+4
| | | |_|_|/ | | |/| | |
| * | | | | Merge branch '36743-existing-repo-master' into 'master'Douwe Maan2017-08-311-3/+1
| |\ \ \ \ \ | | |/ / / / | |/| | | | | | | | | | | | | | | | [master] Prevent project creation (blank, import or fork) when repository already exists on disk See merge request gitlab/gitlabhq!2169
| | * | | | Prevent new / renamed project from using a repository path that already ↵Gabriel Mazetto2017-08-251-3/+1
| | | |_|/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | exists on disk There are some redundancies in the validation steps, and that is to preserve current error messages behavior Also few specs have to be changed in order to fix madness in validation logic.
* | | | | Merge branch 'master' into sh-headless-chrome-supportStan Hu2017-08-311-4/+0
|\ \ \ \ \ | |/ / / /
| * | | | Replace 'source/search_code.feature' spinach test with an rspec analogblackst0ne2017-08-251-4/+0
| |/ / /
* | | | Merge branch 'master' into sh-headless-chrome-supportStan Hu2017-08-161-5/+2
|\ \ \ \ | |/ / /
| * | | Merge branch ↵Clement Ho2017-08-141-5/+2
| |\ \ \ | | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | '34527-make-edit-comment-button-always-available-outside-of-dropdown' into 'master' Resolve "Make edit comment button always available outside of dropdown" Closes #34527 See merge request !12931
| | * | take edit note button out of dropdown34527-make-edit-comment-button-always-available-outside-of-dropdownSimon Knox2017-08-101-5/+2
| | |/
* | | Accept the confirm modal to make comment on commit spec to passStan Hu2017-08-131-1/+1
| | |
* | | Merge branch 'master' into sh-headless-chrome-supportStan Hu2017-08-111-22/+8
|\ \ \ | |/ /
| * | Migrate events into a new formatYorick Peterse2017-08-101-22/+8
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
* | Expand Spinach window size and remove unsupported trigger callsStan Hu2017-08-111-2/+0
| |
* | Merge branch 'master' into sh-headless-chrome-supportStan Hu2017-08-091-3/+3
|\ \ | |/
| * Merge branch '34060-simplified-general-project-settings' into 'master'Mike Greiling2017-08-041-1/+1
| |\ | | | | | | | | | | | | | | | | | | 34060 Simply general project settings to use expanded panels Closes #34060 See merge request !12620
| | * fixed up specsPhil Hughes2017-07-281-1/+1
| | |
| * | Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-021-3/+3
| | |
| * | Use `:empty_project` where possible in features/stepsRobert Speicher2017-08-021-1/+1
| |/
* | Merge branch 'master' into sh-headless-chrome-supportStan Hu2017-08-027-139/+67
|\ \ | |/
| * Replaces dashboard/dashboard.feature spinach with rspecAlexander Randa2017-07-171-5/+0
| |
| * Resolve "Inconsistent location of members page between groups and projects"Tim Zallmann2017-07-071-0/+4
| |
| * Create and use project path helpers that only need a project, no namespaceDouwe Maan2017-07-054-62/+62
| |
| * Merge branch '23036-replace-snippets-spinach' into 'master'Rémy Coutable2017-07-052-67/+0
| |\ | | | | | | | | | | | | Replace 'snippets/snippets.feature' spinach with rspec See merge request !12385
| | * Replace 'snippets/snippets.feature' spinach with rspecAlexander Randa2017-07-052-67/+0
| | |
| * | Render add-diff-note button with server.Bryce Johnson2017-06-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit moves the rendering of the button back to the server, and shows/hides it using opacity rather than display. It also removes the transform applied to the button on hover (scale). Previously, both of these factors automatically triggered a reflow, which creates a performance bottleneck on pages with larger DOM size. MR: !12103
| * | Replaces 'dashboard/todos' spinach with rspecAlexander Randa2017-06-261-4/+0
| |/
* | Convert variants of trigger('click') -> clickStan Hu2017-06-161-3/+3
|/
* Added more actions and report as abuse to all notesLuke "Jared" Bennett2017-06-071-3/+13
|
* Merge branch 'rename-builds-controller' into 'master'Kamil Trzciński2017-05-311-3/+3
|\ | | | | | | | | | | | | Rename BuildsController to JobsController Closes #30699 See merge request !11407
| * Merge remote-tracking branch 'upstream/master' into rename-builds-controllerLin Jen-Shin2017-05-264-15/+15
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream/master: (307 commits) Address feedback Add small update for the i18n guide. update webpack to v2.6.1 patch release to fix "Can't find variable: Promise" error update webpack-bundle-analyzer past v2.4.1 to support NamedChunksPlugin name all webpack chunks to improve long term cacheability add NameAllModulesPlugin to cover shortcomings of NamedModulesPlugin upgrade to latest webpack version Only use DROP INDEX CONCURRENTLY on postgreql 9.2+ Provide default for calculating label text color (!11681) Add failing test for #32728 Bugfix: Always use the default language when generating emails. Remove unecessary commit pattern check Add regexp_for_value helper method Remove shared example and improve sub_group_issuables_spec.rb Remove 'should' from scenario in has_subgroup_title_spec.rb Cartfile git and binary methods cannot take a GitHub repo Fix terminals support for Kubernetes service Add review comments to compare_spec.rb Fix transient error clicking dropdown items in compare_spec.rb Use non-global jQuery reference within raven bundle ...
| * \ Merge remote-tracking branch 'upstream/master' into rename-builds-controllerLin Jen-Shin2017-05-181-2/+2
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream/master: (31 commits) Remove 'no changes' entries from changelog Check if OLD is set when migrating issue assignees Fix data migration from trigger schedules Replace EFS section in AWS guide Add warning about AWS EFS and performance Consolidate opening text from about.gitlab.com and add active/passive note Fix invalid object reference in ee_compat_check script Fix Ordered Task List Items Add auxiliary viewer for README Update fe_guide testing.md Add auxiliary blob viewer for CHANGELOG Add spec for last commit info when browsing repository files Show last commit for current tree on tree page Use same last commit widget on project homepage and tree view Fix unassigned checkmark Add missing changelog for iPython notebook rendering feature Convert fa-history to svg; tweak alignment Get rid of pluck in app/services/members/authorized_destroy_service.rb Removes duplicate environment variable in documentation Fixed spacing issues in issue sidebar ...
| * | | Rename BuildsController to JobsControllerLin Jen-Shin2017-05-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename other URL generators admin_builds_path -> admin_jobs_path Fix tests and more renaming Fix more tests Also change build_id to job_id in the controller
* | | | Merge branch 'master' into issue-edit-inlinePhil Hughes2017-05-255-18/+18
|\ \ \ \ | | |_|/ | |/| |
| * | | Use wait_for_requests to wait all JS requestwait-for-ajax-handling-all-js-requestsOswaldo Ferreira2017-05-224-15/+15
| | |/ | |/|
| * | Use same last commit widget on project homepage and tree viewdm-consistent-commit-widgetDouwe Maan2017-05-171-2/+2
| |/
| * Rename Personal Audit LogTim Zallmann2017-05-161-1/+1
| |
* | fixed spinach testsPhil Hughes2017-05-251-3/+3
|/
* Merge request widget redesignFatih Acet2017-05-091-0/+6
|
* Add instant comments supportKushal Pandya2017-05-051-0/+4
|
* Fix feature specsDouwe Maan2017-04-271-1/+1
|
* Wait for AJAX after steps defined in SharedActiveTab31439-fix-transient-spinach-failuresRémy Coutable2017-04-261-0/+5
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Except where necessary, use `sign_in` over `login_as` in featuresRobert Speicher2017-04-191-7/+44
|
* Put back usernames in activity and profile feedAnnabel Dunstone Gray2017-04-071-1/+1
|
* Update project build status cache when transitioningBob Van Landuyt2017-04-071-1/+2
|
* Fixed button capitalisation for Projects in viewsJose Ivan Vargas Lopez2017-04-061-1/+1
|
* Merge branch '29128-profile-page-icons' into 'master' Filipa Lacerda2017-04-061-1/+1
|\ | | | | | | | | | | | | Resolve "Add system note icons to profile page" Closes #29128 See merge request !10387
| * Update commit icon; fix specs29128-profile-page-iconsAnnabel Dunstone Gray2017-04-031-1/+1
| |
* | Optimise trace handling code to use streaming instead of full readKamil Trzciński2017-04-061-1/+1
| |
* | MR empty stateLuke "Jared" Bennett2017-04-051-0/+4
|/