summaryrefslogtreecommitdiff
path: root/doc/development
Commit message (Collapse)AuthorAgeFilesLines
* Re-organize queues to use for Sidekiqseparate-sidekiq-queuesYorick Peterse2016-10-212-1/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Dumping too many jobs in the same queue (e.g. the "default" queue) is a dangerous setup. Jobs that take a long time to process can effectively block any other work from being performed given there are enough of these jobs. Furthermore it becomes harder to monitor the jobs as a single queue could contain jobs for different workers. In such a setup the only reliable way of getting counts per job is to iterate over all jobs in a queue, which is a rather time consuming process. By using separate queues for various workers we have better control over throughput, we can add weight to queues, and we can monitor queues better. Some workers still use the same queue whenever their work is related. For example, the various CI pipeline workers use the same "pipeline" queue. This commit includes a Rails migration that moves Sidekiq jobs from the old queues to the new ones. This migration also takes care of doing the inverse if ever needed. This does require downtime as otherwise new jobs could be scheduled in the old queues after this migration completes. This commit also includes an RSpec test that blacklists the use of the "default" queue and ensures cron workers use the "cronjob" queue. Fixes gitlab-org/gitlab-ce#23370
* Merge branch 'dz-rename-user-routes' into 'master'Robert Speicher2016-10-171-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | Rename users routing from /u/:username to /users/:username for consistency with other routes Renames /u/:username to /users/:username To follow consistency with other routes (like groups) and UsersController name. Now when you can use `/:username` for accessing user page there is no need in shortcut like `/u/` See merge request !6851
| * Remove /u/ prefix from user pages in documentationDmitriy Zaporozhets2016-10-131-1/+1
| | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | Merge branch 'master' into 'docs/change-docs-reviewers'Achilleas Pipinellis2016-10-162-2/+3
|\ \ | | | | | | | | | # Conflicts: # doc/development/doc_styleguide.md
| * | remove ashley since she no longer works hereDe Wet Blomerus2016-10-151-1/+1
| | |
| * | Add docs for request profilingfix/request-profiler-docsAhmad Sherif2016-10-141-1/+2
| | | | | | | | | | | | Closes #23239
* | | Add the tech writers usernames in the doc_sytleguide docdocs/change-docs-reviewersAchilleas Pipinellis2016-10-161-4/+4
|/ / | | | | | | [ci skip]
* | Document Capybara errors from es6 in es5 file.es6-es5-poltergeistBryce Johnson2016-10-121-0/+11
|/
* Add examples of fake tokens to be used in docsAchilleas Pipinellis2016-10-111-0/+23
| | | | [ci skip]
* Fix typo and add he MWBS accronym for "Merge When Build Succeeds"improve-contributingRémy Coutable2016-10-071-4/+4
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Improve the contribution and MR review guideRémy Coutable2016-10-071-0/+7
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch 'creative-commons-zero' into 'master' Rémy Coutable2016-10-061-0/+2
|\ | | | | | | | | | | | | | | | | Added CC0 license to list of licenses Adds a "license" (actually a deed, because its a dedication to the public domain) to the appropriate place in the documentation. It adds another relevant license to our documentation. See merge request !6622
| * Added CC0 license to list of licensesMatt Lee2016-09-291-0/+2
| |
* | Link to the "What requires downtime?" page from the Migration Style GuideNick Thomas2016-10-021-4/+4
| | | | | | | | [ci skip]
* | Update Frontend Docs based on feedback.cs-frontend-guidelinesConnor Shea2016-09-211-18/+18
| |
* | Add a section on vue and one on supported browsers.Connor Shea2016-09-211-0/+14
| |
* | Add Overview section detailing our frontend stack. [ci skip]Connor Shea2016-09-211-5/+44
| |
* | Add short Testing section, minor fixes.Connor Shea2016-09-211-1/+7
| |
* | Add CSP and SRI information [ci skip]Connor Shea2016-09-211-3/+71
| |
* | Further revisions/additions [ci skip]Connor Shea2016-09-211-6/+17
| |
* | Add more information on page-specific JS.Connor Shea2016-09-211-19/+45
| | | | | | | | [ci skip]
* | Initial incomplete draft of the Frontend Development Guidelines.Connor Shea2016-09-212-0/+62
|/ | | | [ci skip]
* Add support for column limits in add_column_with_defaultDrew Blessing2016-09-151-0/+22
|
* Document how to track custom eventsYorick Peterse2016-09-121-0/+15
| | | | | | Fixes gitlab-org/gitlab-ce#22070 [ci skip]
* Change the inline code to codeblocks for the new features doc guidelineAchilleas Pipinellis2016-09-021-7/+22
| | | | [ci skip]
* Merge branch 'mr-performance-guides' into 'master' Achilleas Pipinellis2016-08-312-0/+173
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added performance guidelines for new MRs ## What does this MR do? This MR adds a set of guides that should be followed by merge request authors. ## Are there points in the code the reviewer needs to double check? Spelling, grammar, etc ## Why was this MR needed? There is no set of guidelines one should follow when submitting merge requests. This leads to developers at times disregarding performance. This in turn results in performance specialists having to clean up the mess, or production engineers being woken up in the middle of the night because the database is on fire. ## Does this MR meet the acceptance criteria? - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - Tests - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) cc @DouweM @rspeicher @pcarranza @dzaporozhets See merge request !5905
| * Added performance guidelines for new MRsmr-performance-guidesYorick Peterse2016-08-222-0/+173
| | | | | | | | | | | | | | These guidelines cover the performance requirement for newly submitted merge requests. These guidelines are put in to place to prevent merge requests from negatively impacting GitLab performance as much as possible.
* | Merge branch 'patch-1' into 'master' Douwe Maan2016-08-301-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clarify blank line rule in newlines_styleguide.md ## What does this MR do? * Corrects a typo in the GitLab Ruby newlines style guide * Makes some vague language in the original guideline more precise ## Are there points in the code the reviewer needs to double check? n/a ## Why was this MR needed? * There was a typo in the original text. * The original text was vague. ## What are the relevant issue numbers? n/a ## Screenshots (if relevant) n/a ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added (Is this recommended for this kind of patch?) - ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - ~~API support added~~ - Tests - ~~Added for this feature/bug~~ - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !6048
| * | Clarify blank line rule in newlines_styleguide.md Jake Romer2016-08-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To clarify what's meant by "from a logical perspective" here, I consulted Python's PEP8 style guide, which provides some helpfully precise language: > Extra blank lines may be used (sparingly) to separate groups of > related functions. Blank lines may be omitted between a bunch of > related one-liners (e.g. a set of dummy implementations). https://www.python.org/dev/peps/pep-0008/#blank-lines I adapted this passage to the existing language for the newline rule.
* | | Merge branch 'doc/styleguide-fix-grep' into 'master' Achilleas Pipinellis2016-08-291-8/+16
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clarify steps when changing a document's location Clarify the steps needed to change a document's location so issues like https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6024 don't occur. See merge request !6070
| * | | Use `git grep` instead of `grep`Achilleas Pipinellis2016-08-291-7/+7
| | | | | | | | | | | | | | | | [ci skip]
| * | | Clarify steps when changing a document's locationdoc/styleguide-fix-grepAchilleas Pipinellis2016-08-271-8/+16
| |/ / | | | | | | | | | [ci skip]
* | | Fix markdown help referencesClement Ho2016-08-261-1/+1
|/ /
* | Fix markdown link in doc_styleguide.mdAchilleas Pipinellis2016-08-251-1/+1
|/ | | | [ci skip]
* Merge branch 'document-when-to-add-indexes' into 'master' Achilleas Pipinellis2016-08-162-0/+127
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added documentation on adding database indexes ## What does this MR do? This MR adds a guide on when to add database indexes, how to approach this problem, etc ## Are there points in the code the reviewer needs to double check? Spelling, grammar, etc ## Why was this MR needed? Blindly adding indexes can be harmful to the database, and I recently had to remove 48-something unused indexes. ## What are the relevant issue numbers? #20767 ## Does this MR meet the acceptance criteria? - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - Tests - [x] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5771
| * Added documentation on adding database indexesdocument-when-to-add-indexesYorick Peterse2016-08-112-0/+127
| |
* | Merge branch '19350-product-map' into 'master' Jacob Schatz2016-08-161-5/+11
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add reference to product map. ## What does this MR do? Mention the product map in the UI Guide and remove a line that says that the GitLab logo and user picture and in the sidebar. ## What are the relevant issue numbers? 19350 - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) Closes #19350 See merge request !5769
| * | Add reference to product map. 19350-product-mapChris Peressini2016-08-111-5/+11
| |/ | | | | | | Remove line that says the GitLab logo and user picture are in the sidebar.
* | Corrected links/usernames in performance guideupdate-performance-guideYorick Peterse2016-08-111-5/+4
|/ | | | | | | This fixes two broken links in the performance guide and removes the mention of Josh as he no longer works for GitLab. [ci skip]
* Merge branch 'add-column-with-default-to-downtime-guide' into 'master' Achilleas Pipinellis2016-08-101-0/+8
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mention add_column_with_default in downtime guide ## What does this MR do? This extends the "What causes downtime" guide with a mention of the `add_column_with_default` migration helper. ## Are there points in the code the reviewer needs to double check? Spelling, grammar, etc. ## Why was this MR needed? Currently the guide may lead one to believe it's not possible at all to add a column with a default value. ## Does this MR meet the acceptance criteria? - [x] ~~[CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added~~ - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - Tests - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5719
| * Mention add_column_with_default in downtime guideadd-column-with-default-to-downtime-guideYorick Peterse2016-08-101-0/+8
| | | | | | | | [ci skip]
* | Merge branch 'update-ui-guide--svgs' into 'master' Dmitriy Zaporozhets2016-08-101-0/+36
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update UI Guide with SVG guidelines This addition to the guide is to provide some guidelines to UX designers when exporting SVGs. Please let me know if anything is unclear or if you any improvements so we can document it clearly for everyone. cc / @hazelyang @cperessini @dimitrieh @connorshea @annabeldunstone @dzaporozhets ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ee/issues/872 See merge request !5748
| * | spellcheckupdate-ui-guide--svgsTaurie Davis2016-08-091-2/+2
| | |
| * | Add svg guidelines to ui guideTaurie Davis2016-08-091-0/+36
| | |
* | | Small refactor of doc/development/README.mdAchilleas Pipinellis2016-08-101-4/+3
| | | | | | | | | | | | | | | | | | - Fix wrong doc_styleguide URL - Clarify migrations refer to SQL - Capitalize CSS
* | | Merge branch 'link-to-gdk-howtos' into 'master' Achilleas Pipinellis2016-08-101-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Link to doc root, not readme of GDK I hope this makes navigation between gitlab-ce developer docs and GDK docs more smooth. See merge request !5716
| * | | Link to doc root, not readme of GDKJacob Vosmaer2016-08-081-1/+1
| | |/ | |/|
* | | Merge branch 'api-examples-curl-long-options' into 'master' Achilleas Pipinellis2016-08-101-7/+7
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use long options for curl examples in documentation ## What does this MR do? Use long options (e.g. `--header` instead of `-H`) for curl examples in documentation. ## Why was this MR needed? Short options are less readable. ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5465#note_13603730 See merge request !5703
| * | use long options for curl examples in API documentation (!5703)winniehell2016-08-091-7/+7
| |/
* | Merge branch 'dz-newlines-styleguide' into 'master' Robert Speicher2016-08-081-0/+102
|\ \ | |/ |/| | | | | Add newlines styleguide for Ruby code See merge request !5636
View Lorry Controller Status