| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Added basic docs for the Emoji Rake tasks
## What does this MR do?
This MR adds basic documentation for the two Emoji Rake tasks.
## Are there points in the code the reviewer needs to double check?
Spelling, that sort of thing.
## Why was this MR needed?
These Rake tasks only had some small amount of source level documentation.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/14794
## Does this MR meet the acceptance criteria?
- [x] ~~[CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added~~
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !4877
|
| | |/ /
| | |
| | |
| | |
| | |
| | | |
Fixes gitlab-org/gitlab-ce#14794 gitlab-com/performance#13
[ci skip]
|
| |/ / |
|
| | |
| |
| |
| | |
[ci skip]
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously we'd create a separate Metric instance for every method call
that would exceed the method call threshold. This is problematic because
it doesn't provide us with information to accurately get the _total_
execution time of a particular method. For example, if the method
"Foo#bar" was called 4 times with a runtime of ~10 milliseconds we'd end
up with 4 different Metric instances. If we were to then get the
average/95th percentile/etc of the timings this would be roughly 10
milliseconds. However, the _actual_ total time spent in this method
would be around 40 milliseconds.
To solve this problem we now create a single Metric instance per method.
This Metric instance contains the _total_ real/CPU time and the call
count for every instrumented method.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
By default instrumentation will instrument public,
protected and private methods, because usually
heavy work is done on private method or at least
that’s what facts is showing
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add guide on changing a document's location
## What does this MR do?
Add a documentation styleguide when changing a document's location.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/3349
See merge request !4624
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| |/ /
| |
| |
| | |
[ci skip]
|
| | |
| |
| |
| | |
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
| | | |
|
| | |
| |
| |
| | |
the GPL so no one tries to disagree with that decision.
|
| | | |
|
| | |
| |
| |
| | |
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
| | |
| |
| |
| | |
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Write some thoughts to the UI guide
cc @skyruler
See merge request !4290
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
| |/ /
| |
| |
| | |
Also removes the note from the development/testing.md guide
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Added helper methods for database migrations
These helpers can ultimately be used to write migrations that don't
require downtime.
See #15464 for more information.
See merge request !3860
|
| | | | |
|
| |/ /
| |
| |
| | |
[ci skip]
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Added documentation on how to instrument methods
This will hopefully remove me as a single point of failure when it comes to adding instrumentation.
cc @axil @rspeicher
See merge request !4035
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| | |
These would end up being rendered as:
<a href="...">@yorickpeterse</a>
<a href="...">@yorickpeterse</a>
[ci skip]
|
| | |
| |
| |
| | |
[ci skip]
|
| | |
| |
| |
| |
| |
| | |
Fixes gitlab-org/gitlab-ce#15254 gitlab-org/gitlab-ce#14277
[ci skip]
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
Using db:reset ensures existing tables are first dropped. This in turn
ensures that we can drop tables regardless of any foreign key
constraints. While CE currently doesn't have any foreign keys EE defines
the following relation:
remote_mirrors.project_id -> projects.id
MySQL will complain whenever you try to drop the "projects" table first
even when using "DROP TABLE ... CASCADE".
|
| |\
| |
| |
| |
| | |
Store block timings as transaction values
See merge request !3649
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This makes it easier to query, simplifies the code, and makes it
possible to figure out what transaction the data belongs to (simply
because it's now stored _in_ the transaction).
This new setup keeps track of both the real/wall time _and_ CPU time
spent in a block, both measured using milliseconds (to keep all units
the same).
|
| | |
| |
| |
| | |
[ci skip]
|
| |/
|
|
|
|
|
| |
Largely borrowed from thoughtbot's code review guide, so attribution is
included.
[ci skip]
|
| |
|
|
| |
[ci skip]
|
| |\
| |
| |
| |
| |
| |
| | |
Remove TODO for not documented stuff
We should not put a `TODO` in a released product.
See merge request !3553
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
First pass at a Testing styleguide
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14121
[ci skip]
See merge request !3465
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| | |/
| |
| |
| | |
[ci skip]
|
| |/ |
|
| |
|
|
|
|
| |
Fix a typo and add a section on ignoring issues.
[ci skip]
|
| |
|
|
|
|
| |
documentation for SCSS Style Guide.
See !3069 for more information.
|
| |
|
|
|
|
|
|
|
| |
The rationale for this can be found in
https://gitlab.com/gitlab-org/gitlab-ce/issues/13718 but in short the
benchmark suite no longer serves a good purpose now that we have proper
production monitoring in place.
Fixes gitlab-org/gitlab-ce#13718
|
