| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
[ci skip]
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
Added CC0 license to list of licenses
Adds a "license" (actually a deed, because its a dedication to the public domain) to the appropriate place in the documentation.
It adds another relevant license to our documentation.
See merge request !6622
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
|/
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
|
| |
Fixes gitlab-org/gitlab-ce#22070
[ci skip]
|
|
|
|
| |
[ci skip]
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Added performance guidelines for new MRs
## What does this MR do?
This MR adds a set of guides that should be followed by merge request authors.
## Are there points in the code the reviewer needs to double check?
Spelling, grammar, etc
## Why was this MR needed?
There is no set of guidelines one should follow when submitting merge requests. This leads to developers at times disregarding performance. This in turn results in performance specialists having to clean up the mess, or production engineers being woken up in the middle of the night because the database is on fire.
## Does this MR meet the acceptance criteria?
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
cc @DouweM @rspeicher @pcarranza @dzaporozhets
See merge request !5905
|
| |
| |
| |
| |
| |
| |
| | |
These guidelines cover the performance requirement for newly submitted
merge requests. These guidelines are put in to place to prevent merge
requests from negatively impacting GitLab performance as much as
possible.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Clarify blank line rule in newlines_styleguide.md
## What does this MR do?
* Corrects a typo in the GitLab Ruby newlines style guide
* Makes some vague language in the original guideline more precise
## Are there points in the code the reviewer needs to double check?
n/a
## Why was this MR needed?
* There was a typo in the original text.
* The original text was vague.
## What are the relevant issue numbers?
n/a
## Screenshots (if relevant)
n/a
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added (Is this recommended for this kind of patch?)
- ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- ~~API support added~~
- Tests
- ~~Added for this feature/bug~~
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !6048
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
To clarify what's meant by "from a logical perspective" here, I
consulted Python's PEP8 style guide, which provides some helpfully
precise language:
> Extra blank lines may be used (sparingly) to separate groups of
> related functions. Blank lines may be omitted between a bunch of
> related one-liners (e.g. a set of dummy implementations).
https://www.python.org/dev/peps/pep-0008/#blank-lines
I adapted this passage to the existing language for the newline rule.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Clarify steps when changing a document's location
Clarify the steps needed to change a document's location so issues like
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6024
don't occur.
See merge request !6070
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| |/ /
| | |
| | |
| | | |
[ci skip]
|
|/ / |
|
|/
|
|
| |
[ci skip]
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Added documentation on adding database indexes
## What does this MR do?
This MR adds a guide on when to add database indexes, how to approach this problem, etc
## Are there points in the code the reviewer needs to double check?
Spelling, grammar, etc
## Why was this MR needed?
Blindly adding indexes can be harmful to the database, and I recently had to remove 48-something unused indexes.
## What are the relevant issue numbers?
#20767
## Does this MR meet the acceptance criteria?
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [x] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5771
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add reference to product map.
## What does this MR do?
Mention the product map in the UI Guide and remove a line that says that the GitLab logo and user picture and in the sidebar.
## What are the relevant issue numbers?
19350
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
Closes #19350
See merge request !5769
|
| |/
| |
| |
| | |
Remove line that says the GitLab logo and user picture are in the sidebar.
|
|/
|
|
|
|
|
| |
This fixes two broken links in the performance guide and removes the
mention of Josh as he no longer works for GitLab.
[ci skip]
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Mention add_column_with_default in downtime guide
## What does this MR do?
This extends the "What causes downtime" guide with a mention of the `add_column_with_default` migration helper.
## Are there points in the code the reviewer needs to double check?
Spelling, grammar, etc.
## Why was this MR needed?
Currently the guide may lead one to believe it's not possible at all to add a column with a default value.
## Does this MR meet the acceptance criteria?
- [x] ~~[CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added~~
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [ ] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5719
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Update UI Guide with SVG guidelines
This addition to the guide is to provide some guidelines to UX designers when exporting SVGs. Please let me know if anything is unclear or if you any improvements so we can document it clearly for everyone.
cc / @hazelyang @cperessini @dimitrieh @connorshea @annabeldunstone @dzaporozhets
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ee/issues/872
See merge request !5748
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
- Fix wrong doc_styleguide URL
- Clarify migrations refer to SQL
- Capitalize CSS
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Link to doc root, not readme of GDK
I hope this makes navigation between gitlab-ce developer docs and GDK docs more smooth.
See merge request !5716
|
| | |/
| |/| |
|
|\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use long options for curl examples in documentation
## What does this MR do?
Use long options (e.g. `--header` instead of `-H`) for curl examples in documentation.
## Why was this MR needed?
Short options are less readable.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5465#note_13603730
See merge request !5703
|
| |/ |
|
|\ \
| |/
|/|
| |
| | |
Add newlines styleguide for Ruby code
See merge request !5636
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add doc guidelines on documents naming and location
## What does this MR do?
Add guidelines on the structure of the documentation.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/3349
See merge request !5641
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
This guide describes various commonly used operations and the impact
they have on the availability of a GitLab instance.
|