summaryrefslogtreecommitdiff
path: root/doc/development/code_review.md
Commit message (Collapse)AuthorAgeFilesLines
* Rename builds to jobs in docsAchilleas Pipinellis2017-02-151-1/+1
| | | | [ci skip]
* Rename endboss -> maintainer, miniboss -> reviewerno-more-bossesSean McGivern2017-01-131-6/+6
| | | | | We want to describe these roles in a way that is more understandable to people not familiar with GitLab.
* Merge branch 'fix/rename-mwbs-to-merge-when-pipeline-succeeds' into 'master' Kamil Trzciński2016-12-051-2/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename MWBS service to Merge When Pipeline Succeeds ## What does this MR do? This MR renames Merge When Build Succeeds feature to Merge When Pipeline Succeeds, because we recently changed the behavior, see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6675. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] All builds are passing ## What are the relevant issue numbers? Closes #23354 See merge request !7135
| * Update some docs to reflect MWPS name changeGrzegorz Bizon2016-11-211-2/+2
| |
* | Remove change to MWBS in code review guidelineGrzegorz Bizon2016-12-021-1/+1
| | | | | | | | [ci skip]
* | Copy-edit text about right balance in code reviewsdoc/extend-code-review-guidelinesGrzegorz Bizon2016-12-011-10/+10
| | | | | | | | [ci skip]
* | Extend code review docs with chapter about the right balanceGrzegorz Bizon2016-11-301-1/+27
|/
* Fix typo and add he MWBS accronym for "Merge When Build Succeeds"improve-contributingRémy Coutable2016-10-071-4/+4
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Improve the contribution and MR review guideRémy Coutable2016-10-071-0/+7
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Re-add a note about sarcasm to the Code Review guiders-code-review-guideRobert Speicher2016-04-101-0/+3
| | | | [ci skip]
* First pass at a Code Review guideRobert Speicher2016-04-091-0/+75
Largely borrowed from thoughtbot's code review guide, so attribution is included. [ci skip]
View Lorry Controller Status