summaryrefslogtreecommitdiff
path: root/danger
Commit message (Collapse)AuthorAgeFilesLines
* Add a danger rule to suggest `docs-` prefixesleipert-danger-dogsLukas Eipert2019-06-271-0/+24
| | | | | | | | | | If an MR only changes files within `doc/` we can save valueable CI time by prepending a branch name with `docs-`. This danger rule helps educate people about that fact. On the other hand, if someone has a branch with a `docs` prefix or suffix, the branch shouldn't contain any changes outside of the `docs` directory
* When using suggestions, squash must be enabledAchilleas Pipinellis2019-06-191-1/+11
|
* Backport the EE schema and migrations to CEYorick Peterse2019-06-171-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This backports all EE schema changes to CE, including EE migrations, ensuring both use the same schema. == Updated tests A spec related to ghost and support bot users had to be modified to make it pass. The spec in question assumes that the "support_bot" column exists when defining the spec. In the single codebase setup this is not the case, as the column is backported in a later migration. Any attempt to use a different schema version or use of "around" blocks to conditionally disable specs won't help, as reverting the backport migration would also drop the "support_bot" column. Removing the "support_bot" tests entirely appears to be the only solution. We also need to update some foreign key tests now that we have backported the EE columns. Fortunately, these changes are very minor. == Backporting migrations This commit moves EE specific migrations (except those for the Geo tracking database) and related files to CE, and also removes any traces of the ee/db directory. Some migrations had to be modified or removed, as they no longer work with the schema being backported. These migrations were all quite old, so we opted for removing them where modifying them would take too much time and effort. Some old migrations were modified in EE, while also existing in CE. In these cases we took the EE code, and in one case removed them entirely. It's not worth spending time trying to merge these changes somehow as we plan to remove old migrations around the release of 12.0, see https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
* Excludes MR author from Review roulette61157-reviewer-roulette-shouldn-t-include-the-author-as-a-possibilityJacopo2019-06-123-22/+29
| | | | | Excludes MR author from gitlab_ui and single_codebase Review roulette results.
* Don't fail the pipeline when a colon-emoji is usedSean McGivern2019-06-061-2/+2
| | | | | | A colon-emoji like :100: can be valid in the case where we're talking about the GitLab feature that processes these into emojis. It's fine to warn about those, but failing the pipeline is too restrictive.
* Show Test Automation Engineer for spec/feature asLin Jen-Shin2019-06-061-3/+7
| | | | reviewers.
* Use roulette for single codebase rouletteextract-danger-rouletteLin Jen-Shin2019-05-301-11/+18
|
* Extract roulette to its own moduleLin Jen-Shin2019-05-303-42/+16
| | | | So it's more modular and extensible
* Run rubocop -a on CE filessh-upgrade-rubocop-0.68.0-ceStan Hu2019-05-051-1/+1
|
* Fix reviewer roulette when no-one is in a categorySean McGivern2019-04-301-1/+3
| | | | This would return `people.size` before, when it should return `nil`.
* Exclude reviewers with OOO in statusMichael Kozono2019-04-291-8/+34
|
* Add Danger rule for EE/CE templatesNathan Friend2019-04-241-0/+56
| | | | | | This commit adds a rule to Danger that warns the developer when their MR includes changes to a CE .vue file that has a counterpart in the EE repo or vice-versa.
* Pick reviewers based on branch namestable-reviewer-rouletteSean McGivern2019-04-081-4/+14
| | | | | | | | | | | | | | | | | | | Change reviewer roulette to always pick the same reviewers for the same branch name. We do this by: 1. Making the branch name 'canonical' across CE and EE by stripping a leading 'ce-' or 'ee-' and a trailing '-ce' or '-ee'. If people are following our branch naming guidelines, this should give the same branch name in both repos. 2. Converting the branch name to a stable integer by taking the integer form of its MD5. 3. Passing that integer as a seed to Ruby's `Random` class, which 'may be used to ensure repeatable sequences of pseudo-random numbers between different runs of the program' (from the Ruby documentation). The upshot is that the same branch name (in CE and EE) should always pick the same reviewers, and those should be evenly distributed across the set of possible reviewers due to the use of MD5.
* Add issue links to Danger roulette commentsSean McGivern2019-04-081-0/+3
|
* Make trainee maintainers three times as likely to be picked60035-weight-trainee-maintainers-higher-in-reviewer-rouletteSean McGivern2019-04-051-2/+4
| | | | | | | | | | Trainee maintainers count as reviewers, but should get more reviews than most reviewers, as they need practice to become a maintainer. This makes them three times as likely to be picked (compared to another reviewer; compared to before, it's roughly twice as likely at the current numbers for each). Also, switch to `Array#sample` because I think it looks nicer.
* Set specific reviewers for the GitLab UI WG effortgl-set-up-gitlab-ui-danger-reviewerFilipa Lacerda2019-03-292-1/+58
|
* Reduce dangerbot message to the essentialsEvan Read2019-03-131-19/+5
|
* Set specific reviewers for single codebase effortMarin Jankovski2019-03-112-1/+59
| | | | | | | This extends Danger so it informs MR authors that single codebase merge requests need to be approved by a specific group of engineers. Co-authored-by: Yorick Peterse <yorickpeterse@gmail.com>
* Resolve "Fix danger commit messages check"Lin Jen-Shin2019-02-221-1/+1
|
* Merge branch 'template-improvements-for-documentation' into 'master'Mike Lewis2019-02-201-14/+14
|\ | | | | | | | | Template and process improvements for documentation See merge request gitlab-org/gitlab-ce!24315
| * Merge branch 'master' into 'template-improvements-for-documentation'Mike Lewis2019-02-184-45/+92
| |\ | | | | | | | | | # Conflicts: # .gitlab/merge_request_templates/Documentation.md
| * | Update Documentation Dangerfile with small wording changeMike Lewis2019-02-181-1/+1
| | |
| * | Update Dangerfile per updated Technical Writing review policyMike Lewis2019-02-111-14/+14
| | |
* | | Refactor commit_messages#lint_commitKamil Trzciński2019-02-201-118/+128
| | | | | | | | | | | | | | | This introduces additional method for linting, to reduce the complexity of `lint_commits`.
* | | Ignore revert commitsKamil Trzciński2019-02-191-0/+3
| |/ |/|
* | Fix the documentation DangerfileNick Thomas2019-02-181-1/+1
| |
* | Reviewer roulette ignores changelogsNick Thomas2019-02-141-0/+3
| |
* | Reviewer roulette via Danger56087-danger-rouletteNick Thomas2019-02-133-51/+88
| | | | | | | | | | | | Make danger pick reviewers and maintainers at random, for feontend, backend, database, etc, changes, whenever files belonging to those teams get changed.
* | Move the ee? helper method into the helperNick Thomas2019-02-132-5/+6
| |
* | Move change category detection to a helperNick Thomas2019-02-132-12/+18
|/
* Change Monitoring to Monitor in docs dangerfileAchilleas Pipinellis2019-01-221-1/+1
|
* Fix Danger commit message errorsDrew Blessing2019-01-111-3/+3
|
* Shorten danger 50 char commit warningPaul Slaughter2019-01-111-5/+5
| | | | - Also pulls URLs into vars
* Only detect short refs followed by \b in DangerRémy Coutable2019-01-081-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Update danger for documentation [ci skip]George Tsiolis2018-12-191-1/+1
| | | | Rename ~Packaging label to ~Package
* Merge branch '51226-check-yarn-lock' into 'master'Rémy Coutable2018-12-181-0/+27
|\ | | | | | | | | | | | | Add danger check for duplicate yarn dependencies Closes #51226 See merge request gitlab-org/gitlab-ce!21591
| * Add danger check for duplicate yarn dependenciesLukas Eipert2018-12-171-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | This danger check utilises `yarn-deduplicate` in order to show duplicate dependencies in the yarn.lock dependency tree. Often when introducing new dependencies or updating existing ones, yarn does not seem to build the most optimal dependency tree. In order to prevent those unnecessary dependency updates we are nudging developers and maintainers to resolve these issues in MRs. Automating this with danger especially helps, as yarn.lock files are not that easy to review.
* | Clarify messaging on what fails for too many failed linesSam Bigelow2018-12-171-1/+1
|/
* Remove rails 4 support in CI, Gemfiles, bin/ and config/Jasper Maes2018-12-141-1/+1
|
* Update docs' DangerfileMarcia Ramos2018-12-061-9/+10
|
* Don't request changelog for MR with some labelsRémy Coutable2018-12-051-1/+1
| | | | | | Namely the `ci-build` and `meta` labels. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Make the table of tech writers and stages more compactdocs/dangerfileAchilleas Pipinellis2018-11-161-18/+9
|
* Proper markdown table in docs DangerfileAchilleas Pipinellis2018-11-121-14/+16
|
* Edits to docs Dangerfiledocs/danger-documentationMike Lewis2018-11-091-10/+21
|
* Dangerbot: mention tech writers based on DevOps stageAchilleas Pipinellis2018-11-091-3/+13
|
* Warn when MR titles are too longdanger-mr-title-warningYorick Peterse2018-11-071-0/+7
| | | | | | | | | | | This adds a Danger check to produce a warning for MR titles greater than 72 characters. This is necessary because when squash on merge is used, the MR title will be used for the commit message (at least by default). This in turn leads to commit messages that violate our commit message guidelines. For more information, refer to https://gitlab.com/gitlab-org/release/framework/issues/24.
* Also count specs in new files in Danger checkconsider-added-specs-in-danger-checksSean McGivern2018-10-231-2/+4
| | | | | | | | We have a Danger check that warns if you made changes in app/ but not in spec/. However, this only checked for changed files - not new files. If you added an app file with no specs, it wouldn't warn; and it would warn erroneously if you added a missing spec file while changing a file in app/.
* Create helper to get all changed filesleipert-danger-fix-moved-filesLukas Eipert2018-10-225-8/+38
| | | | | | | | | | | | | | | | Danger apparently has three different objects which could contain files you often want to check: - git.added_files - git.modified_files - git.renamed_files The problem: If a file is renamed, `modified_files` contains the file path before the rename. In some Danger checks we use `added_files` + `modified_files`, which might contain the deleted paths of renamed files, but missing the new paths of renamed files. So we need to consider `renamed_files` as well.
* Danger check for ignored eslint rulesleipert-frontend-dangerLukas Eipert2018-09-291-0/+29
| | | | | | We disabled a lot of eslint rules on a per-file basis. This checks touched files for those and reminds you to re-enable the rules and fix them.
* Danger check for unprettified JavaScriptLukas Eipert2018-09-281-0/+39
| | | | | This adds a Dangerfile which executes `prettier` to find out if someone touched Frontend files and forgot to run it on their current branch.
View Lorry Controller Status