summaryrefslogtreecommitdiff
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Validate presence of provider field in Identityidentity-validationDmitriy Zaporozhets2015-06-231-0/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Merge branch 'animation-sidebar' into 'master'Dmitriy Zaporozhets2015-06-234-18/+38
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | Animation of Sidebar (video in here) Edited the CSS of header and sidebar; added a new div of gitlab-logo-container to the html to make things easier. The transition-duration is set to 0.3s and when the nav bar expands, it opens up over the text, essentially revealing hidden text. [animation-sidebar-2.mov](https://gitlab.com/gitlab-org/gitlab-ce/uploads/b15996a256d6bed03a19c68549d116e4/animation-sidebar-2.mov) /cc @JobV @nicolas2 See merge request !849
| * fixed the resizing icon issueanimation-sidebarDarby2015-06-221-2/+2
| |
| * Edited the CSS of header and sidebar; added a new class of logo-container to ↵Darby2015-06-194-16/+36
| | | | | | | | the html to make things easier
* | Merge branch 'rs-dev-issue-2414' into 'master'Dmitriy Zaporozhets2015-06-232-18/+24
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow Admin to filter users by 2FA status > ![Screen_Shot_2015-06-19_at_4.38.12_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/deba7f2a6b8d1548c1d1ac401e0e35a1/Screen_Shot_2015-06-19_at_4.38.12_PM.png) Closes internal https://dev.gitlab.org/gitlab/gitlabhq/issues/2414 See merge request !852
| * | Use alias_attribute to define User#two_factor_enabledrs-dev-issue-2414Robert Speicher2015-06-221-14/+3
| | |
| * | Make default value for otp_required_for_login false instead of nullRobert Speicher2015-06-201-4/+4
| | |
| * | Allow Admin to filter users by 2FA statusRobert Speicher2015-06-192-4/+21
| | |
* | | Merge branch 'revert-mr-state-names'Dmitriy Zaporozhets2015-06-2211-35/+35
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> Conflicts: features/steps/project/merge_requests.rb
| * | | Fix closed merge request scope at milestone pageDmitriy Zaporozhets2015-06-221-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | Revert merge request states renamingDmitriy Zaporozhets2015-06-1911-34/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaced: * "Accepted" with "Merged" * "Rejected" with "Closed" Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | Merge branch 'see-full-size-avatar' into 'master'Dmitriy Zaporozhets2015-06-221-1/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Link an users avatar to the fullsize version When we want to see the fullsize avatar of a user we can click the avatar on the profile page and the fullsize version will be opened in a new window/tab. See merge request !415
| * | | | When we want to see the fullsize avatar of a user we can click the avatar on ↵Sander Boom2015-03-211-1/+2
| | | | | | | | | | | | | | | | | | | | the profile page and the fullsize version will be opened in a new window/tab.
* | | | | Merge branch 'remove_unused_except' into 'master'Dmitriy Zaporozhets2015-06-221-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | projects doesn't seem to be a valid action in this controller Hi, This is just a tiny change. Let me know if I'm doing it wrong... Eaden See merge request !696
| * | | | | projects doesn't seem to be a valid action in this controllerEaden2015-05-161-2/+2
| | | | | |
* | | | | | Merge branch 'rs-rspec3' into 'master'Dmitriy Zaporozhets2015-06-228-13/+19
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RSpec3 Upgrades rspec to 3.3.0, we're now up-to-date! :tada: See merge request !831
| * | | | | | Replace remaining references to `Note.create_cross_reference_note`Robert Speicher2015-06-225-9/+4
| | | | | | |
| * | | | | | Update mock and stub syntax for specsRobert Speicher2015-06-223-4/+15
| | | | | | |
* | | | | | | Merge branch 'rs-remove-link-to-override'Dmitriy Zaporozhets2015-06-221-33/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> Conflicts: spec/helpers/application_helper_spec.rb
| * | | | | | | Remove overridden `link_to` helperrs-remove-link-to-overrideRobert Speicher2015-06-171-33/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The purpose for this override is now handled by `ExternalLinkFilter`.
* | | | | | | | Merge branch 'new-logo' into 'master'Dmitriy Zaporozhets2015-06-227-2/+58
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace old logo with new one Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> cc @JobV @sytses See merge request !848
| * | | | | | | Replace old logo with new onenew-logoDmitriy Zaporozhets2015-06-197-2/+58
| | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | | | | Merge branch 'web-editor-autocrlf' into 'master'Dmitriy Zaporozhets2015-06-221-1/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Convert CRLF newlines to LF when committing using the web editor. Fixes #1823 and https://github.com/gitlabhq/gitlabhq/issues/7950. Depends on https://gitlab.com/gitlab-org/gitlab_git/merge_requests/29 being merged and a new gitlab_git being released. cc @jacobvosmaer See merge request !858
| * | | | | | | Convert CRLF newlines to LF when committing using the web editor.web-editor-autocrlfDouwe Maan2015-06-201-1/+6
| | | | | | | |
* | | | | | | | Merge branch 'rs-dev-issue-2355' into 'master'Dmitriy Zaporozhets2015-06-2216-119/+228
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MergeRequest#show performance improvements This is a first pass on improving the performance of the `MergeRequests#show` page. Notable changes: - The "Commits" tab is loaded lazily, so the initial page load should be much faster for MRs with many commits. - Relative timestamps via `timeago` are only initialized once per load instead of `O(n^2)`. This greatly improves frontend rendering times for a large number of commits. - Refactored `User.find_for_commit` to use a single ARel-generated SQL query instead of the old method which resulted in one query, and could result in up to three. See merge request !838
| * | | | | | | | Add MergeRequestTabs specsrs-dev-issue-2355Robert Speicher2015-06-211-44/+89
| | | | | | | | |
| * | | | | | | | Minor style fixes in MergeRequestTabsRobert Speicher2015-06-211-2/+2
| | | | | | | | |
| * | | | | | | | Use `skip_js` for commit timestampsRobert Speicher2015-06-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This greatly improves frontend rendering times.
| * | | | | | | | Load the Merge Request > Commits tab lazilyRobert Speicher2015-06-172-3/+6
| | | | | | | | |
| * | | | | | | | Extract MergeRequest tab behavior to its own JS classRobert Speicher2015-06-172-88/+115
| | | | | | | | |
| * | | | | | | | Spec and refactor User.find_for_commitRobert Speicher2015-06-171-4/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now it executes a single query instead of a possible three at the cost of some scary-looking ARel calls.
| * | | | | | | | Remove duplicate `timeago` callRobert Speicher2015-06-171-2/+1
| | | | | | | | |
| * | | | | | | | Update time_ago_with_tooltip helperRobert Speicher2015-06-179-21/+40
| | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | Minor refactoring, add specs, changes arguments to use keywords.
* | | | | | | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ceDmitriy Zaporozhets2015-06-2212-93/+188
|\ \ \ \ \ \ \ \ | | |/ / / / / / | |/| | | | | |
| * | | | | | | Merge branch 'new-mr-disable-change-target-branch' into 'master'Douwe Maan2015-06-201-6/+7
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Disable changing of target branch in new merge request page when a branch has already been specified ### What does this MR do? This MR prevents a user from changing the target branch inside a new merge request page if the target branch has already been specified (e.g. from the shortcut in the activity feed). A link to "Change branches" is provided to allow the user to do this properly. ### Why was this MR needed? If a user attempted to create a merge request from a shortcut with a pre-specified target branch (e.g. `master`), the dropdown would suggest that the user could change the branch. However, this did not actually work due to duplicate data elements (see #1830 for more details), and the target branch would always be set to the original, default branch. This would lead to confusion, potentially causing an improper merge request to be created. ### What are the relevant issue numbers? Closes #1830 ### Screenshot ![image](https://gitlab.com/stanhu/gitlab-ce/uploads/eeec4f5d4b66625a14be41e5ecbdc016/image.png) See merge request !846
| | * | | | | | | Disable changing of target branch in new merge request page when a branch ↵Stan Hu2015-06-191-6/+7
| | | |/ / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | has already been specified Closes #1830
| * | | | | | | Merge branch 'fix-error-500-internal-snippet' into 'master'Douwe Maan2015-06-201-1/+1
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix Error 500 when one user attempts to access another's personal, internal snippet ### What does this MR do? This MR fixes an Error 500 that occurred if one user tried to access another's personal, internal snippet. Steps to reproduce: ### Why was this MR needed? 1. Go to `<hostname>/snippets/new`. 2. Select "Internal". 3. Create a snippet. Save the URL (e.g. `<hostname>/snippets/20`) 4. Logout and sign in as another user. 5. Go to the URL in step 3. ### What are the relevant issue numbers? Closes #1815 See merge request !854
| | * | | | | | | Fix Error 500 when one user attempts to access a personal, internal snippetStan Hu2015-06-191-1/+1
| | |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | Closes #1815
| * | | | | | | Merge branch 'rs-blobview-js-refactor' into 'master'Robert Speicher2015-06-194-77/+152
| |\ \ \ \ \ \ \ | | |_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor and spec line highlighting Javascript - Replaces the fragile Spinach tests for this feature with Jasmine tests - The "Don't scroll the page when we click a line number" behavior now works as expected See merge request !820
| | * | | | | | Minor style fixes for LineHighlighterRobert Speicher2015-06-191-3/+3
| | | | | | | |
| | * | | | | | Refactor LineHighlighterrs-blobview-js-refactorRobert Speicher2015-06-191-41/+29
| | | | | | | |
| | * | | | | | Rename BlobView to LineHighlighterRobert Speicher2015-06-192-4/+4
| | | | | | | |
| | * | | | | | Simplify line numberingRobert Speicher2015-06-191-1/+1
| | | | | | | |
| | * | | | | | Use `pushState` instead of the temporary div hackRobert Speicher2015-06-191-36/+10
| | | | | | | |
| | * | | | | | Refactor and spec BlobView JSRobert Speicher2015-06-192-74/+187
| | |/ / / / /
| * | | | | | Use User#two_factor_enabled instead of otp_required_for_loginrs-dev-issue-2415Robert Speicher2015-06-194-5/+5
| | | | | | |
| * | | | | | Add 2FA status to Admin::Users#showRobert Speicher2015-06-191-0/+8
| | | | | | |
| * | | | | | Add convenience methods to User for getting and setting 2FA statusRobert Speicher2015-06-191-0/+12
| | | | | | |
| * | | | | | Move the User dashboard enum further up in the classRobert Speicher2015-06-191-4/+3
| |/ / / / /
* | | | | | Merge branch 'snippet_optional_filename' into 'master'Douwe Maan2015-06-202-2/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make snippet filename optional. Fixes #2384. See merge request !1866