summaryrefslogtreecommitdiff
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Fix random failing test - delete attachmentfix-random-testDmitriy Zaporozhets2015-12-071-2/+2
| | | | | | | Make sure we wait for AJAX request to finish before end test and cleanup database Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Merge branch 'pberndt:master' into 'master' Robert Speicher2015-12-071-1/+1
|\ | | | | | | | | | | | | | | | | | | Fix #3758: Serious performance issues due to timeago() being called n*(n+1)/2 times instead of n See bug #3758 for a description. This merge request alters `time_ago_with_tooltip` to invoke the `timeago()` javascript on the current timestamp only, instead of each one defined on the page so far. See merge request !1977
| * time_ago_with_tooltip javascript snippet: Don't reinitialize older elementsPhillip Berndt2015-12-031-1/+1
| | | | | | | | see bug #3758
* | Merge branch 'fix-parallel-merge' into 'master' Dmitriy Zaporozhets2015-12-071-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Dont use cached collection for Repository find_branch and find_tag methods Fix for #3816 Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> See merge request !2003
| * | Dont use cached collection for Repository find_branch and find_tag methodsDmitriy Zaporozhets2015-12-071-2/+2
| | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | Merge branch 'report-ssl-errors' of https://gitlab.com/stanhu/gitlab-ceDmitriy Zaporozhets2015-12-072-20/+21
|\ \ \
| * | | Handle and report SSL errors in Web hook test. Check for status 200 for success.Stan Hu2015-12-042-20/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a Web hook test fails due to an SSL error or some other error, report the result back to the user instead of an Error 500. Closes #3656 Handle response
* | | | Merge branch 'feature/sidekiq-cron' into 'master' Dmitriy Zaporozhets2015-12-071-3/+0
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Migrate from Sidetiq to Sidekiq-cron Migrate from Sidetiq to Sidekiq-cron Updated Sidekiq to 3.5.x This will solve #2355 See merge request !1982
| * | | Migrate from Sidetiq to Sidekiq-cronfeature/sidekiq-cronGabriel Mazetto2015-12-041-3/+0
| | | | | | | | | | | | | | | | Updated Sidekiq to 3.5.x
* | | | Merge branch 'webhook_payload_with_changes' into 'master' Valery Sizov2015-12-072-3/+27
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add added, modified and removed properties to commit object in webhook https://gitlab.com/gitlab-org/gitlab-ee/issues/20 See merge request !1988
| * | | | fixes after reviewwebhook_payload_with_changesValery Sizov2015-12-071-16/+9
| | | | |
| * | | | fox specsValery Sizov2015-12-072-15/+24
| | | | |
| * | | | Add added, modified and removed properties to commit object in webhookValery Sizov2015-12-041-1/+23
| | | | |
* | | | | Merge branch 'gsmethells/gitlab-ce-sort-by-due-date'Douwe Maan2015-12-077-10/+47
|\ \ \ \ \
| * | | | | Satisfy RubocopDouwe Maan2015-12-071-1/+1
| | | | | |
| * | | | | Merge branch 'master' into gsmethells/gitlab-ce-sort-by-due-dategsmethells/gitlab-ce-sort-by-due-dateDouwe Maan2015-12-07143-827/+1062
| |\ \ \ \ \
| * | | | | | sort milestones by due_dateGreg Smethells2015-12-037-11/+48
| | |_|_|_|/ | |/| | | |
* | | | | | Merge branch 'fix/award-emoji-conflict-in-notes' into 'master' Grzegorz Bizon2015-12-077-30/+82
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix problems with award-emoji-only comment This fixes a conflict between note with only a single emoji in content and award-emojis mechanisms. Closes #3734 cc @vsizov See merge request !1936
| * | | | | | Simplify `contains_emoji_only?` method in `Note`fix/award-emoji-conflict-in-notesGrzegorz Bizon2015-12-071-2/+1
| | | | | | |
| * | | | | | Remove space before exclamation mark in award alertGrzegorz Bizon2015-12-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| * | | | | | Refactor note awards to reuse `emoji_pattern` and improve validatorGrzegorz Bizon2015-12-051-18/+14
| | | | | | |
| * | | | | | Make method `supports_award?` public in `Note`Grzegorz Bizon2015-12-031-2/+2
| | | | | | |
| * | | | | | Combine new javascript Flash methods into oneGrzegorz Bizon2015-12-032-7/+3
| | | | | | |
| * | | | | | Support emoji awards also in merge requestsGrzegorz Bizon2015-12-031-3/+4
| | | | | | |
| * | | | | | Pin flash message to top if award note is invalidGrzegorz Bizon2015-12-031-1/+3
| | | | | | |
| * | | | | | Add new features to javascript flash messageGrzegorz Bizon2015-12-032-6/+23
| | | | | | |
| * | | | | | Show flash message instead of alert when note is invalidGrzegorz Bizon2015-12-031-1/+2
| | | | | | |
| * | | | | | Notify user when award-emoji comment is invalidGrzegorz Bizon2015-12-032-1/+10
| | | | | | |
| * | | | | | Render json message with errors if note didn't pass validationGrzegorz Bizon2015-12-031-10/+14
| | | | | | |
| * | | | | | Scroll to awards after adding emoji-award commentGrzegorz Bizon2015-12-032-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes it more intuitive, as user can see that something actually happened after adding emoji-only comment in long discussions.
| * | | | | | Move note emoji-award implementation to note model (feature envy)Grzegorz Bizon2015-12-032-24/+33
| | | | | | |
| * | | | | | Support award-emoji notes only when it a comment for an issueGrzegorz Bizon2015-12-031-6/+17
| | | | | | |
| * | | | | | Add validator for award-emoji noteGrzegorz Bizon2015-12-031-0/+1
| | | | | | |
* | | | | | | Merge branch 'fix-global-milestones-error-500' into 'master' Douwe Maan2015-12-072-2/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix Error 500 when creating global milestones with Unicode characters Two issues: 1. The constraints in the resources were incorrect. Here's what it was before: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` In this case, id is actually the title of the milestone, which can be anything at the moment. After: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` 2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like: ``` ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]): ``` This change uses the babosa library to create a better slug, which surprisingly isn't actually used by the global milestone controllers. Instead, they use the title passed as a query string for some reason. Closes https://github.com/gitlabhq/gitlabhq/issues/9881 See merge request !1983
| * | | | | | | Fix Error 500 when creating global milestones with Unicode charactersStan Hu2015-12-052-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two issues: 1. The constraints in the resources were incorrect. Here's what it was before: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` In this case, id is actually the title of the milestone, which can be anything at the moment. After: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` 2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like: ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]): This change uses the babosa library to create a better slug, which surprisingly isn't actually used by the global milestone controllers. Instead, they use the title passed as a query string for some reason. Closes https://github.com/gitlabhq/gitlabhq/issues/9881 Fix constraints
* | | | | | | | Merge branch 'style-warning-about-mentioning-many-people-in-a-comment' into ↵Douwe Maan2015-12-072-13/+11
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Style warning about mentioning many people in a comment Fixes #2885 * Create issue: Before: ![Screenshot_2015-12-03_15.23.44](/uploads/6da9b326e47dc5e8c127a581af99403c/Screenshot_2015-12-03_15.23.44.png) After: ![Screenshot_2015-12-03_15.21.29](/uploads/bbe328d30a32d642c280bf2ad6d2832c/Screenshot_2015-12-03_15.21.29.png) &nbsp; * New merge request: Before: ![Screenshot_2015-12-03_15.24.06](/uploads/79d6f8f52ba2753aaecf6b6bbd04f0d0/Screenshot_2015-12-03_15.24.06.png) After: ![Screenshot_2015-12-03_15.21.48](/uploads/f01ea8e7d058a9f8b803ca1ce4f533ad/Screenshot_2015-12-03_15.21.48.png) &nbsp; * New comment in a merge request: Before: ![Screenshot_2015-12-03_15.11.23](/uploads/5d958375812d21d41e00694186c7ef7a/Screenshot_2015-12-03_15.11.23.png) After: ![Screenshot_2015-12-03_15.09.08](/uploads/3d6bde6aad46c7d9e53b70a47eecf7c0/Screenshot_2015-12-03_15.09.08.png) &nbsp; * New diff comment: Before: ![Screenshot_2015-12-03_15.25.50](/uploads/08ac9c261c1aa9693706da714c121e15/Screenshot_2015-12-03_15.25.50.png) After: ![Screenshot_2015-12-03_15.46.20](/uploads/07a8b8708ad825eb8cda7e5e40116b81/Screenshot_2015-12-03_15.46.20.png) See merge request !1971
| * \ \ \ \ \ \ \ Merge branch 'master' into ↵style-warning-about-mentioning-many-people-in-a-commentDouglas Barbosa Alexandre2015-12-04114-604/+667
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | style-warning-about-mentioning-many-people-in-a-comment
| * | | | | | | | | Fix specsDouglas Barbosa Alexandre2015-12-032-3/+2
| | | | | | | | | |
| * | | | | | | | | Merge branch 'master' into ↵Douglas Barbosa Alexandre2015-12-0386-474/+524
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | style-warning-about-mentioning-many-people-in-a-comment
| * | | | | | | | | | Improve style of the warning when mentioning many people in a commentDouglas Barbosa Alexandre2015-12-032-12/+11
| | | | | | | | | | |
| * | | | | | | | | | Style warning about mentioning many people in a commentDouglas Barbosa Alexandre2015-12-021-9/+9
| | | | | | | | | | |
* | | | | | | | | | | Merge branch 'issue_1156'Douwe Maan2015-12-075-29/+64
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / / / |/| | | | | | | | | |
| * | | | | | | | | | Raise the exception from #execute instead of #run_hook. #1156 #3069issue_1156Rubén Dávila2015-12-031-11/+9
| | | | | | | | | | |
| * | | | | | | | | | Call update hook from new GitHooksService class. #3069Rubén Dávila2015-12-031-3/+1
| | | | | | | | | | |
| * | | | | | | | | | Run custom Git hooks when creating or deleting branches through the UI. #1156Rubén Dávila2015-12-035-29/+68
| | |_|_|_|_|/ / / / | |/| | | | | | | |
* | | | | | | | | | Fixed duplicated issue note email notifications.Anton Baklanov2015-12-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #2560
* | | | | | | | | | Notify user if they cannot create projectsAndrew Tomaka2015-12-055-1/+19
| |_|_|_|/ / / / / |/| | | | | | | |
* | | | | | | | | Merge branch 'link-refs' into 'master' Robert Speicher2015-12-0411-47/+143
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Recognize issue/MR/snippet/commit links as references. Fixes #3744 and #3745 See merge request !1933
| * | | | | | | | Merge branch 'master' into link-refsDouwe Maan2015-12-0375-299/+291
| |\ \ \ \ \ \ \ \ | | | |_|_|/ / / / | | |/| | | | | |
| * | | | | | | | Merge branch 'master' into link-refsDouwe Maan2015-12-0217-47/+80
| |\ \ \ \ \ \ \ \ | | | |_|/ / / / / | | |/| | | | | |