summaryrefslogtreecommitdiff
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'new-merge-requests-commit-tab-active' into 'master' Fatih Acet2016-10-067-46/+84
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MergeRequest new form load diff asynchronously ## What does this MR do? Don't return diff tab content from the server when request for a new merge request ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? To avoid 502 errors due to this controller action takes to much time ## What are the relevant issue numbers? Relates #13912 ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - ~~[ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - ~~[ ] API support added~~ - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5844
| * MergeRequest new form load diff asynchronouslynew-merge-requests-commit-tab-activePaco Guzman2016-10-067-46/+84
| |
* | Merge branch 'mahcsig/gitlab-ce-17350-multi-file-commit'Rémy Coutable2016-10-065-12/+182
|\ \ | | | | | | | | | See !6096.
| * | multi-file commitMarc Siegfriedt2016-10-055-12/+182
| | | | | | | | | | | | | | | | | | add docs and tests - add additional validation allow move without content updated response
* | | Merge branch 'jeroenj/gitlab-ce-group-milestone-archived-projects'Rémy Coutable2016-10-061-2/+2
|\ \ \ | |_|/ |/| | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | Don't include archived projects when creating group milestonesJeroen Jacobs2016-10-051-2/+2
| | |
* | | Merge branch 'feature/improve-async-pipeline-processing' into 'master' Kamil Trzciński2016-10-064-8/+32
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve asynchronous pipeline processing ## What does this MR do? This MR improves asynchronous processing of pipeline. ## Why was this MR needed? It eliminates some race conditions and improves performance. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [x] All builds are passing ## What are the relevant issue / merge request numbers? Related merge request: !6410 Extracted from !6411 See merge request !6650
| * | | Do not return false in commit status transitionfeature/improve-async-pipeline-processingGrzegorz Bizon2016-10-043-7/+5
| | | |
| * | | Fix hipchat service specs after changes in pipelineGrzegorz Bizon2016-10-041-3/+2
| | | |
| * | | Update order of build transition callbacksGrzegorz Bizon2016-10-044-24/+22
| | | |
| * | | Extract updating pipeline status to async workerGrzegorz Bizon2016-10-043-13/+24
| | | |
| * | | Use internal commit status API to check if finishedGrzegorz Bizon2016-10-041-2/+2
| | | |
| * | | Fix async pipeline and remove unrelated changesGrzegorz Bizon2016-10-046-26/+16
| | | |
| * | | Make pipeline processing asynchronousKamil Trzcinski2016-10-037-23/+51
| | | | | | | | | | | | | | | | | | | | | | | | Conflicts: app/models/ci/pipeline.rb app/models/commit_status.rb
* | | | Fix CHANGELOG and wrong conflict resolutionRémy Coutable2016-10-061-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | Merge commit 'dev/security' into 'master'Rémy Coutable2016-10-0611-19/+40
|\ \ \ \ | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * \ \ \ Merge branch 'fix/escape-builds-commands-in-ci-linter' into 'security' Robert Speicher2016-09-281-2/+1
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Escape HTML nodes in builds commands in ci linter This MR removes call to `simple_format` that behaves like `String#html_safe`, thus it passes unescaped HTML tags to the view. Closes #22541 See merge request !2001
| | * | | | Escape HTML nodes in builds commands in ci linterGrzegorz Bizon2016-09-261-2/+1
| | | | | |
| * | | | | Merge branch '22435-no-api-state-change-via-rails-session' into 'security' Douwe Maan2016-09-288-18/+26
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | API: disable rails session auth for non-GET/HEAD requests Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/22435 See merge request !1999
| | * | | | | Convert label creation from API to controller endpointNick Thomas2016-09-238-18/+26
| | | | | | |
| * | | | | | Enforce the fork_project permission in Projects::CreateServiceNick Thomas2016-09-272-0/+14
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Projects::ForkService delegates to this service almost entirely, but needed one small change so it would propagate create errors correctly. CreateService#execute needs significant refactoring; it is now right at the complexity limit set by Rubocop. I avoided doing so in this commit to keep the diff as small as possible. Several tests depend on the insecure behaviour of ForkService, so fi them up at the same time.
* | | | | | Merge branch 'flash-cherry-pick-error' into 'master' Fatih Acet2016-10-051-7/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevent flash alert text from being obscured when container is fluid ## What does this MR do? Fixes [a regression](https://gitlab.com/gitlab-org/gitlab-ce/commit/a2af7790) that causes the text within server-initiated flash *alerts* (not flash *notices*) to be obscured when `.container-fluid` is applied. It was reported in relation to a cherry-picking flash alert, but the problem occurs with all server-initiated flash alerts contained by a fluid container. ## Are there points in the code the reviewer needs to double check? Note that as part of this fix, I combined some duplicate code and removed `.flash-text` & `.content-wrapper` selectors as they didn't seem to be necessary. I manually tested JS-initiated Flash alerts to make sure this doesn't affect their appearance. I also grepped around for anything else that might depend on these styles. Everything checked out. But... can *you* see something this is going to break? ## Why was this MR needed? Affected users can't read flash alerts. ## Screenshots (if relevant) Before: ![Screen_Shot_2016-10-05_at_3.02.38_PM](/uploads/af258585e428d82dc2b293434661790b/Screen_Shot_2016-10-05_at_3.02.38_PM.png) After: ![Screen_Shot_2016-10-05_at_3.02.47_PM](/uploads/75a93235440e2b83088e66bbe53d6cee/Screen_Shot_2016-10-05_at_3.02.47_PM.png) JS-initiated flash alert (unaffected): ![Screen_Shot_2016-10-05_at_3.39.57_PM](/uploads/ba678cfaeb09c639499059712a33abe8/Screen_Shot_2016-10-05_at_3.39.57_PM.png) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] API support added - Tests - [] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/22915 cc: @jschatz1 See merge request !6694
| * | | | | | Make flash-alert background transparent to match flash-notice.flash-cherry-pick-errorBryce Johnson2016-10-051-7/+2
| | | | | | |
* | | | | | | Merge branch 'revert-c676283b' into 'master' Fatih Acet2016-10-0518-123/+214
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updated issuable form with GL dropdowns ## What does this MR do? This adds back in the GL dropdowns into the issuable form but fixes a lot of usability issues & bugs. ## What are the relevant issue numbers? Closes #19879, #19882, #19881, #19883, #19880 ## Screenshots (if relevant) ![Screen_Shot_2016-08-30_at_12.13.09](/uploads/f1df758b3fb59958b4e6b62960b81bfb/Screen_Shot_2016-08-30_at_12.13.09.png) ![Screen_Shot_2016-08-30_at_12.13.13](/uploads/6e4fd8f4d874b14eaab6b10752a19df4/Screen_Shot_2016-08-30_at_12.13.13.png) See merge request !5293
| * | | | | | | Fix bad merge conflict resolution.Fatih Acet2016-10-051-2/+0
| | | | | | | |
| * | | | | | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into ↵Fatih Acet2016-10-051-1/+1
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | revert-c676283b-existing
| * \ \ \ \ \ \ \ Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into ↵revert-c676283bFatih Acet2016-10-0536-988/+905
| |\ \ \ \ \ \ \ \ | | | |_|_|_|_|_|/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | revert-c676283b-existing # Conflicts: # app/assets/javascripts/dispatcher.js
| * | | | | | | | Set default value for show_menu_above variable.Fatih Acet2016-10-051-1/+2
| | | | | | | | |
| * | | | | | | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into ↵Fatih Acet2016-10-059-30/+77
| |\ \ \ \ \ \ \ \ | | | |_|/ / / / / | | |/| | | | | | | | | | | | | | | revert-c676283b-existing
| * | | | | | | | Add position menu above ability to glDropdown.Fatih Acet2016-10-047-39/+41
| | | | | | | | |
| * | | | | | | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into ↵Fatih Acet2016-10-0429-89/+209
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | revert-c676283b-existing
| * | | | | | | | | Tweak issuable dropdowns to open above the dropdown.Fatih Acet2016-10-042-1/+29
| | | | | | | | | |
| * | | | | | | | | Fix dropdown title when No Label selected.Fatih Acet2016-10-042-23/+41
| | | | | | | | | |
| * | | | | | | | | Merge branch 'master' into revert-c676283bPhil Hughes2016-10-0429-53/+146
| |\ \ \ \ \ \ \ \ \
| * | | | | | | | | | Tests updatePhil Hughes2016-10-031-1/+1
| | | | | | | | | | |
| * | | | | | | | | | Merge branch 'master' into revert-c676283bPhil Hughes2016-10-03431-2733/+5529
| |\ \ \ \ \ \ \ \ \ \
| * \ \ \ \ \ \ \ \ \ \ Merge branch 'master' into revert-c676283bPhil Hughes2016-09-02143-1123/+1563
| |\ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | Fixed boards filtersPhil Hughes2016-08-302-1/+3
| | | | | | | | | | | | |
| * | | | | | | | | | | | Removed namespace testPhil Hughes2016-08-301-1/+1
| | | | | | | | | | | | |
| * | | | | | | | | | | | Fixed label toggle textPhil Hughes2016-08-301-14/+17
| | | | | | | | | | | | |
| * | | | | | | | | | | | Merge branch 'master' into revert-c676283bPhil Hughes2016-08-30846-14049/+25105
| |\ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | Removes @projects as not used anymore - getting selected data from ↵Phil Hughes2016-07-202-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | controller instead
| * | | | | | | | | | | | | Fixed up frontend code based on feedbackPhil Hughes2016-07-208-16/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updated a test to be more specific about where the content is
| * | | | | | | | | | | | | Removed duplicate labels from the dropdown on dashboardPhil Hughes2016-07-204-22/+16
| | | | | | | | | | | | | |
| * | | | | | | | | | | | | Uses the selected values from the controller not the paramsPhil Hughes2016-07-209-57/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added tests for new merge requests from forked project & owned project
| * | | | | | | | | | | | | Removes tick from no label when selecting a labelPhil Hughes2016-07-201-0/+6
| | | | | | | | | | | | | |
| * | | | | | | | | | | | | Fixed 'no label' being in dropdown toggle labelPhil Hughes2016-07-202-7/+5
| | | | | | | | | | | | | |
| * | | | | | | | | | | | | Remove unnecesary update.label eventAlfredo Sumaran2016-07-202-2/+0
| | | | | | | | | | | | | |
| * | | | | | | | | | | | | Fixed issue where label query would bring back duplicatesPhil Hughes2016-07-201-1/+1
| | | | | | | | | | | | | |
| * | | | | | | | | | | | | Fixed issuable sidebar label toggle not workingPhil Hughes2016-07-203-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed un-used JS var