summaryrefslogtreecommitdiff
path: root/app/services/groups
Commit message (Collapse)AuthorAgeFilesLines
* Make sure repository's removal work for legacy and hashed storages28283-uuid-storageGabriel Mazetto2017-08-221-1/+1
|
* Remove Mattermost team with GitLab groupZ.J. van de Weg2017-07-281-0/+2
| | | | | | | When destroying a group, now an API call is made to the Mattermost server to request the deletion of the project. Actual team deletion on the Mattermost side happens async, so the runtime shouldn't increase by more than a second.
* Defer project destroys within a namespace in ↵Stan Hu2017-06-291-2/+1
| | | | | | | | | | | Groups::DestroyService#async_execute Group#destroy would actually hard-delete all associated projects even though the acts_as_paranoia gem is used, preventing Projects::DestroyService from doing any work. We first noticed this while trying to log all projects deletion to the Geo log.
* Fix current feature related specsTiago Botelho2017-06-281-1/+1
|
* Merge branch 'jej-group-name-disclosure' into 'security'Sean McGivern2017-03-291-0/+8
| | | | | | Prevent private group disclosure via parent_id See merge request !2077
* Fix eslintZ.J. van de Weg2017-03-061-6/+3
|
* Merge branch 'master' into zj-create-mattermost-teamZ.J. van de Weg2017-03-021-1/+2
|\
| * Make nested groups deletion synchronous to avoid potential raceStan Hu2017-02-271-1/+2
| |
* | Improve UXZ.J. van de Weg2017-03-023-21/+11
| |
* | Review changesLuke "Jared" Bennett2017-02-281-1/+1
| |
* | Fix testsZ.J. van de Weg2017-02-243-10/+19
| |
* | Merge branch 'master' into zj-create-mattermost-teamZ.J. van de Weg2017-02-201-1/+3
|\ \ | |/
| * Fix a number of race conditions that can occur during namespace deletionsh-namespace-cleanup-deleted-projectsStan Hu2017-02-151-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two problems in the current implementation: 1. If a project is marked for deletion via the `pending_delete` flag and then the namespace was quickly deleted, it's possible that the namespace skips over that project and leaves that project in an orphaned state. 2. Before namespace deletion, the namespace attempts to clean up all the relevant storage paths. However, if all projects have been removed synchronously, then the namespace will not be able to clean anything. To prevent this, we should load the paths to be deleted before actually destroying projects. The specs were missing this second case due to a permission issue that caused project removal never to happen.
* | Transactional mattermost team creationZ.J. van de Weg2017-02-201-8/+13
| | | | | | | | | | | | | | Before this commit, but still on this feature branch, the creation of mattermost teams where a background job. However, it was decided it was better that these happened as transaction so feedback could be displayed to the user.
* | Improve DRYness of viewsZ.J. van de Weg2017-02-162-1/+8
| |
* | Add tests for Mattermost team creationZ.J. van de Weg2017-02-161-1/+3
| |
* | Create MM team for GitLab groupZ.J. van de Weg2017-02-161-0/+5
|/
* Fix inconsistent naming for services that delete thingsdixpac2017-02-081-0/+25
| | | | | | * Changed name of delete_user_service and worker to destroy * Move and change delete_group_service to Groups::DestroyService * Rename Notes::DeleteService to Notes::DestroyService
* Refactor nested group related codedz-nested-group-miscDmitriy Zaporozhets2016-12-291-10/+4
| | | | | | | * Simplify code around group parent access check * Rename 'Nested groups' to 'Subgroups' tab at group#show page Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Add nested groups support to the Groups::CreateServiceDmitriy Zaporozhets2016-12-261-0/+13
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Fix error 500 renaming group. Also added specs and changelog.James Lopez2016-12-201-1/+7
|
* Enable Style/MultilineOperationIndentation in Rubocop, fixes #25741Rydkin Maxim2016-12-161-1/+1
|
* Address feedbackDouwe Maan2016-03-222-5/+1
|
* Fix specsDouwe Maan2016-03-201-1/+1
|
* Tweaks, refactoring, and specsDouwe Maan2016-03-203-15/+16
|
* Improve group visibility level featureZeger-Jan van de Weg2016-03-183-24/+16
|
* Code fixesFelipe Artur2016-03-173-30/+24
|
* Code improvements and add Create group serviceFelipe Artur2016-03-163-10/+24
|
* Prevent projects to have higher visibility than groupsFelipe Artur2016-03-102-0/+53
Prevent Groups to have smaller visibility than projects Add default_group_visibility_level to configuration Code improvements