| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| | |
Remove unecessary validate: true from belongs_to :project
See merge request gitlab-org/gitlab-ce!17166
|
| |
| |
| |
| | |
This does not seem to serve any clear purpose and causes other issues (see https://gitlab.com/gitlab-org/gitlab-ce/issues/43196#note_59275652)
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Resolve "Double closing system notes when closing issue with Merge Request"
Closes #32546 and #32564
See merge request gitlab-org/gitlab-ce!17035
|
| |/
| |
| |
| |
| |
| |
| | |
When a merge request is merged, it creates a commit with the
description of the MR, which may contain references and issue
closing references. As this will be handled in the PostMergeService
anyways, let's ignore merge commit generated from a MR.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Don't attempt to update user tracked fields if database is in read-only
Closes gitlab-ee#4972
See merge request gitlab-org/gitlab-ce!17200
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
With Geo, attempting to view an endpoint with a user could result in an
Error 500 since Devise attempts to update the last sign-in IP and other
details.
Closes gitlab-org/gitlab-ee#4972
|
|\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | | |
into 'master'
Sanitize extra blank spaces used when uploading a SSH key
Closes #40552
See merge request gitlab-org/gitlab-ce!17138
|
| | |
| | |
| | |
| | |
| | |
| | | |
'rd-43185-revert-sanitize-extra-blank-spaces-used-when-uploading-a-ssh-key' into 'master'"
This reverts commit e607fd796657afd214b8f25201919d3e33b3f35f.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Revert "Merge branch 'expired-ci-artifacts' into 'master'"
See merge request gitlab-org/gitlab-ce!17193
|
| | |/
| |/|
| | | |
This reverts merge request !16578
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Trim whitespace from input in the username/email form field
Closes #42637
See merge request gitlab-org/gitlab-ce!17020
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As per the discussion with @psimyn, this change does not affect the frontend, so user input will not be validated on the signin screen.
Instead, the value sent to the backend has leading and trailing whitespace stripped before looking up the user with find_by.
Closes #42637
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix Error 500s loading repositories with inconsistent HEAD
Closes #43268
See merge request gitlab-org/gitlab-ce!17128
|
| | | | |
|
| | | | |
|
| | | | |
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We removed the exception handling for Rugged errors in !16770, which
revealed that the licensee gem attempts to retrieve a license file
via Rugged in `refs/heads/master` by default. If that branch
did not exist, a Rugged::ReferenceError would be thrown.
There were two issues:
1. Not every project uses `master` as the default branch. This
change uses the head commit to identify the license.
2. Removing the exception handling caused repositories to fail
loading. We can safely catch and ignore any Rugged error because
this means we weren't able to load a license file.
Closes #43268
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Resolve "Project variables validate without any scopes disregarding environment_scope"
Closes #43191
See merge request gitlab-org/gitlab-ce!17086
|
| |/ |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
'43240-external-tracker-issues-don-t-have-the-correct-closing-text-appended-to-mrs' into 'master'
Resolve "External tracker issues don't have the correct closing text appended to MRs"
Closes #1 et #43240
See merge request gitlab-org/gitlab-ce!17109
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before, this would:
1. Not use the correct reference for non-JIRA external trackers.
2. Append 'Closes ' if an external tracker was enabled, but no issue matched the
branch name.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Remove ignore_column :data from Event
Closes #38135
See merge request gitlab-org/gitlab-ce!17094
|
| | | |
| | | |
| | | |
| | | | |
Closes #38135.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Change SQL for expired artifacts to use new ci_job_artifacts.expire_at
See merge request gitlab-org/gitlab-ce!16578
|
| | | | |
| | | | |
| | | | |
| | | | | |
Gitlab::SQL::Union
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
clauses on them
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
migration efficiently
Artifacts are in the middle of being migrated from ci_builds to
ci_job_artifacts. The expiration date is currently visible in both of
these tables and the test for whether an expired artifact is present
for a job is complex as it requires checking both the of the tables.
Add two new indexes, one on ci_builds.artifacts_expire_at and one on
ci_job_artifacts.expire_at to enable finding expired artifacts
efficiently.
And until the migration is finished, replace the SQL for finding
expired and non-expired artifacts with a hand-crafted UNION ALL based
query instead of using OR. This overcomes a database optimizer
limitation that prevents it from using these indexes.
When the migration is finished the next version should remove this
query and replace it with a much simpler query on just
ci_job_artifacts. See
https://gitlab.com/gitlab-org/gitlab-ce/issues/42561 for followup.
|
| |_|/ /
|/| | |
| | | |
| | | | |
previously a member of"
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add information about projects when searching in wiki_blobs, blobs, commits scopes
Closes #42934
See merge request gitlab-org/gitlab-ce!17095
|
| | |_|/
| |/| | |
|
|\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
Display a link to external issue tracker when enabled
Closes #37050
See merge request gitlab-org/gitlab-ce!17030
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | | |
Closes #37436
Closes gitaly#998
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
'rd-40552-gitlab-should-check-if-keys-are-valid-before-saving' into 'master'"
This reverts commit a58f8c32c62bcf5824d1fe1d0de53e9bda974d65, reversing
changes made to cd5d75c362cdf06efb8174eddfbd0f4b65687dec.
|
| | |
| | |
| | |
| | | |
Fix using wildcards in protected tags to expose protected variables
|
|/ /
| |
| |
| |
| |
| | |
'security-10-4-25223-snippets-finder-doesnt-obey-feature-visibility' into 'security-10-4'
[Port for security-10-4]: Makes SnippetFinder ensure feature visibility
|
|\ \
| | |
| | |
| | |
| | | |
Add groups to OpenID Connect claims
See merge request gitlab-org/gitlab-ce!16929
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
MergeRequest#rebase_in_progress? and MergeRequest#rebase_path were called
twice each time per request. This memoization helps reduce the overall number
of queries.
See https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/51616319 as a failing
job.
Closes gitlab-org/gitlab-ee#4857
|
|\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | | |
Resolve "Expose GitLab license/plan as a CI/CD variable"
Closes #40994
See merge request gitlab-org/gitlab-ce!16936
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Deploy prometheus through kubernetes and autoconnect to cluster
Closes #30480 and #28916
See merge request gitlab-org/gitlab-ce!16182
|
| | | |
| | | |
| | | |
| | | | |
+ address small nitpicks
|
| | | |
| | | |
| | | |
| | | | |
default function params
|
| |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* master: (242 commits)
Validate user namespace before saving so that errors persist on model
Reset Project's column information in spec/lib/gitlab/background_migration/populate_merge_request_metrics_with_events_data_spec.rb
Explicitly set cwd in Sidekiq memory killer instead of depending on getcwd
Downgrade google-protobuf
Close low level rugged repository in project cache worker
File upload UI obeys LFS filters
Resolve "Add a link to documentation on how to get external ip in the Kubernetes cluster details page"
Upgrade GitLab Workhorse to v3.6.0
Add sorting options for /users API (admin only)
improvements from feedback
[ci-skip] add changelog
remove file after `Upload#destroy`
Fix a hardcoded pipeline ID in a spinach step
Override group sidebar links
Replace "cluster" with "Kubernetes cluster"
Reorder async/sync tasks in BuildFinishedWorker to read traces efficiently
Fix tests for Drop filename enforcement
Revert using expand_fixture_path in factory
Revert "Add FixtureHelpers for FactoryGirl"
Refactor :trace to :trace_live in spec
...
|
| | | | | |
|