Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | Remove unused `User#projects_limit_percent` | Mehdi Lahmam | 2017-08-20 | 1 | -5/+0 | |
| | | | | | | | | Its last usage has been removed at 87ffd67617. | |||||
| * | Remove `User#projects_sorted_by_activity` | Mehdi Lahmam | 2017-08-20 | 1 | -4/+0 | |
| | | | | | | | | | | | | Its last usage has been removed at https://gitlab.com/mehlah/gitlab-ce/commit/9df6f7bfad#e6ff2c1091173fd03646752d4e30891f66d33db3_46_48 The method can still be useful but should be renamed `authorized_projects_sorted_by_activity` for better clarity. | |||||
* | | Merge branch '37202-revert-changes-to-signing-enabled' into 'master' | Douwe Maan | 2017-09-01 | 1 | -1/+1 | |
|\ \ | | | | | | | | | | | | | | | | | | | Rollback changes made to signing_enabled. Closes #37202 See merge request !13956 | |||||
| * | | Rollsback changes made to signing_enabled. | Tiago Botelho | 2017-09-01 | 1 | -1/+1 | |
| | | | ||||||
* | | | `current_application_settings` belongs on `Gitlab::CurrentSettings` | Sean McGivern | 2017-08-31 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The initializers including this were doing so at the top level, so every object loaded after them had a `current_application_settings` method. However, if someone had rack-attack enabled (which was loaded before these initializers), it would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't have that method. To fix this: 1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need `Object.new.current_application_settings` to work. 2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it like that in several places. 3. Change the initializers to use that new form. | |||||
* | | | Move the logic to a concern | Hiroyuki Sato | 2017-08-29 | 1 | -1/+2 | |
| | | | ||||||
* | | | Improve AutocompleteController#user.json performance | Hiroyuki Sato | 2017-08-25 | 1 | -1/+1 | |
|/ / | ||||||
* | | Add namespace errors from User#after_updatemk-fix-user-namespace-rename | Michael Kozono | 2017-08-18 | 1 | -1/+6 | |
| | | ||||||
* | | Make username update fail if namespace part fails | Michael Kozono | 2017-08-17 | 1 | -1/+1 | |
|/ | ||||||
* | expose Referable#non_referable_inspectdev.non-referable-inspect | http://jneen.net/ | 2017-08-16 | 1 | -5/+0 | |
| | ||||||
* | Merge branch 'rs-more-public-send-whitelists' into 'master' | Rémy Coutable | 2017-08-16 | 1 | -1/+1 | |
|\ | | | | | | | | | Whitelist or fix additional `Gitlab/PublicSend` cop violations See merge request !13467 | |||||
| * | Whitelist or fix additional `Gitlab/PublicSend` cop violationsrs-more-public-send-whitelists | Robert Speicher | 2017-08-14 | 1 | -1/+1 | |
| | | | | | | | | | | An upcoming update to rubocop-gitlab-security added additional violations. | |||||
* | | Merge branch 'rs-remove-username-from-sanitize-attrs' into 'master' | Rémy Coutable | 2017-08-14 | 1 | -3/+3 | |
|\ \ | |/ |/| | | | | | Remove `username` from `User#sanitize_attrs` callback See merge request !13511 | |||||
| * | Remove `username` from `User#sanitize_attrs` callbackrs-remove-username-from-sanitize-attrs | Robert Speicher | 2017-08-11 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | | | This attribute is since validated against `DynamicPathValidator`, which has strict requirements for the characters allowed, and should no longer need to be sanitized in a callback before saving. This has additional benefits in our test suite, where every creation of a `User` record was calling `Sanitize.clean` on a username value that was always clean, since we're the ones generating it. | |||||
* | | don't send devise notifications to the ghost user | http://jneen.net/ | 2017-08-11 | 1 | -0/+1 | |
|/ | ||||||
* | Prevent user from changing username with container registry tags | Michael Kozono | 2017-08-09 | 1 | -0/+8 | |
| | ||||||
* | Use full path of user's avatar in webhooks34339-user_avatar-url-in-push-event-webhook-json-payload-is-relative-should-be-absolute | blackst0ne | 2017-08-09 | 1 | -1/+1 | |
| | ||||||
* | Re-enable SqlInjection and CommandInjection | Brian Neel | 2017-08-08 | 1 | -5/+5 | |
| | ||||||
* | Memoize a user's personal projects count | Yorick Peterse | 2017-08-07 | 1 | -1/+5 | |
| | | | | | | | | | | The method User#projects_limit_left would run "personal_projects.count" but such a query is not memoized. As a result multiple calls to User#projects_limit_left would result in multiple COUNT(*) queries being executed. To work around this this commit adds User#personal_projects_count which simply memoizes the result of the COUNT(*) in an instance variable. | |||||
* | Remove redundant query from User#recent_push | Yorick Peterse | 2017-08-07 | 1 | -10/+8 | |
| | | | | | | The "events" table has a foreign key on "events.project_id" with a cascading delete. As such it's impossible for an event to have a non-existing project ID. | |||||
* | implement #inspect for all Referablesdev.referable-inspect | http://jneen.net/ | 2017-08-01 | 1 | -0/+5 | |
| | ||||||
* | use db's on_delete instead of has_many :dependent | Alexis Reigel | 2017-07-27 | 1 | -1/+1 | |
| | ||||||
* | use after_commit instead of AfterCommitQueue | Alexis Reigel | 2017-07-27 | 1 | -3/+2 | |
| | ||||||
* | perform signature update in sidekiq worker | Alexis Reigel | 2017-07-27 | 1 | -1/+2 | |
| | ||||||
* | update invalid gpg signatures when email changes | Alexis Reigel | 2017-07-27 | 1 | -0/+5 | |
| | ||||||
* | don't sync to keychain file | Alexis Reigel | 2017-07-27 | 1 | -7/+0 | |
| | ||||||
* | remove gpg from keychain when user's email changes | Alexis Reigel | 2017-07-27 | 1 | -0/+7 | |
| | ||||||
* | add profile gpg key page to manage gpg keys | Alexis Reigel | 2017-07-27 | 1 | -0/+1 | |
| | ||||||
* | Use Ghost user when edited_by, merged_by deleted34930-fix-edited-by | Jarka Kadlecova | 2017-07-19 | 1 | -1/+3 | |
| | ||||||
* | Fixes the user order being overriden in the autocomplete controllerfix-exact-matches-of-username-and-email-on-top-of-the-user-search | Tiago Botelho | 2017-07-14 | 1 | -1/+1 | |
| | ||||||
* | Merge branch 'fixes-for-internal-auth-disabled' into 'master' | Sean McGivern | 2017-07-14 | 1 | -4/+8 | |
|\ | | | | | | | | | Fixes needed when GitLab sign-in is not enabled See merge request !12491 | |||||
| * | Fixes needed when GitLab sign-in is not enabled | Robin Bobbitt | 2017-07-13 | 1 | -4/+8 | |
| | | | | | | | | | | | | | | | | | | When sign-in is disabled: - skip password expiration checks - prevent password reset requests - don’t show Password tab in User Settings - don’t allow login with username/password for Git over HTTP requests - render 404 on requests to Profiles::PasswordsController | |||||
* | | Stop sanitizing user 'name' when inserting into db | Nathan Neulinger | 2017-07-12 | 1 | -1/+1 | |
|/ | | | | Add spec tests for encoding | |||||
* | refactor created at filter to use model scopes | James Lopez | 2017-07-07 | 1 | -0/+1 | |
| | ||||||
* | Rename ActiverecordSerialize cop | Yorick Peterse | 2017-07-06 | 1 | -1/+1 | |
| | | | | | This cop has been renamed to ActiveRecordSerialize to match the way "ActiveRecord" is usually written. | |||||
* | Added Cop to blacklist the use of `dependent:` | Yorick Peterse | 2017-07-06 | 1 | -30/+30 | |
| | | | | | | | | This is allowed for existing instances so we don't end up 76 offenses right away, but for new code one should _only_ use this if they _have_ to remove non database data. Even then it's usually better to do this in a service class as this gives you more control over how to remove the data (e.g. in bulk). | |||||
* | Merge branch '34078-allow-to-enable-feature-flags-with-more-granularity' ↵ | Robert Speicher | 2017-06-29 | 1 | -0/+1 | |
|\ | | | | | | | | | | | | | | | | | into 'master' Allow the feature flags to be enabled/disabled with more granularity Closes #34078 See merge request !12357 | |||||
| * | Rename FLippable to FeatureGate and make `flipper_group` and `user` mutually ↵ | Rémy Coutable | 2017-06-27 | 1 | -1/+1 | |
| | | | | | | | | | | | | exclusive Signed-off-by: Rémy Coutable <remy@rymai.me> | |||||
| * | Allow the feature flags to be enabled/disabled with more granularity | Rémy Coutable | 2017-06-27 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | This allows to enable/disable a feature flag for a given user, or a given Flipper group (must be declared statically in the `flipper.rb` initializer beforehand). Signed-off-by: Rémy Coutable <remy@rymai.me> | |||||
* | | Inserts exact matches of username, email and name to the top of the user ↵26125-match-username-on-search | Tiago Botelho | 2017-06-29 | 1 | -1/+10 | |
|/ | | | | search list | |||||
* | Provide hint to create a personal access token for Git over HTTP | Robin Bobbitt | 2017-06-26 | 1 | -1/+7 | |
| | | | | | | If internal auth is disabled and user is not an LDAP user, present the user with an alert to create a personal access token if he does not have one already. | |||||
* | Merge branch 'feature/add-new-services' into 'master' | Sean McGivern | 2017-06-26 | 1 | -7/+6 | |
|\ | | | | | | | | | Add additional user and email services See merge request !12125 | |||||
| * | fix spec failures | James Lopez | 2017-06-25 | 1 | -2/+2 | |
| | | ||||||
| * | refactor update user service not to do auth checks | James Lopez | 2017-06-23 | 1 | -3/+3 | |
| | | ||||||
| * | refactor emails service | James Lopez | 2017-06-23 | 1 | -2/+0 | |
| | | ||||||
| * | add missing user updates | James Lopez | 2017-06-23 | 1 | -3/+4 | |
| | | ||||||
| * | update missing email actions | James Lopez | 2017-06-23 | 1 | -1/+1 | |
| | | ||||||
| * | update to use emails destroy service | James Lopez | 2017-06-23 | 1 | -1/+1 | |
| | | ||||||
* | | Add User#full_private_access? to check if user has Private accesstc-refactor-projects-finder-init-collection | Toon Claes | 2017-06-23 | 1 | -0/+6 | |
|/ | | | | | | | | | | | | | In CE only the admin has access to all private groups & projects. In EE also an auditor can have full private access. To overcome merge conflicts, or accidental incorrect access rights, abstract this out in `User#full_private_access?`. `User#admin?` now only should be used for admin-only features. For private access-related features `User#full_private_access?` should be used. Backported from gitlab-org/gitlab-ee!2199 | |||||
* | Enable Style/DotPosition Rubocop :cop: | Grzegorz Bizon | 2017-06-21 | 1 | -28/+28 | |
| |