| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
When a user's notification email is set for a group, we
should use that for pipeline emails
|
| |
|
|
|
| |
- Background migration for changing null values to false
- Set false as default value for private_profile DB column
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of setting the name of the namespace to the user's username,
set it to the user's name.
This is more consistent with how we name the routes:
The route-name of a namespace is the human name of the routable. In
the case of a user-namespace, this is the owner's name.
When we change a user's name (both on create and update), we now also
update the namespace-name to the user's name. This will make sure that
if we also correctly update all the nested routes.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The introduction of the in-memory cache for application settings had a
side effect of making it harder to invalidate changes when the settings
occur. We now bypass the cache because it's possible the admin enabled
the usage ping, and we don't want to annoy the user again if they
already set the value.
To avoid causing significant load on the system, we add an extra check
to ensure the user is an admin. and we don't want to annoy the user
again if they already set the value. This is a bit of hack, but the
alternative would be to put in a more complex cache invalidation
step. Since this call only gets called in the uncommon situation where
the user is an admin and the only user in the instance, this shouldn't
cause too much load on the system.
|
| |
|
|
|
| |
Disabled password authentication for the users registered using
omniauth-ultraauth strategy
|
| |
|
|
| |
Signed-off-by: Utkarsh Gupta <guptautkarsh2102@gmail.com>
|
| |
|
|
|
|
| |
Udpated user_edit_profile_spec with time preferences
Minor update form fields
|
| |
|
|
|
|
|
| |
Removed the conditions added to
Project.with_feature_available_for_user, and moved to the
IssuableFinder. Now, we ensure that, in the projects retrieved
in the Finder, the user has enough access for the feature.
|
| |
|
|
| |
Model.new.attributes now also returns encrypted attributes.
|
| |
|
|
| |
- Update PO file
|
| |
|
|
|
| |
It's not needed anymore as we've replaced boolean `support_bot` with
enum `bot_type`.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add columns to store project creation settings
Add project creation level column in groups
and default project creation column in application settings
Remove obsolete line from schema
Update migration with project_creation_level column existence check
Rename migrations to avoid conflicts
Update migration methods
Update migration method
|
| |
|
|
|
| |
Truncate existing users names which exceed 128 characters
Include test for truncating users names
|
| |\
| |
| |
| |
| | |
Add dashboard scope for operations dashboard usage ping
See merge request gitlab-org/gitlab-ce!26727
|
| | | |
|
| |/ |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Align EmailValidator to validate_email gem implementation.
Closes #57352
See merge request gitlab-org/gitlab-ce!24971
|
| | |
| |
| |
| |
| |
| | |
Renamed EmailValidator to DeviseEmailValidator to avoid 'email:' naming collision with ActiveModel::Validations::EmailValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: regex.
|
| | |
| |
| |
| |
| | |
This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Ruby 2.6 introduced `Enumerable#filter`, which takes no arguments.
Attempting to call `filter` on an `ActiveRecord::Relation` with a scope
will fail with a `wrong number of arguments (given 1, expected 0)`
message because the `Enumerable#filter` implementation overrides the
delegated `ActiveRecord::Relation#filter` method.
To make Admin::UsersController compatible with Ruby 2.6, rename
`User.filter` to `User.filter_items`.
|
| |\ \
| | |
| | |
| | |
| | | |
BE Improve the GitHub and Gitea import feature table interface
See merge request gitlab-org/gitlab-ce!24606
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These are backend changes.
Use Vue for the import feature UI for "githubish"
providers (GitHub and Gitea).
Add "Go to project" button after a successful import.
Use CI-style status icons and improve spacing of the
table and its component.
Adds ETag polling to the github and gitea import
jobs endpoint.
|
| |/ / |
|
| |/ |
|
| |
|
|
|
|
|
|
|
| |
The columns 'Created on' and 'Last activity' have been
added to the admin -> users view.
Sorting options have also been added for last activity
and the search bar has been moved to match the issues
page.
|
| |
|
|
|
|
|
| |
Group guests will only be displayed merge requests to
projects they have a access level to, higher than Reporter.
Visible projects will still display the merge requests to Guests
|
| |\
| |
| |
| |
| | |
Add query method for id
See merge request gitlab-org/gitlab-ce!24386
|
| | | |
|
| |/
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\
| |
| |
| |
| |
| |
| | |
Resolve "Create a serializer to render issuables sidebar"
Closes #44984
See merge request gitlab-org/gitlab-ce!23379
|
| | | |
|
| |/
|
|
|
|
| |
- we now use the hierarchy class also for epics
- also rename supports_nested_groups? into supports_nested_objects?
- move it to a concern
|
| |
|
|
|
|
| |
This commit adds a name to each release, defaulting it to tag name,
keeps track of the SHA when a new release is created and tracks the
current user as release author.
|
| | |
|
| |
|
|
|
|
| |
Private commit emails were introduced in !22560, but some parts of
GitLab were not updated to take account of them. This commit adds
support in places that were missed.
|
| |
|
|
|
|
|
|
| |
The private commit email is automatically generated in the format:
id-username@noreply.HOSTNAME
GitLab instance admins are able to change the HOSTNAME portion,
that defaults to Gitlab's hostname, to whatever they prefer.
|
| |\
| |
| |
| |
| | |
Remove PersonalAccessTokensFinder#find_by method
See merge request gitlab-org/gitlab-ce!22617
|
| | |
| |
| |
| |
| |
| | |
find_by_token is overriden by TokenAuthenticatable which can be easily
missed or confused with #find_by(:token) defined by ActiveRecord. First
step for safer usage is to remove #find_by.
|
| | |
| |
| |
| |
| |
| | |
This moves the `where` in the `has_many :keys` association in Project to
the Key model. This allows EE to override this method, instead of
modifying the source code directly.
|
| |/
|
|
|
|
| |
This moves the `1.hour` constant used as the LDAP sync time to a
separate method. This allows EE to override this method using a module,
instead of directly modifying the source code.
|
| |\ |
|
| | | |
|
| | |
| |
| |
| |
| | |
[11.4] Fix Token lookup for Git over HTTP and registry authentication
See merge request gitlab/gitlabhq!2577
|
| |/ |
|
| |
|
|
| |
requests"
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This refactors the TodoService class according to our code reuse
guidelines. The resulting code is a wee bit more verbose, but it allows
us to decouple the column names from the input, resulting in fewer
changes being necessary when we change the schema.
One particular noteworthy line in TodoService is the following:
todos_ids = todos.update_state(state)
Technically this is a violation of the guidelines, because
`update_state` is a class method, which services are not supposed to use
(safe for a few allowed ones). I decided to keep this, since there is no
alternative. `update_state` doesn't produce a relation so it doesn't
belong in a Finder, and we can't move it to another Service either. As
such I opted to just use the method directly.
Cases like this may happen more frequently, at which point we should
update our documentation with some sort of recommendation. For now, I
want to refrain from doing so until we have a few more examples.
|
| | |
|
