summaryrefslogtreecommitdiff
path: root/app/helpers/notes_helper.rb
Commit message (Collapse)AuthorAgeFilesLines
* Support discussion locking in the backendJarka Kadlecova2017-09-141-0/+4
|
* WIP: refactor the first-contributor to Issuablemicael.bergeron2017-09-061-6/+1
| | | | | | | this will remove the need make N queries (per-note) at the cost of having to mark notes with an attribute this opens up the possibility for other special roles for notes
* fix #35161, add a first-time contributor badgemicael.bergeron2017-09-061-0/+5
| | | | | | | | | a new badge will be added when an user that doesn't yet have any merged merge request is discussing on either issues or merge requests that he created. this is indented for people to use extra care when discussing with a new contributor.
* Resolve outdated diff discussions on pushSean McGivern2017-09-061-0/+4
|
* Misc tweaksDouwe Maan2017-08-171-4/+4
|
* Convert ?full_data=1 -> ?view=full_dataSean McGivern2017-08-071-3/+5
|
* Merge branch 'fix-replying-to-commit-comment-in-mr-from-fork' into 'master'Douwe Maan2017-07-281-1/+5
|\ | | | | | | | | | | | | Fix replying to commit comments on merge requests created from forks Closes #31772 See merge request !13137
| * Fix replying to commit comments on MRs from forksSean McGivern2017-07-281-1/+5
| | | | | | | | | | | | A commit comment shows in the MR, but if the MR is from a fork, it will have a different project ID to the MR's target project. In that case, add an note_project_id param so that we can pick the correct project for the note.
* | Removed inline JS in shared HAML filesPhil Hughes2017-07-251-0/+10
|/
* Create and use project path helpers that only need a project, no namespaceDouwe Maan2017-07-051-9/+4
|
* Render add-diff-note button with server.Bryce Johnson2017-06-291-0/+12
| | | | | | | | | | This commit moves the rendering of the button back to the server, and shows/hides it using opacity rather than display. It also removes the transform applied to the button on hover (scale). Previously, both of these factors automatically triggered a reflow, which creates a performance bottleneck on pages with larger DOM size. MR: !12103
* Rename "Slash commands" to "Quick actions"Eric Eastwood2017-06-151-2/+2
| | | | | | | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070 Deprecate "chat commands" in favor of "slash commands" We looked for things like: - `slash commmand` - `slash_command` - `slash-command` - `SlashCommand`
* Added more actions and report as abuse to all notesLuke "Jared" Bennett2017-06-071-2/+6
|
* Fix replying to a commit discussion displayed in the context of an MRDouwe Maan2017-06-011-1/+1
|
* Enable the Style/TrailingCommaInLiteral copRémy Coutable2017-05-101-2/+2
| | | | | | Use the EnforcedStyleForMultiline: no_comma option. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Support comments for personal snippetsJarka Kadlecova2017-05-051-0/+43
|
* Allow commenting on older versions of the diff and comparisons between diff ↵dm-link-discussion-to-outdated-diffDouwe Maan2017-05-031-14/+10
| | | | versions
* Some code tweaksDouwe Maan2017-04-081-1/+1
|
* Fix views after rebaseDouwe Maan2017-04-081-2/+4
|
* Fix specs and make tweaksDouwe Maan2017-04-081-0/+2
|
* Add link to diff header tooDouwe Maan2017-04-081-3/+10
|
* Address review commentsDouwe Maan2017-04-051-1/+0
|
* Address review commentsDouwe Maan2017-04-051-17/+0
|
* Correctly display multiple separate discussions on the same diff lineDouwe Maan2017-04-051-16/+1
|
* Don't use original_discussion_idDouwe Maan2017-04-051-8/+4
|
* Fix some specsDouwe Maan2017-04-051-3/+1
|
* Add option to start a new discussion on an MRDouwe Maan2017-04-051-26/+23
|
* Fix note form hint showing slash commands supported for commitsRémy Coutable2016-09-201-0/+4
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Store discussion_id on Note for faster discussion lookup.Douwe Maan2016-08-171-4/+4
|
* Comment & resolve button no longer looks for can-resolve attributePhil Hughes2016-08-041-1/+1
| | | | Fixed some bugs when removing notes
* Merge branch 'master' into diff-line-comment-vuejsDouwe Maan2016-08-031-0/+4
|\ | | | | | | | | | | # Conflicts: # app/models/discussion.rb # db/schema.rb
| * Speedup DiffNote#active? on discussions, preloading noteables and avoid ↵Paco Guzman2016-08-021-0/+4
| | | | | | | | | | | | | | | | | | | | | | touching git repository to return diff_refs when possible - Preloading noteable we share the same noteable instance when more than one discussion refers to the same noteable. - Any other call to that object that is cached in that object will be for any discussion. - In those cases where merge_request_diff has all the sha stored to build a diff_refs get that diff_refs using directly those sha instead accessing to the git repository to first get the commits and later the sha.
* | Moved most of the data handling into discussion & notes modelsPhil Hughes2016-07-291-1/+1
| | | | | | | | | | Reduced some duplicated code with compiling components Fixed bug with resolve button tooltip not updating after resolving discussion
* | Merge branch 'master' into diff-line-comment-vuejsDouwe Maan2016-07-281-8/+7
|\ \ | |/ | | | | | | # Conflicts: # db/schema.rb
| * Optimize maximum user access level lookup in loading of notesStan Hu2016-07-261-8/+7
| | | | | | | | | | | | | | | | NotesHelper#note_editable? and ProjectTeam#human_max_access currently take about 16% of the load time of an issue page. This MR preloads the maximum access level of users for all notes in issues and merge requests with several queries instead of one per user and caches the result in RequestStore.
* | Comment & resolve button text is done through VueJSPhil Hughes2016-07-261-1/+1
| |
* | Use sha1 of discussion ID.Douwe Maan2016-07-251-2/+2
| |
* | Added resolve button to discussionsPhil Hughes2016-07-241-4/+2
|/ | | | Top count displays how many resolved discussions
* Add Discussion model to represent MR/diff discussiondiscussion-modelDouwe Maan2016-07-201-27/+10
|
* Do not set `@use_legacy_diff_notes`Douwe Maan2016-07-071-1/+1
|
* Fix behavior around MRs that need legacy diff notesDouwe Maan2016-07-071-21/+28
|
* Merge branch 'master' into faster-diffsDouwe Maan2016-07-071-23/+55
|\ | | | | | | | | | | | | | | | | # Conflicts: # app/helpers/notes_helper.rb # app/views/projects/diffs/_line.html.haml # app/views/projects/diffs/_parallel_view.html.haml # app/views/projects/diffs/_text_file.html.haml # features/steps/shared/diff_note.rb
| * Display new diff notes and allow creation through the web interfaceDouwe Maan2016-07-061-11/+45
| |
| * Extract parts of LegacyDiffNote into DiffOnNote concern and move part of ↵Douwe Maan2016-07-061-4/+3
| | | | | | | | responsibility to other classes
| * Style diff and blob file headers the same wayDouwe Maan2016-07-061-0/+10
| |
* | Simplify HAML code using unless condition and nestingPaco Guzman2016-07-061-0/+21
| | | | | | Extract diff line data attributes to helper methods
* | Diffs will create button/diff form on demand no on server sideJacob Schatz2016-07-061-18/+2
|/
* Be explicit which project and user ID are memoizedStan Hu2016-06-291-4/+6
|
* Memoize the maximum access level for the author of notesStan Hu2016-06-291-0/+8
| | | | | | | In #19273, we saw that retrieving ProjectTeam#human_max_access for each note takes the bulk of the time when rendering certain issues or merge requests. We observe that most of the comments in an issue are typically done by the same users. This MR memoizes the max access level by user ID.
* Extract LegacyDiffNote out of NoteDouwe Maan2016-05-131-16/+13
|