summaryrefslogtreecommitdiff
path: root/app/controllers
Commit message (Collapse)AuthorAgeFilesLines
* Improve performance for merge_request#show pageDmitriy Zaporozhets2015-06-241-0/+2
| | | | | | | | | | * store @participants in variable * store result of subscribed? call into variable In total it reduce amount of SQL queries for merge_request with 10 comments/participants twice. Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Improve performance for issue#show pageDmitriy Zaporozhets2015-06-241-0/+1
| | | | | | | | | * store @participants in variable * store result of subscribed? call into variable In total it reduce amount of SQL queries for issue with 10 comments/participants twice. Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Merge branch 'admin-edit-identities' into 'master'Dmitriy Zaporozhets2015-06-232-1/+51
|\ | | | | | | | | | | | | | | | | | | Admin can see, edit and remove user identities Related to #1415 and https://dev.gitlab.org/gitlab/gitlabhq/issues/2224 Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> See merge request !843
| * Fix admin identities codeDmitriy Zaporozhets2015-06-231-1/+1
| | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * Address review commentsDmitriy Zaporozhets2015-06-221-7/+5
| | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * Merge branch 'master' into admin-edit-identitiesDmitriy Zaporozhets2015-06-225-7/+10
| |\ | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> Conflicts: app/views/admin/users/show.html.haml
| * | Refactor admin user pageDmitriy Zaporozhets2015-06-221-1/+10
| | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | Move identities list to own controller actionDmitriy Zaporozhets2015-06-191-4/+8
| | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | Add ability for admin to edit user identityDmitriy Zaporozhets2015-06-191-4/+22
| | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | Admin can see and remove user identitiesDmitriy Zaporozhets2015-06-191-0/+21
| | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | Fix error when deleting a user who has projectsStan Hu2015-06-232-2/+2
| |/ |/| | | | | | | Closes #1856 Closes https://github.com/gitlabhq/gitlabhq/issues/9394
* | Merge branch 'remove_unused_except' into 'master'Dmitriy Zaporozhets2015-06-221-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | projects doesn't seem to be a valid action in this controller Hi, This is just a tiny change. Let me know if I'm doing it wrong... Eaden See merge request !696
| * | projects doesn't seem to be a valid action in this controllerEaden2015-05-161-2/+2
| | |
* | | Merge branch 'rs-dev-issue-2355' into 'master'Dmitriy Zaporozhets2015-06-221-1/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MergeRequest#show performance improvements This is a first pass on improving the performance of the `MergeRequests#show` page. Notable changes: - The "Commits" tab is loaded lazily, so the initial page load should be much faster for MRs with many commits. - Relative timestamps via `timeago` are only initialized once per load instead of `O(n^2)`. This greatly improves frontend rendering times for a large number of commits. - Refactored `User.find_for_commit` to use a single ARel-generated SQL query instead of the old method which resulted in one query, and could result in up to three. See merge request !838
| * | | Load the Merge Request > Commits tab lazilyRobert Speicher2015-06-171-1/+4
| | | |
* | | | Use User#two_factor_enabled instead of otp_required_for_loginrs-dev-issue-2415Robert Speicher2015-06-193-4/+4
| |_|/ |/| |
* | | Merge branch 'fix-labels-permisssion-check' into 'master'Douwe Maan2015-06-182-7/+2
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | Fix 403 Access Denied error messages when accessing Labels section in a project This would occur if the project's issues or merge requests features were disabled. The change in 9bcd36396b9 caused `can?(current_user, :read_merge_request, project)` to be false if the merge request feature were disabled, so `authorize_labels!` needs to be changed accordingly. Closes #1813 See merge request !836
| * | Fix 403 Access Denied error messages when accessing Labels section in a ↵Stan Hu2015-06-182-7/+2
| | | | | | | | | | | | | | | | | | project that has MRs disabled but issues enabled Closes #1813
* | | Merge branch 'rs-dev-issue-2373' into 'master'Dmitriy Zaporozhets2015-06-171-1/+5
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | Prefix 2FA issuer with the GitLab host (e.g., 'dev.gitlab.org') https://dev.gitlab.org/gitlab/gitlabhq/issues/2373 See merge request !821
| * | Prefix 2FA issuer with the GitLab host (e.g., 'dev.gitlab.org')rs-dev-issue-2373Robert Speicher2015-06-161-1/+5
| | |
* | | Support commenting on a diff in side-by-side viewStan Hu2015-06-161-2/+15
|/ / | | | | | | Closes https://github.com/gitlabhq/gitlabhq/issues/9283
* | Refactor RootControllerRobert Speicher2015-06-131-2/+12
| |
* | Spec the failure cases for PreferencesController#updateRobert Speicher2015-06-131-4/+9
| |
* | Add RootControllerRobert Speicher2015-06-131-0/+18
| | | | | | | | | | | | This controller is now the target for `root_url`. It sub-classes DashboardController so we can render the old default without a redirect if the user hasn't customized their dashboard location.
* | Add `dashboard` attribute to User modelRobert Speicher2015-06-131-0/+1
| |
* | Remove js handler from Profiles#updateRobert Speicher2015-06-131-1/+0
| | | | | | | | | | It was only used for the appearance live updating, which is now handled by Profiles::Preferences#update
* | Move the "Design" templates and logic to PreferencesRobert Speicher2015-06-132-8/+19
| |
* | Add Profiles::PreferencesControllerRobert Speicher2015-06-131-0/+29
| |
* | Merge branch 'feature-session-expire-seconds-ui' into 'master'Douwe Maan2015-06-121-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add session expiration delay configuration through UI application Setting is accessible by the administrator through the UI and defaults to 1 week (the current setting) Answers the following suggestions: * http://feedback.gitlab.com/forums/176466-general/suggestions/6210719-make-session-length-configurable * http://feedback.gitlab.com/forums/176466-general/suggestions/6730512-automatic-logout-after-a-time-being-idle See merge request !774
| * | session_expire_seconds => session_expire_delaythemaze752015-06-101-1/+1
| | | | | | | | | | | | | | | delay is in seconds more legible code in session_store Added `GitLab restart required` help block to session_expire_delay
| * | Add session expiration delay configuration through UI applicationEric Maziade2015-06-051-0/+1
| | | | | | | | | settings
* | | Merge branch 'refactor-mr-widget' into 'master'Dmitriy Zaporozhets2015-06-121-12/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor accept merge request widget * make each case a simple view * separate merge request JS from merge request accept widget JS Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> See merge request !799
| * | | Improve variables in mr widgetDmitriy Zaporozhets2015-06-111-12/+1
| | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | Fix rubocopDmitriy Zaporozhets2015-06-111-2/+1
| | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | Extract merge request widget JS to separate classDmitriy Zaporozhets2015-06-111-4/+0
| | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | Refactor merge request widget step 2Dmitriy Zaporozhets2015-06-111-1/+9
| | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | Merge pull request #9371 from zenati/patch-2Dmitriy Zaporozhets2015-06-111-1/+1
|\ \ \ \ | |/ / / |/| | | An `in_namespace` scope is already present
| * | | An `in_namespace` scope is already presentzenati2015-06-091-1/+1
| | | |
* | | | Merge branch 'move_project_members_link' into 'master'Dmitriy Zaporozhets2015-06-091-2/+0
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move Project Members link from Settings to main menu. Addresses #2278. See merge request !1846
| * | | | Move Project Members link from Settings to main menu.Nicolas2015-06-091-2/+0
| |/ / / | | | | | | | | | | | | Addresses #2278.
* | | | Merge branch 'ldap-remember-me' into 'master'Dmitriy Zaporozhets2015-06-091-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | Add "Remember me" checkbox to LDAP signin form. Addresses internal issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2127. See merge request !772
| * | | Add "Remember me" checkbox to LDAP signin form.ldap-remember-meDouwe Maan2015-06-051-1/+1
| |/ /
* | | Merge branch 'refactor-web-editor' into 'master'Dmitriy Zaporozhets2015-06-051-30/+30
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor web editor * fix problem with editing non-master branch * before commit make sure branch exists * dont allow user change file in one branch and commit to another existing branch * remove a lot of code duplication * remove outdated statellite errors Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> Fixes #1761 See merge request !773
| * | | Refactor web editorrefactor-web-editorDmitriy Zaporozhets2015-06-051-30/+30
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | * fix problem with editing non-master branch * before commit make sure branch exists * dont allow user change file in one branch and commit to another existing branch * remove a lot of code duplication * remove outdated statellite errors Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | Show warning when a comment will add 10 or more people to the discussion.Douwe Maan2015-06-051-1/+11
|/ /
* | Remove show actions from Admin and Project DeployKeysRobert Speicher2015-06-032-10/+1
| |
* | Merge branch 'repo-remove' into fix-group-removeDmitriy Zaporozhets2015-06-031-10/+7
|\ \ | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> Conflicts: spec/features/projects_spec.rb
| * | Move repository when project is removedDmitriy Zaporozhets2015-06-031-10/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ths commit does next: * When we remove project we move repository to path+deleted.git * Then we schedule removal of path+deleted with sidekiq * If repository move failed we abort project removal This should help us with NFS issue when project get removed but repository stayed. The full explanation of problem is below: * rm -rf project.git * rm -rf removes project.git/objects/foo * NFS server renames foo to foo.nfsXXXX because some NFS client (think * Unicorn) still has the file open * rm -rf exits, but project.git/objects/foo.nfsXXX still exists * Unicorn closes the file, the NFS client closes the file (foo), and the * NFS server removes foo.nfsXXX * the directory project.git/objects/ still exists => problem So now we move repository and even if repository removal failed Repository directory is moved so no bugs with project removed but repository directory taken. User still able to create new project with same name. From administrator perspective you can easily find stalled repositories by searching `*+deleted.git` Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | Wrap group removal into serviceDmitriy Zaporozhets2015-06-032-2/+2
|/ / | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | Merge branch 'feature/sso_integration' into 'master'Douwe Maan2015-06-021-0/+16
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Add an option to automatically sign-in with an Omniauth provider Split of !669 as requested This is useful when integrating with existing SSO environments and we want to use a single Omniauth provider for all user authentication. See merge request !723