| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
| |
This removes the create_wiki permission check from the history
controller, allowing show and history to have the same level of
permissions.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/29528
|
| |
|
|
|
|
| |
Add cr remarks
Add cr remarks
|
| |\
| |
| |
| |
| |
| |
| | |
Remove `if:` argument in before_action and alike when `only:` is also used
Closes #55564
See merge request gitlab-org/gitlab-ce!24412
|
| | |
| |
| |
| |
| |
| | |
Closes #55564
This is first discovered in #54739 (comment 122609857) that if both if: and only:
are used in a before_action or after_action or alike, if: is completely ignored.
|
| |/
|
|
|
|
|
| |
The actions tracked in the web IDE are:
- creation of commits
- creation of merge requests
- projects loaded
|
| | |
|
| |
|
|
|
| |
This introduces the single stat chart component aside from
the area chart component
|
| |\
| |
| |
| |
| | |
Prepare cycle analytics for group level
See merge request gitlab-org/gitlab-ce!30356
|
| | | |
|
| | | |
|
| |/
|
|
|
|
|
|
| |
- Remove `FeatureConstrainer` call wrapping api endpoint
- Remove `Feature.enabled?(:graphql)` conditionals in back and frontend
- Modify graphql test to be graphql flag agnostic
- Remove api routing spec
- Remove frontend feature flag via `gon`
|
| |
|
|
|
|
|
| |
We can now share project so that we don't have to load project twice.
Also, this extracts non-relevant logic out of Deployment.
Update DeploymentsController accordingly
|
| |\
| |
| |
| |
| |
| |
| | |
Create private merge requests in forks
Closes #58583
See merge request gitlab-org/gitlab-ce!29984
|
| | |
| |
| |
| | |
https://gitlab.com/gitlab-org/gitlab-ce/issues/58583
|
| |/
|
|
|
|
|
|
|
| |
This MR introduces tracking of the `rebase_jid` for merge requests. As
with `merge_ongoing?`, `rebase_in_progress?` will now return true if a
rebase is proceeding in sidekiq.
After one release, we should remove the Gitaly-based lookup of rebases.
It is much better to track this kind of thing via the database.
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
This new attribute is optional and used when set instead of the default
format `gitlab+deploy-token-#{id}`.
Empty usernames will be saved as null in the database.
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/50228.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Includes changes to the Vue container registry component to support
the display of an empty message and error message when invalid
characters are found in the group, project or branch name.
repositories/index.html.haml has been changed to remove the content
and place into Vue component.
|
| | |\
| | |
| | |
| | |
| | | |
Support creating an MR/branch on a fork from an issue
See merge request gitlab-org/gitlab-ce!29831
|
| | | |
| | |
| | |
| | |
| | | |
If user can update an issue under the specified confidential
issue project, should be able to find the project.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When `confidential_issue_project_id` is set and the issue is
under that project, create the a note about branch creation
in that project. If not, do nothing.
When creating `new_merge_request` system note, set the project
where the MR will be referenced from so it'll be linked to when
the MR is created in another project.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Accept a `confidential_issue_project_id` param which will
be used for the system note target.
This also includes some refactoring on the spec to use
shared examples.
|
| | | | |
|
| | |\ \
| | |/
| |/|
| | |
| | | |
Add endpoint for fetching diverging commit counts
See merge request gitlab-org/gitlab-ce!29802
|
| | | |
| | |
| | |
| | | |
Extract diverging_commit_counts into a service class
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Extract MR's widget into a separate request
Closes #62723
See merge request gitlab-org/gitlab-ce!29979
|
| | | |/
| | |
| | |
| | |
| | |
| | | |
This commits extracts /merge_requests/1.json?serializer=widget
Into a separate /merge_requests/1/widget.json endpoint
This will allow to use caching for this request
|
| |\ \ \
| |/ /
|/| | |
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
into 'master'
Guests can know whether merge request template name exists or not
See merge request gitlab/gitlabhq!3117
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously, if a user was a guest member of a private project, they
could access the merge request template as we were not checking
permission-levels of the user.
When a issue template is asked for, the user must have :read_issue for
the project; or :read_merge_request when a merge request template is
asked for.
We also now rescue_from FileNotFoundError and handle as 404. This is
because RepoTemplateFinder can raise a FileNotFoundError exception,
which Rails previously handled as a 500.
Handling these in a way that is consistent with
ActiveRecord::RecordNotFound exceptions, within controllers that
inherit from Projects::ApplicationController at least, and returning a
404.
https://gitlab.com/gitlab-org/gitlab-ce/issues/54943
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Enable Gitaly ref caching for SearchController
See merge request gitlab-org/gitlab-ce!30105
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As we noticed in
https://gitlab.com/gitlab-org/gitlab-ce/issues/56627#note_185828742,
clicking on the "Issues" tab often requests the same reference in
rendering Markdown.
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
Move Multiple Issue Boards for Projects to Core
See merge request gitlab-org/gitlab-ce!29757
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Refactor code to allow multiple issue boards management for projects
in CE
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Fetch commit message with logs_tree endpoint
See merge request gitlab-org/gitlab-ce!29796
|
| | | |_|/
| |/| | |
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
Resolve "500 error when forking via the web IDE button"
See merge request gitlab-org/gitlab-ce!29909
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The check for continue_params&.key?(:to) in Projects::ImportsController
caused an exception in redirect_to if this key contained a nil value.
Since url_for won't add any params for an empty hash, we can just return
that in continue_params if params[:continue] isn't present, and simplify
the code in the controllers to check for the values we actually want to
use.
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| | |
On all the issue lists -- Group, Project and Dashboard -- this
change adds a new option for managing the lists.
"Manual Ordering" option is added which when flipped on will allow
an user to drag and drop issues around to create a relative ordering
among them.
|
| |\ \
| | |
| | |
| | |
| | | |
Automatically update MR merge-ref along merge status
See merge request gitlab-org/gitlab-ce!29569
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This couples the code that transitions the `MergeRequest#merge_status`
and refs/merge-requests/:iid/merge ref update.
In general, instead of directly telling `MergeToRefService` to update
the merge ref, we should rely on `MergeabilityCheckService` to keep
both the merge status and merge ref synced. Now, if the merge_status is
`can_be_merged` it means the merge-ref is also updated to the latest.
We've also updated the logic to be more systematic and less user-based.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This eliminates many potential duplicate FindCommit RPCs for the same
ref, which often occurs in the RelativeLinkFilter#current_commit call.
On the GitLab 12.0 release post, for example, this would save close to
400 RPC calls.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Add ability to reorder issues
See merge request gitlab-org/gitlab-ce!29012
|
| | | | |
| | | |
| | | |
| | | | |
to support manual sorting on the frontend
|
| | |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Adds enum certificate_source to pages_domains table
with default manually_uploaded
Mark certificates as 'gitlab_provided'
if the were obtained through Let's Encrypt
Mark certificates as 'user_provided' if they were uploaded through
controller or api
Only show private key in domain edit form if it is 'user_provided'
Only show LetsEncrypt option if is enabled by application settings
(and feature flag)
Refactor and fix some specs to match new logic
Don't show Let's Encrypt certificates as well
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commits adds support for metrics dashboards
for embedding. If the flag 'embedded' is provided
to the environments/id/metrics_dashboard endpoint,
the response will be suitable for embedding in
issues or other content.
This is a precursor for support for embedding
metrics in GFM.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This adds missing preloads, and introduces
additional n+1 matcher to look for
duplicates.
|
| |/ /
| |
| |
| |
| |
| |
| |
| | |
This commit adds
- feature specs
- to test the ability of a user with "developer" permission
to delete tags in repositories.
- documentation
|
| | |
| |
| |
| | |
This brings the API permissions in line with the UI permissions
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Opts to cache a full list of cached dashboards
to better manage removing items from the cache.
This also allows dashboards to be stored in the
cache that don't necessarily correspond to a
single dashboard yml.
|
