summaryrefslogtreecommitdiff
path: root/app/controllers/help_controller.rb
Commit message (Collapse)AuthorAgeFilesLines
* Use Rack::Utils.clean_path_info instead of copy-pasted version.Vasiliy Ermolovich2019-04-041-32/+1
|
* Update RE used to prefix links with /help/Frank Sauerburger2019-02-121-3/+2
| | | | | | Update the regular expression in the help controller used to prefix relative links on the help page with /help/. As suggested by @rymai, the look-ahead pattern to detect external links is simplified from `[a-zA-Z0-9.+-]` to `\w`.
* Fix broken links on help pageFrank Sauerburger2019-02-111-3/+5
| | | | | | | | | | | | Update the help controller to correctly handle relative links on the help pages when the relative link is before an external link on the same line in the markdown file. Test cases have been implement to check for - relative links before external link on same line, - HTTPS in query part of link, - URLs without '//' and - protocol-relative links.
* Enable frozen string in app/controllers/**/*.rbrepo-forks/gitlab-ce-frozen-string-app-controllergfyoung2018-09-181-0/+2
| | | | | | | | | | | | Enables frozen string for the following: * app/controllers/*.rb * app/controllers/admin/**/*.rb * app/controllers/boards/**/*.rb * app/controllers/ci/**/*.rb * app/controllers/concerns/**/*.rb Partially addresses #47424.
* Enable RuboCop Style/RegexpLiteralTakuya Noguchi2018-02-011-1/+1
|
* Added ssh fingerprint, gitlab ci and pages information in an instance ↵Francisco Lopez2017-10-251-0/+4
| | | | | | configuration page Closes #25142
* Do not show YAML frontmatter for doc pages under /helpAchilleas Pipinellis2017-09-191-2/+8
| | | | | | | | | | | | We recently started adding YAML frontmatter in docs so that we can show more information, but that only works for the docs portal at docs.gitlab.com. For example, we want to add a last_updated entry https://gitlab.com/gitlab-org/gitlab-ce/issues/37677 Whereas this is useful for the docs portal, it looks ugly for docs under /help.
* Don't perform Devise trackable updates on blocked User recordsrs-warden-blocked-usersRobert Speicher2017-02-101-1/+1
|
* Fix URL rewritting in the Help section25199-fix-broken-urls-in-help-pageRémy Coutable2016-12-011-2/+4
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Fix broken external links in help/index.htmlDavid Wagner2016-11-201-3/+3
| | | | | | | | | | | An external link was recently added but was broken because 'https://gitlab.com/help/' was prepended to every link in the page. Since no link in the main help readme begins with "help" and since doing so wouldn't make sense, the substitution conditionaly prepending "help" can be simplified and reused. Signed-off-by: David Wagner <david@marvid.fr>
* fix error links in help pageFu Xu2016-11-121-2/+2
|
* Replace reject_blocked with reject_blocked! in callbacks.rename-undefined-methodsConnor Shea2016-07-271-1/+1
| | | | | | | | | | In Rails 4.2 and below, skipping callbacks (skip_before_action, skip_after_action, etc.) that use methods which do not exist will not throw any errors. On the other hand, Rails 5 does. See https://github.com/rails/rails/pull/19029 After testing with Rails 5 I noticed there are some methods that don't actually exist (because they were renamed, usually), this fixes a few instances of those. reject_blocked! was introduced in c9def945d4222eeb8026a0311495259bf99267a1, I can't find any references to reject_blocked ever existing.
* Remove VideoJS and clean the integrationRémy Coutable2016-07-201-1/+1
| | | | | | | | | Handle videos in: - MD preview in notes: commit, issue/MR, MR diff - New notes in: commit, issue/MR, MR diff - Persisted notes in: commit, issue/MR, MR diff Signed-off-by: Rémy Coutable <remy@rymai.me>
* Clean path infoConnor Shea2016-07-111-1/+1
|
* Update the help_page_path route to accept paths directly instead of using ↵Connor Shea2016-07-111-6/+4
| | | | parameters.
* Simplify random user generation.Jacob Schatz2016-04-161-6/+1
|
* Make a user available for the user variablefivehundred_on_ui_helpJacob Schatz2016-04-161-0/+6
|
* Simplify help path prefixingrs-fix-help-linksRobert Speicher2015-09-231-17/+4
|
* Prevent double-prefixing of help page pathsRobert Speicher2015-09-221-0/+18
| | | | | | | | Prior, because the link "api/README.md" was matched twice, the first link became "help/help/api/README.md". Now we do a negative lookahead to make sure the link doesn't start with `help/`. This fix is still not ideal, see TODO note.
* Make Help accessible for guests.Douwe Maan2015-09-081-0/+2
|
* Use File.join instead of Rails.root.join in HelpControllerRobert Speicher2015-08-181-2/+4
|
* Add helpers for header title and sidebar, and move setting those from ↵Douwe Maan2015-05-011-6/+1
| | | | controllers to layouts.
* Set head panel title of help section.Douwe Maan2015-04-301-0/+7
|
* Add a page title to every page.Douwe Maan2015-04-301-4/+4
|
* Loosen help page parameter constraints for categoryRobert Speicher2015-04-151-1/+1
|
* Re-fix image rendering for help pagesRobert Speicher2015-04-151-6/+36
|
* Revert "Fix and improve help rendering"Robert Speicher2015-04-151-23/+7
| | | | This reverts commit d365004e684e98459061fcd5fbaf9bea880934a8.
* Add explanation to HelpController#clean_path_info.Douwe Maan2015-04-141-3/+16
|
* Fix directory traversal vulnerability around help pages.Douwe Maan2015-04-101-1/+19
|
* Fix and improve help renderingSullivan SENECHAL2015-04-031-5/+23
|
* Add GitLab UI development kitDmitriy Zaporozhets2015-03-081-0/+3
|
* Remove garbage and apply wiki styleDmitriy Zaporozhets2014-06-141-11/+0
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* render items from docJob van der Voort2014-05-291-0/+11
|
* Show shotcut dialog on ?Dmitriy Zaporozhets2013-06-301-0/+3
|
* Improve api docsDmitriy Zaporozhets2013-06-061-0/+11
|
* UI: add new button, top panel restyle etcDmitriy Zaporozhets2012-01-181-0/+4