| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Fix Error 500 when creating global milestones with Unicode characters | Stan Hu | 2015-12-05 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two issues: 1. The constraints in the resources were incorrect. Here's what it was before: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` In this case, id is actually the title of the milestone, which can be anything at the moment. After: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` 2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like: ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]): This change uses the babosa library to create a better slug, which surprisingly isn't actually used by the global milestone controllers. Instead, they use the title passed as a query string for some reason. Closes https://github.com/gitlabhq/gitlabhq/issues/9881 Fix constraints | ||||
| * | Use project member abilities more extensively | Douwe Maan | 2015-11-17 | 1 | -15/+15 |
| | | |||||
| * | Fix removing avatar for group | Dmitriy Zaporozhets | 2015-11-16 | 1 | -1/+1 |
| | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
| * | Group masters should be able to create/close milestones | Dmitriy Zaporozhets | 2015-11-16 | 1 | -1/+1 |
| | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
| * | Refactor global and group milestones logic | Dmitriy Zaporozhets | 2015-11-16 | 4 | -54/+27 |
| | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
| * | Create milestones in the group | Dmitriy Zaporozhets | 2015-11-16 | 1 | -5/+31 |
| | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
| * | Use before_actions | Douwe Maan | 2015-07-31 | 2 | -4/+7 |
| | | |||||
| * | Add specific ability for managing group members | Douwe Maan | 2015-07-28 | 1 | -0/+7 |
| | | |||||
| * | User should be able to leave group. If not - show him proper message | Dmitriy Zaporozhets | 2015-05-29 | 1 | -1/+5 |
| | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
| * | Add helpers for header title and sidebar, and move setting those from ↵ | Douwe Maan | 2015-05-01 | 1 | -7/+1 |
| | | | | | controllers to layouts. | ||||
| * | Remove an old determine_layout call. | Douwe Maan | 2015-04-30 | 1 | -2/+0 |
| | | |||||
| * | Add a page title to every page. | Douwe Maan | 2015-04-30 | 3 | -11/+6 |
| | | |||||
| * | Fixed the Rails/ActionFilter cop | Jeroen van Baarsen | 2015-04-20 | 2 | -7/+7 |
| | | | | | Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com> | ||||
| * | Follow newline guidelines. | Douwe Maan | 2015-04-14 | 1 | -2/+5 |
| | | |||||
| * | Consistently use "invitation" rather than "invite" in text. | Douwe Maan | 2015-04-14 | 1 | -2/+2 |
| | | |||||
| * | Use notice flash type rather than nonexistent info. | Douwe Maan | 2015-04-14 | 1 | -2/+2 |
| | | |||||
| * | Let membership invitations be resent. | Douwe Maan | 2015-04-14 | 1 | -0/+11 |
| | | |||||
| * | Only show invited users to people who can admin group. | Douwe Maan | 2015-04-14 | 1 | -0/+1 |
| | | |||||
| * | Track who created a group or project member. | Douwe Maan | 2015-04-14 | 1 | -1/+1 |
| | | |||||
| * | Rename manage_group ability to admin_group for consistency with project. | Douwe Maan | 2015-04-14 | 2 | -2/+2 |
| | | |||||
| * | Move group leave action from dashboard/groups to groups/group_members. | Douwe Maan | 2015-03-15 | 1 | -0/+11 |
| | | |||||
| * | Move group members index from `/members` to `/group_members`. | Douwe Maan | 2015-03-15 | 2 | -4/+37 |
| | | |||||
| * | Use `group_member` instead of `users_group` or `membership`. | Douwe Maan | 2015-03-15 | 1 | -3/+3 |
| | | |||||
| * | Use same constant for amount of items per page | Dmitriy Zaporozhets | 2015-03-12 | 1 | -1/+1 |
| | | |||||
| * | group controller refactoring | Valery Sizov | 2015-03-12 | 2 | -7/+11 |
| | | |||||
| * | Add dashboard milestones. | Douwe Maan | 2015-03-03 | 1 | -5/+5 |
| | | |||||
| * | Add tests for remove group member feature in admin area | Dmitriy Zaporozhets | 2014-10-20 | 1 | -0/+1 |
| | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
| * | Fix STI+polymorphic for Group <-> GroupMember | Dmitriy Zaporozhets | 2014-09-14 | 1 | -0/+48 |
| | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
| * | Improve performance, ordering and pagination for group milestones. | Marin Jankovski | 2014-07-04 | 1 | -10/+12 |
| | | |||||
| * | Add feature tests for group milestone. | Marin Jankovski | 2014-06-30 | 1 | -1/+1 |
| | | |||||
| * | Show all issues and merge requests that could be considered opened or ↵ | Marin Jankovski | 2014-06-30 | 1 | -2/+0 |
| | | | | | closed, includes reopened and merged. | ||||
| * | Correct authorization for group milestones. | Marin Jankovski | 2014-06-30 | 1 | -0/+6 |
| | | |||||
| * | Move milestone link in group head, 2 column milestone for MR and issues. | Marin Jankovski | 2014-06-30 | 1 | -2/+2 |
| | | |||||
| * | Start building group milestone show page. | Marin Jankovski | 2014-06-30 | 1 | -2/+4 |
| | | |||||
| * | Get one group milestone based on milestone title. | Marin Jankovski | 2014-06-30 | 1 | -9/+13 |
| | | |||||
| * | Close and reopen group milestones. | Marin Jankovski | 2014-06-30 | 1 | -3/+26 |
| | | |||||
| * | Filter group milestones. | Marin Jankovski | 2014-06-30 | 1 | -0/+10 |
| | | |||||
| * | Move group milestone processing from service to model. | Marin Jankovski | 2014-06-30 | 1 | -2/+1 |
| | | |||||
| * | Create group milestones service. | Marin Jankovski | 2014-06-30 | 1 | -0/+2 |
| | | |||||
| * | Show title of milestone. | Marin Jankovski | 2014-06-30 | 1 | -0/+3 |
| | | |||||
| * | Add group milestones routes and controller. | Marin Jankovski | 2014-06-30 | 1 | -0/+7 |
| | | |||||
| * | added group avatars | Steven Thonus | 2014-01-28 | 1 | -0/+12 |
