summaryrefslogtreecommitdiff
path: root/app/assets/javascripts/notes.js
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch '26282-autosize-js-memory-leak' into 'master' Alfredo Sumaran2017-01-301-3/+2
|\ | | | | | | | | | | | | Resolve "ba-resize memory leak" Closes #26282 See merge request !8412
| * remove ba-resize26282-autosize-js-memory-leakLuke "Jared" Bennett2017-01-201-3/+2
| | | | | | | | | | | | refactor js-autosize code now that ba-resize is gone Added specs
* | Flag multiple empty lines in eslint, fix offenses.newline-eslint-ruleBryce Johnson2017-01-241-21/+0
|/
* Merge branch 'simple-eslint-fixes' into 'master' Fatih Acet2017-01-191-7/+5
|\ | | | | | | | | Simple eslint fixes See merge request !8536
| * resolve all parseInt radix eslint violationsMike Greiling2017-01-181-2/+2
| |
| * resolve all x-spacing and no-spaced-x eslint violationsMike Greiling2017-01-181-2/+2
| |
| * resolve all indent eslint violationsMike Greiling2017-01-181-1/+1
| |
| * resolve all padded-blocks eslint violationsMike Greiling2017-01-181-3/+1
| |
| * resolve all semi and no-extra-semi eslint violationsMike Greiling2017-01-181-3/+3
| |
* | Address MR commentsJarka Kadlecova2017-01-131-1/+1
| |
* | refresh merge widget after using /merge commandJarka Kadlecova2017-01-111-0/+12
|/
* Fixed edit form authenticity_token call failing the testsfixed-edit-form-failing-testPhil Hughes2017-01-061-1/+3
|
* Fix review comments.single-edit-comment-widget-2Fatih Acet2017-01-051-2/+3
|
* Review fixes.Fatih Acet2017-01-041-6/+5
|
* Use gl.utils.isInViewport and improve gl.utils.animateToElement.Fatih Acet2017-01-041-9/+7
|
* Hide edit warning element when form reverted.Fatih Acet2017-01-041-0/+1
|
* Fix single note edit form specs.Fatih Acet2017-01-041-3/+3
|
* Separate edit form in Changes and Discussions tab.Fatih Acet2017-01-041-10/+30
| | | | | | if we are in the Merge Requests page, this change will clone existing note-edit-form and add a mr-discussion-edit-form class to cloned element so we will have two note-edit-form in place. One for Discussions tab one for Changes tab. For MR page, we basically need two note-edit-form because you may want to edit your comment in both tabs at the same time and we shouldn't remove or discard note-edit-form in other tab.
* Fix task list for single edit note widget changes.Fatih Acet2017-01-041-17/+36
|
* Fix single comment edit form issues.Fatih Acet2017-01-041-22/+20
|
* Refactor discussion edit widget to have only one at a time.Fatih Acet2017-01-041-38/+68
|
* Merge branch 'katex-math' into 'master' Sean McGivern2016-12-151-3/+3
|\ | | | | | | | | | | | | Render math in Asciidoc and Markdown with KaTeX using code blocks Closes #13690 and #13180 See merge request !8003
| * Render math in Asciidoc and Markdown with KaTeX using code blocksMunken2016-12-141-3/+3
| |
* | resolve all instances of no-undef eslint rule violationsclean-no-undefMike Greiling2016-12-141-2/+6
|/
* Remove JSX/React eslint plugins.remove-jsx-react-eslint-pluginsLuke "Jared" Bennett2016-11-291-1/+1
| | | | | | | | | | | | Change airbnb eslint config package to `eslint-config-airbnb-base` and update plugins. Change `airbnb` to `airbnb-base` for .eslintrc `extends` value. Added changelog entry Made sure all plugins and envs are set Corrected new failing specs
* Merge branch 'resolve-discussions-timeago' into 'master' Fatih Acet2016-11-241-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed resolved discussion timeago not rendering ## What does this MR do? Initialises the timeago element when a discussion is updated or resolved. ## Screenshots (if relevant) ![Screen_Shot_2016-11-22_at_11.49.22](/uploads/02900cc4de019ac33cd4d59d586629aa/Screen_Shot_2016-11-22_at_11.49.22.png) ## What are the relevant issue numbers? Closes #24787 See merge request !7656
| * Fixed timeago when creating new discussionresolve-discussions-timeagoPhil Hughes2016-11-231-1/+1
| |
* | resolves lowercase issue in system note for labels, label description and title24737-labeling-system-notes-downcase-labelsNur Rony2016-11-221-0/+1
|/ | | | | | | | removes unnecessary changelog entry makes toggle commit list and compare link as secondary removes unnecessary function call
* makes system notes less intrusive to a conversationless-intrusive-system-noteNur Rony2016-11-171-12/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | adds dicussion icon and color change in system note links adds discussion icons and sticky note icon for other system notes for now fixes scss lint error adds faded commit lists hides first paragraph in commit list box css tweak for commit list system notes adds commit-list toggle functionality, css tweaks and css classnames more readable small css fix in header. makes links bold in system note renames class no-shade to hide-shade adds entry for this merge request in changelog removes commented line removes the avatar-icon from discussion header minor css tweaks to make the commit list alignment with header text uses monospaced font to make the commit list lined up with all removes icon from system note and align bullet list resolves scss lint warings adds helper function to extract system note message from first p tag adds helper functions to check commit list count and haml cleanup adds changelog entry under 8.14 adds changelog entry with changelog cli removes helper and regex and makes commit list li count using JS makes link in system note normal brakeman build failure resolved fixing rspec test based on new design for discussion shows system note in lowercase removes extra spaces from comments adds code commenting for functions adds semi-colon in some lines fixes rspec given when merge build success removes commented codes rewrite changelog yml file moves isMetaKey to common utils file fixes some indentation issues removes unnecessary variables and resolves some discussions replaces jQuery parent function with siblings fixes scss issues and variable spelling mistake uses constant rather using hardcoded number for visible li count in long commit list makes system note header all lowercase uses color variables and adjust gradient a little some minor changes for adding css classes renames functions name for readability changes changelog title minor scss newline changes makes system note less intrusive to a conversation
* explicitly disable eslint inlineexplicitly-disable-eslint-inlineLuke "Jared" Bennett2016-11-151-1/+1
|
* Changed how resolving notes is renderedPhil Hughes2016-11-101-11/+9
| | | | Vue2 was taking the template out & then appending again. This changes that
* Fixed up resolve discussionsPhil Hughes2016-11-101-1/+2
|
* disable ESLint for all JavaScript fileswinniehell2016-10-261-0/+1
|
* Changed props to use stringsresolve-buttons-pathPhil Hughes2016-09-211-3/+3
| | | | Use jQuery
* Fixed comment & resolve buttonPhil Hughes2016-09-211-6/+3
|
* Restore comments lost when converting CoffeeScript to JavaScriptJared Deckard2016-09-081-12/+62
|
* Add textarea autoresize after commentClement Ho2016-09-011-1/+6
|
* Merge branch 'diff-line-comment-vuejs' into 'master' Douwe Maan2016-08-191-12/+83
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Diff line comments resolve ## What does this MR do? Diff line comments can be resolved. Part of #10325 To do: - [x] Backend (@DouweM) - [x] Fix https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5022#note_13319326. Will be made easier by https://gitlab.com/gitlab-org/gitlab-ce/issues/17237#note_13370331 - [x] System note when all discussions are resolved - [x] Notification when all discussions are resolved - [x] Write unit tests - [x] Look at resolve time https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5022#note_13912743 - Fixed by 4a13aa9 - [x] Frontend (@iamphill) - [x] Fix bugs - [x] Write more feature tests - [x] Frontend (@connorshea) - [x] Address frontend feedback - [x] Feature specs for Jump feature - [x] Documentation - [x] Add Vue.js in a standard way See merge request !5022
| * Comment & resolve button no longer looks for can-resolve attributePhil Hughes2016-08-041-4/+1
| | | | | | | | Fixed some bugs when removing notes
| * Checks if DiffNotesApp is definedPhil Hughes2016-08-011-3/+3
| |
| * Moved method to compile components from window into diffnotesappPhil Hughes2016-08-011-4/+4
| |
| * Updated issues with jump tp buttonPhil Hughes2016-08-011-2/+2
| | | | | | | | Fixed styling bugs
| * Added JS spec tests for CommentsStorePhil Hughes2016-07-291-4/+4
| | | | | | | | Updated other tests
| * Moved most of the data handling into discussion & notes modelsPhil Hughes2016-07-291-19/+7
| | | | | | | | | | Reduced some duplicated code with compiling components Fixed bug with resolve button tooltip not updating after resolving discussion
| * Show existing discussion when adding new comment on line with a hidden ↵Douwe Maan2016-07-281-6/+11
| | | | | | | | resolved discussion
| * Added tests for resolving comments featurePhil Hughes2016-07-271-4/+4
| |
| * Fixed close merge request not hidingPhil Hughes2016-07-271-0/+1
| |
| * Fixed failing JSPhil Hughes2016-07-271-2/+2
| |
| * Added jump tp next discussion buttonPhil Hughes2016-07-271-4/+4
| |
| * Comment & resolve button text is done through VueJSPhil Hughes2016-07-261-3/+15
| |
View Lorry Controller Status