summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Refactor web editorrefactor-web-editorDmitriy Zaporozhets2015-06-058-155/+123
| | | | | | | | | | * fix problem with editing non-master branch * before commit make sure branch exists * dont allow user change file in one branch and commit to another existing branch * remove a lot of code duplication * remove outdated statellite errors Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ceDmitriy Zaporozhets2015-06-053-2/+4
|\
| * Merge branch 'maser/gitlab-ce-order-commit-comments-in-api' into 'master'Dmitriy Zaporozhets2015-06-053-2/+4
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Order commit comments in API chronologically When fetching commit comments via API, the comments were not ordered, but just returned in the order Postgresql finds them. Now the API always returns comments in chronological order. Same as !628 but with CI See merge request !768
| | * Order commit comments in API chronologicallyMartin Luder2015-05-083-2/+4
| | | | | | | | | | | | | | | | | | When fetching commit comments via API, the comments were not ordered, but just returned in the order Postgresql finds them. Now the API always returns comments in chronological order.
* | | Merge branch 'ci_script_simplify1' into 'master'Dmitriy Zaporozhets2015-06-051-10/+0
|\ \ \ | |/ / |/| | | | | | | | | | | CI script: remove directives with default value See merge request !1841
| * | CI script: remove directives with default valueValery Sizov2015-06-041-10/+0
|/ /
* | Merge branch 'rs-remove-guard' into 'master'Dmitriy Zaporozhets2015-06-046-85/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove Guard None of the GitLab B.V. developers were using it. See internal https://dev.gitlab.org/gitlab/gitlabhq/issues/2360 See merge request !764
| * | Remove unnecessary require from Spinach envRobert Speicher2015-06-041-1/+0
| | |
| * | Remove unnecessary require from RepositoryCache specRobert Speicher2015-06-041-1/+0
| | |
| * | Remove GuardRobert Speicher2015-06-034-83/+0
| | | | | | | | | | | | None of the GitLab B.V. developers were using it.
* | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ceDmitriy Zaporozhets2015-06-043-3/+24
|\ \ \
| * \ \ Merge branch 'fix-upgrader-script' into 'master'Dmitriy Zaporozhets2015-06-043-3/+24
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix upgrader script This is a fix for upgrader script not guessing the latest version correctly. Upgrader now handles versions where a version part (major/minor/patch) can have multi-digit number, also ensures that the latest version is chosen from git tags by converting tag to Gitlab::VersionInfo and than selecting the latest/greatest version. Fixes: #1476 See merge request !695
| | * | | Update mocking/stubbing syntax to the new RSpec 3 syntaxMartins Polakovs2015-05-301-1/+1
| | | | |
| | * | | Fix upgrader scriptMartins Polakovs2015-05-233-3/+24
| | | | |
* | | | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ceDmitriy Zaporozhets2015-06-049-8/+94
|\ \ \ \ \ | |/ / / /
| * | | | Merge branch 'make-namespaces-api-available-to-all-users' into 'master'Dmitriy Zaporozhets2015-06-047-6/+88
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make namespace API available to all users ### What does this MR do? This MR makes it possible for a user to query namespaces to which he/she has access. Also, it adds documentation for the existing API. ### Why was this MR needed? Even though the `groups` API exists, it might still be useful to have an endpoint that tells the namespace type (e.g. `user` vs. `group`), especially if a user has access to a number of different projects. ### What are the relevant issue numbers? Closes https://github.com/gitlabhq/gitlabhq/issues/9328 See merge request !708
| | * | | | Make namespace API available to all usersStan Hu2015-05-287-6/+88
| | | | | | | | | | | | | | | | | | | | | | | | Closes https://github.com/gitlabhq/gitlabhq/issues/9328
| * | | | | Merge branch 'sn-push-email-plussign' into 'master'Dmitriy Zaporozhets2015-06-041-1/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use entity number for plus sign in push emails Was doing some testing today and found that both outlook and gmail had issues displaying the html content produced for push emails when a file was added. This is how gmail shows it: ![Gmail_name](https://gitlab.com/stevenorman/gitlab-ce/uploads/24be115dbae97997bc02e2ec70d9870c/Gmail_name.png) And this is for Outlook: ![Outlook_name](https://gitlab.com/stevenorman/gitlab-ce/uploads/4b5a54956139d36d78f9c61c83e99928/Outlook_name.png) iOS devices work with the &plus; entity, as does Mail on OS X, but I'm wondering if it is only available for newer html parsers (a quick browse on the w3c site seems to show that it was added in html 5). Changing the entity to `&#43;` and both gmail and outlook and iOS and Mail. See merge request !721
| | * | | | | Use entity number for plus signSteve Norman2015-05-271-1/+1
| | | | | | |
| * | | | | | Merge branch 'fix-no-labels-page' into 'master'Dmitriy Zaporozhets2015-06-042-1/+5
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Omit link to generate labels if user does not have access to create them On a project that has no labels, a user was provided a link to create labels on the "Labels" tab, resulting in a 404. This MR changes the next to "No labels created" if the user lands on this page but does not have permission to add a label. Screenshot: ![image](https://gitlab.com/stanhu/gitlab-ce/uploads/cb04659cf3a0abe1e072cb78d0964b94/image.png) Closes https://github.com/gitlabhq/gitlabhq/issues/8353 See merge request !752
| | * | | | | | Omit link to generate labels if user does not have access to create themStan Hu2015-06-012-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes https://github.com/gitlabhq/gitlabhq/issues/8353
* | | | | | | | Merge branch 'refacor-ci-script' into 'master'Dmitriy Zaporozhets2015-06-041-48/+3
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor CI script Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> cc @valery See merge request !1840
| * | | | | | | Refactor CI scriptDmitriy Zaporozhets2015-06-041-48/+3
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | | | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ceDmitriy Zaporozhets2015-06-042-1/+5
|\ \ \ \ \ \ \
| * \ \ \ \ \ \ Merge branch 'trigger_hooks_create_on_backup_restore' into 'master'Dmitriy Zaporozhets2015-06-042-1/+5
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Trigger hooks create on backup restore Number of users migrating from installation from source to omnibus get this issue. This can be fixed with a bash one liner but we already have a script that creates hooks in gitlab-shell. Added to gitlab:shell:install task call to `bin/create-hooks`. This script is idempotent which means it will only rewrite hooks if something changed. Fixes https://dev.gitlab.org/gitlab/gitlabhq/issues/2208, https://github.com/gitlabhq/gitlabhq/issues/9101 and for the most part https://github.com/gitlabhq/gitlabhq/issues/8161 See merge request !762
| | * | | | | | | Add a changelog item.trigger_hooks_create_on_backup_restoreMarin Jankovski2015-06-031-1/+2
| | | | | | | | |
| | * | | | | | | Trigger hooks-create on gitlab backup restore.Marin Jankovski2015-06-031-0/+3
| | | | | | | | |
* | | | | | | | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ceDmitriy Zaporozhets2015-06-0417-94/+87
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / /
| * | | | | | | | Merge branch 'rs-issue-1741' into 'master'Dmitriy Zaporozhets2015-06-0413-93/+20
| |\ \ \ \ \ \ \ \ | | |_|_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove show actions from Admin and Project DeployKeys Example styling after: > ![Screen_Shot_2015-06-03_at_6.04.51_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/105801a7e390224066721bba200c4909/Screen_Shot_2015-06-03_at_6.04.51_PM.png) Closes #1741 See merge request !763
| | * | | | | | | Show key fingerprint on DeployKeys#indexrs-issue-1741Robert Speicher2015-06-035-15/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also style all key fingerprints consistently across the app.
| | * | | | | | | Remove show actions from Admin and Project DeployKeysRobert Speicher2015-06-038-78/+4
| |/ / / / / / /
| * | | | | | | Merge branch 'rs-2fa-docs' into 'master'Job van der Voort2015-06-034-1/+67
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add 2FA docs See merge request !757
| | * | | | | | | fix typo and add screenshotsJob van der Voort2015-06-033-3/+3
| | | | | | | | |
| | * | | | | | | Add 2FA docsrs-2fa-docsRobert Speicher2015-06-022-1/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | | Merge branch 'add_ci_yaml' into 'master'Dmitriy Zaporozhets2015-06-041-0/+94
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added autogenerated .gitlab-ci.yml See merge request !1839
| * | | | | | | | added ci yamlValery Sizov2015-06-041-0/+94
|/ / / / / / / /
* | | | | | | | Merge branch 'fix-group-remove' into 'master'Dmitriy Zaporozhets2015-06-0310-8/+93
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Group improvements * remove projects before removing group * execute all hooks/events from project destroy when group removed * log group create/remove * delay remove of namespace directory (to prevent NFS issues) Inspired by !759 See merge request !761
| * | | | | | | | Add CHANGELOG itemDmitriy Zaporozhets2015-06-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | Skip repo removing whem remove user or groupDmitriy Zaporozhets2015-06-035-11/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | Log group creation and removalDmitriy Zaporozhets2015-06-031-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | Merge branch 'repo-remove' into fix-group-removeDmitriy Zaporozhets2015-06-037-41/+106
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> Conflicts: spec/features/projects_spec.rb
| * | | | | | | | | Remove projects before group/user. Remove namespace directory asyncfix-group-removeDmitriy Zaporozhets2015-06-033-2/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | | Wrap group removal into serviceDmitriy Zaporozhets2015-06-034-3/+14
| | |/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | | | | | | Merge branch 'remove_unecessary_rake_task' into 'master'Dmitriy Zaporozhets2015-06-034-62/+36
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove gitlab:env:check task. Rake task that checks for git user git settings is a leftover from early days. It is not being used by the web editor(and web editor is also being redone atm) so this rake task just causes confusion. Adresses internal issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2362 See merge request !758
| * | | | | | | | | Add autocrlf back to installation docs, add a check for it.Marin Jankovski2015-06-033-2/+36
| | | | | | | | | |
| * | | | | | | | | Remove gitlab:env:check task.remove_unecessary_rake_taskMarin Jankovski2015-06-033-62/+2
| | | | | | | | | |
* | | | | | | | | | Merge branch 'repo-remove'Dmitriy Zaporozhets2015-06-037-41/+106
|\ \ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / | |/| | / / / / / / | |_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> Conflicts: spec/features/projects_spec.rb
| * | | | | | | | Fix tests and increase delay time before remove repositoryDmitriy Zaporozhets2015-06-033-17/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | Add tests for project destroy servicerepo-removeDmitriy Zaporozhets2015-06-031-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | | | | Move repository when project is removedDmitriy Zaporozhets2015-06-034-27/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ths commit does next: * When we remove project we move repository to path+deleted.git * Then we schedule removal of path+deleted with sidekiq * If repository move failed we abort project removal This should help us with NFS issue when project get removed but repository stayed. The full explanation of problem is below: * rm -rf project.git * rm -rf removes project.git/objects/foo * NFS server renames foo to foo.nfsXXXX because some NFS client (think * Unicorn) still has the file open * rm -rf exits, but project.git/objects/foo.nfsXXX still exists * Unicorn closes the file, the NFS client closes the file (foo), and the * NFS server removes foo.nfsXXX * the directory project.git/objects/ still exists => problem So now we move repository and even if repository removal failed Repository directory is moved so no bugs with project removed but repository directory taken. User still able to create new project with same name. From administrator perspective you can easily find stalled repositories by searching `*+deleted.git` Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>