summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* newline before default returnrefactor/add-policieshttp://jneen.net/2016-08-301-0/+1
|
* s/NB:/NOTE:/http://jneen.net/2016-08-302-2/+2
|
* don't use a deprecated api in ability_spechttp://jneen.net/2016-08-301-2/+2
|
* implement RuleSet#size for testshttp://jneen.net/2016-08-301-0/+4
|
* line break after guard clausehttp://jneen.net/2016-08-301-0/+1
|
* use || in place of `or`http://jneen.net/2016-08-301-1/+1
|
* use a more compact style for access policieshttp://jneen.net/2016-08-301-11/+4
|
* move the rules method to the top #cosmetichttp://jneen.net/2016-08-301-27/+27
|
* factor out a RuleSet so that `delegate!` retains @cannothttp://jneen.net/2016-08-302-9/+51
|
* remove the rest of the dead codehttp://jneen.net/2016-08-301-74/+0
|
* special-case blocked usershttp://jneen.net/2016-08-301-0/+1
|
* test if we can :read_group the group, not the namespacehttp://jneen.net/2016-08-301-1/+1
|
* use a nil subject when we want to check global abilitieshttp://jneen.net/2016-08-302-2/+2
|
* add Deployment, Environment, and ExternalIssue policieshttp://jneen.net/2016-08-303-0/+15
|
* take the dive - only use abilities from Policieshttp://jneen.net/2016-08-301-8/+1
|
* use the cached abilities in #delegate!http://jneen.net/2016-08-301-1/+1
|
* port UserPolicyhttp://jneen.net/2016-08-302-11/+11
|
* port runners, namespaces, group/project_membershttp://jneen.net/2016-08-304-58/+42
|
* add personal snippets and project membershttp://jneen.net/2016-08-302-0/+38
|
* factor in global permissionshttp://jneen.net/2016-08-302-2/+9
|
* trim more dead codehttp://jneen.net/2016-08-301-52/+1
|
* port groupshttp://jneen.net/2016-08-302-36/+48
|
* port personal snippetshttp://jneen.net/2016-08-301-32/+1
|
* trim dead codehttp://jneen.net/2016-08-301-81/+0
|
* port notes and project snippetshttp://jneen.net/2016-08-302-0/+39
|
* add automatic detection of the policy classhttp://jneen.net/2016-08-302-16/+18
|
* port CommitStatus/Buildhttp://jneen.net/2016-08-304-1/+24
|
* add and use MergeRequestPolicyhttp://jneen.net/2016-08-302-2/+8
|
* port issues to Issu{able,e}Policyhttp://jneen.net/2016-08-305-4/+58
|
* add support for anonymous abilitieshttp://jneen.net/2016-08-303-205/+67
|
* add project_policy_spec to replace .project_abilities spechttp://jneen.net/2016-08-302-64/+36
|
* add policies, and factor out ProjectPolicyhttp://jneen.net/2016-08-303-31/+231
|
* remove Ability.abilitieshttp://jneen.net/2016-08-3018-61/+37
|
* make almost everything on Ability privatehttp://jneen.net/2016-08-301-46/+44
|
* don't double-cache project_abiliteshttp://jneen.net/2016-08-301-11/+2
|
* remove six, and use a Set insteadhttp://jneen.net/2016-08-306-20/+22
|
* delete project_security_spechttp://jneen.net/2016-08-301-112/+0
| | | | | re a conversation with @rspeicher, this spec isn't really testing anything.
* re-enable the cyclomatic complexity checkerhttp://jneen.net/2016-08-301-1/+0
|
* Merge branch 'artifacts-from-ref-and-build-name' into 'master' Douwe Maan2016-08-3034-109/+501
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a download buttons for Build Artifacts ## What does this MR do? This MR adds a download buttons for build artifacts of latest succesful pipeline in: - dashboard of project, - branches and tags views, - and tree viewer Implement #4255 ## What are the relevant issue numbers? Closes #4255, Closes #14419 ## Screenshots ### Project main ![](/uploads/29ee2154a214416059a875f2715d4fa3/Screen_Shot_2016-08-24_at_8.00.31_PM.png) ### Branches ![](/uploads/9220c593288370986fbc1d42a1425ef7/Screen_Shot_2016-08-24_at_8.02.01_PM.png) ### Tags ![](/uploads/a843e8103221fea475a0cf9d62a1999d/Screen_Shot_2016-08-24_at_8.03.32_PM.png) ### Source Tree ![](/uploads/63cd3c8c91b6f427c166dc90d8e3c059/Screen_Shot_2016-08-24_at_8.04.56_PM.png) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] Download buttons - [x] Models - [x] Routes - [x] Projects::ArtifactsController - [x] API - Tests - Rails - [x] Project#builds_for - [x] branch name with slashes - [x] only success builds - [x] only latest builds - [x] feature tests for download buttons - API - [x] branch name with slashes - [x] only success builds - [x] only latest builds - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5142
| * Fix CHANGELOGartifacts-from-ref-and-build-nameLin Jen-Shin2016-08-261-2/+0
| |
| * Merge remote-tracking branch 'upstream/master' into ↵Lin Jen-Shin2016-08-26145-750/+1721
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | artifacts-from-ref-and-build-name * upstream/master: (107 commits) Fix external issue tracker "Issues" link leading to 404s Fix CHANGELOG entries related to 8.11 release. Fix changelog Reduce contributions calendar data payload Add lock_version to merge_requests table Add hover color to emoji icon Fix wrong Koding link Capitalize mentioned issue timeline notes Fix groups sort dropdown alignment Use icon helper Fix inline emoji text alignment Adds response mime type to transaction metric action when it's not HTML Moved two 8.11 changelog entries to 8.12 Fix markdown link in doc_styleguide.md Display project icon from default branch Reduce number of database queries on builds tab Update CHANGELOG Update Issue board documentation Label list shows all issues (opened or closed) with that label Update CHANGELOG ...
| * | Fix testsLin Jen-Shin2016-08-261-3/+1
| | |
| * | Extract ref_name and path in before_action, feedback:Lin Jen-Shin2016-08-261-5/+10
| | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14469768
| * | Add a download icon for artifacts, too. Feedback:Lin Jen-Shin2016-08-251-0/+1
| | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14400694
| * | Just use instance variable instead, feedback:Lin Jen-Shin2016-08-251-7/+2
| | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14400736
| * | Update CHANGELOG from v8.11.0 to v8.12.0Lin Jen-Shin2016-08-241-1/+1
| | |
| * | Merge remote-tracking branch 'upstream/master' into ↵Lin Jen-Shin2016-08-24250-663/+3388
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | artifacts-from-ref-and-build-name * upstream/master: (192 commits) Added CHANGELOG Added unfold test to parallel and added 'diff discussion' context Fix Spinach branches spec Better first match on this MR also Change merge_error column from string to text type Fix typo in gitlab_flow.md entities: make Environment inherit EnvironmentBasic Updated to optimized specs from !5864 Added 'with an unfolded line should not allow commenting' scenario (line 125) Added addtional 'renderable' validator to check 'data-note-type' attr exists Allow passing an index to selectRowAtIndex Fixed enter key in search input not working Fix file links on project page Files view Fix incorrect "stopped impersonation" log message 8.11 is released, long live 8.12 Also check if Akismet is enabled, before showing the `Submit as spam` button. fix location of markdown help location Fix for update 8.10-to-8.11.md doc. Appease the linter. Add Ruby 2.3 upgrade notes. ...
| * | | Aggressively merge views, feedback:Lin Jen-Shin2016-08-2410-85/+37
| | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14347679 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14347470
| * | | Path could also have slashes! Feedback:Lin Jen-Shin2016-08-244-10/+36
| | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14347729
| * | | Use only one before block, feedback:Lin Jen-Shin2016-08-241-2/+0
| | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142/diffs#note_14347758