summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Properly quote table name in Rake task for MySQL and PostgreSQL compatibilityfix-issue-15259-postgresqlStan Hu2016-06-091-1/+1
| | | | | | !4318 broke the gitlab:db:drop_tables functionality for PostgreSQL. Closes #15259
* Merge branch 'autocomplete-comment-fix' into 'master' Jacob Schatz2016-06-091-1/+4
|\ | | | | | | | | | | | | | | | | Checks for undefined when inserting autocomplete into textarea ## What does this MR do? Correctly checks for undefined before inserting anything into the textarea when using autocomplete. This happens because the loading indicator tries to insert `@undefined` which we dont want to insert. See merge request !4561
| * Checks based on whether data is loaded not undefinedPhil Hughes2016-06-091-1/+4
| |
| * Checks for undefined when inserting autocomplete into textareaPhil Hughes2016-06-091-1/+1
| |
* | Merge branch 'fix_issue_15259' into 'master' Stan Hu2016-06-091-1/+1
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix bug with SQL syntax error during backup restoration ## What does this MR do? It properly escapes the table name in the `DROP TABLE IF EXISTS ...` statement used during restore of a backup. ## Are there points in the code the reviewer needs to double check? Please check compatibility with PostgreSQL ## Why was this MR needed? Fix an issue with backups can not be restored if MySQL is used as database for GitLab. ## What are the relevant issue numbers? #15259 ## Screenshots (if relevant) - See merge request !4318
| * Fix bug with SQL syntax error during backup restorationDaniel Beyer2016-05-271-1/+1
| | | | | | closes #15259
* | Merge branch 'fix-empty-user-projects-snippets-list' into 'master' Jacob Schatz2016-06-090-0/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix empty user projects snippets list ## What are the relevant issue numbers? Closes #17952 #17816 and #17737 cc: @lbennett @jschatz1 See merge request !4532
| * | fix empty user projects snippets listBartholomew2016-06-081-2/+2
| | |
* | | Merge branch 'dz-improve-ui-consistency-2' into 'master' Jacob Schatz2016-06-0917-82/+71
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve ui consistency. Part 2 * Use responsive top-area on project branches and tags pages * Use default button size in the content list controls * Improve button margin for btn-grouped css class For https://gitlab.com/gitlab-org/gitlab-ce/issues/18324 See merge request !4536
| * | | Remove icons from button on wiki pages. Also consistent padding between ↵dz-improve-ui-consistency-2Dmitriy Zaporozhets2016-06-086-11/+2
| | | | | | | | | | | | | | | | | | | | | | | | buttons there Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | Improve buttons size and paddings in the listsDmitriy Zaporozhets2016-06-085-14/+17
| | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | Use responsive top-area on project branches and tags pagesDmitriy Zaporozhets2016-06-082-27/+26
| | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | Use default button size in the content list controlsDmitriy Zaporozhets2016-06-081-1/+3
| | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | Improve button margin for btn-grouped css classDmitriy Zaporozhets2016-06-084-30/+24
| | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | Merge branch 'due-date-field-ux-improv' into 'master' Jacob Schatz2016-06-096-24/+42
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improved the UX of issue & milestone date picker ## What does this MR do? Improves the UX of the date picker on issue form & milestone form. ## What are the relevant issue numbers? Closes #18198 ## Screenshots (if relevant) ### Issues ![Screen_Shot_2016-06-06_at_09.28.29](/uploads/d9c192dff0d8076adc3ed6f005ea3790/Screen_Shot_2016-06-06_at_09.28.29.png) ### Project milestones ![Screen_Shot_2016-06-06_at_09.28.18](/uploads/2d03d72791c5fc6badfadb975a85af2b/Screen_Shot_2016-06-06_at_09.28.18.png) ### Group milestones ![Screen_Shot_2016-06-06_at_09.28.05](/uploads/0f28532396a16e6fd48ddea784ca28e3/Screen_Shot_2016-06-06_at_09.28.05.png) See merge request !4485
| * | | | Fixed testsPhil Hughes2016-06-091-5/+7
| | | | |
| * | | | CHANGELOGPhil Hughes2016-06-091-0/+1
| | | | |
| * | | | Improved the UX of issue & milestone date pickerPhil Hughes2016-06-094-19/+34
| | | | | | | | | | | | | | | | | | | | Closes #18198
* | | | | Merge branch 'remove-chart' into 'master' Jacob Schatz2016-06-092-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only load Chart.js when necessary. Only load Chart.js where it's used, namely the Graphs section. Follow up on !4394. cc: @jschatz1 See merge request !4516
| * | | | | Only load Chart.js when necessary.Connor Shea2016-06-072-1/+1
| | | | | |
* | | | | | Merge branch 'issue_17607' into 'master' Jacob Schatz2016-06-097-5/+70
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix local timeago on user dashboard ## What does this MR do? Fixes incorrect date times on tooltips on the dashboard page ## Are there points in the code the reviewer needs to double check? Yes, The tooltip has to be recreated again because we needed a custom CSS classname in order to fix the date being splitted into two lines. ## Why was this MR needed? Because the datetimes were incorrect we have to have the same format for .timeago() instances. ## What are the relevant issue numbers? #17607 ## Screenshots (if relevant) **Before** <img src="/uploads/f40cd58e8086d9675262e98a1fe57885/Screen_Shot_2016-05-24_at_7.23.25_PM.png" width="705"> **After** <img src="/uploads/bd48046ef11659cc742f827b3404fbcd/Screen_Shot_2016-05-24_at_7.22.29_PM.png" width="704"> See merge request !4285
| * | | | | | Change date format to be non zero padded in order to fix failing testAlfredo Sumaran2016-06-091-1/+1
| | | | | | |
| * | | | | | Update method name for better understandingAlfredo Sumaran2016-06-091-2/+2
| | | | | | |
| * | | | | | Add tests for dates on tooltipsAlfredo Sumaran2016-06-092-2/+48
| | | | | | |
| * | | | | | Fix local timeago on user dashboardAlfredo Sumaran2016-06-095-3/+22
| | | | | | |
* | | | | | | Merge branch 'input-padding' into 'master' Jacob Schatz2016-06-093-1/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve input padding, fix #18237. ## What does this MR do? Improves horizontal padding for input fields. ## What are the relevant issue numbers? #18237 ## Screenshots (if relevant) Before: ![Screen_Shot_2016-06-06_at_12.11.07_PM](/uploads/11d24c84e1ca8d268a5acc2b4e10bb77/Screen_Shot_2016-06-06_at_12.11.07_PM.png) After: ![Screen_Shot_2016-06-06_at_12.10.38_PM](/uploads/cbb407d8fca1e8dc1ace2af6c0774181/Screen_Shot_2016-06-06_at_12.10.38_PM.png) cc: @jschatz1 See merge request !4489
| * | | | | | | Improve input padding, fix #18237.Connor Shea2016-06-063-1/+3
| | | | | | | |
* | | | | | | | Merge branch 'merge-conflicts-icon-color' into 'master' Jacob Schatz2016-06-092-2/+7
|\ \ \ \ \ \ \ \ | |_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use warning color merge conflicts icon in MR status widget. Fixes #18174 ### Before ![Screen_Shot_2016-06-06_at_18.00.56](/uploads/4a74b1710478daee5ee95b7c6b6a835f/Screen_Shot_2016-06-06_at_18.00.56.png) ### After ![Screen_Shot_2016-06-06_at_17.58.04](/uploads/28faefaebef30e4256390029c87b28bb/Screen_Shot_2016-06-06_at_17.58.04.png) See merge request !4487
| * | | | | | | Use warning color merge conflicts icon in MR status widget.merge-conflicts-icon-colorFatih Acet2016-06-062-2/+7
| | | | | | | |
* | | | | | | | Merge branch 'note-edit-background-color' into 'master' Jacob Schatz2016-06-091-11/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Edit form background color on highlighted note ## What does this MR do? Added white background to edit form when in a highlighted note ## What are the relevant issue numbers? Closes #18101 ## Screenshots (if relevant) ![Screen_Shot_2016-06-02_at_11.24.20](/uploads/c7c7fe710aa74d86152a109560fd0ebe/Screen_Shot_2016-06-02_at_11.24.20.png) See merge request !4435
| * | | | | | | | Edit form background color on highlighted notenote-edit-background-colorPhil Hughes2016-06-021-11/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added a white background to the edit form on highlighted notes Closes #18101
* | | | | | | | | Merge branch 'toggling-task-should-not-generate-todo' into 'master' Robert Speicher2016-06-093-4/+38
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Toggling a task in a description with mentions doesn't creates a Todo When user toggle a task list item in a description with a mention it does not create an unnecessary Todo for that mention. Closes #14116 See merge request !4568
| * | | | | | | | | Update CHANGELOGDouglas Barbosa Alexandre2016-06-091-0/+1
| | | | | | | | | |
| * | | | | | | | | Toggling a task in a description with mentions doesn't creates a TodoDouglas Barbosa Alexandre2016-06-092-4/+37
| | | | | | | | | |
* | | | | | | | | | Merge branch 'button-focus-state' into 'master' Jacob Schatz2016-06-091-0/+4
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Blur button tags when pressed to remove the focus state. ## Before ![pemnD5exKl](/uploads/333155bf4a6c43715f3fc04d8f5aa35e/pemnD5exKl.gif) ## After ![dCPvSwsuWp](/uploads/9bcfbe59ac8de51e9d2c3edcb3d13ff3/dCPvSwsuWp.gif) See merge request !4418
| * | | | | | | | | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into button-focus-statebutton-focus-stateFatih Acet2016-06-06245-1404/+4955
| |\ \ \ \ \ \ \ \ \
| * | | | | | | | | | Blur button tags when clicked. Fixes #17748.Fatih Acet2016-06-011-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://stackoverflow.com/questions/23443579/how-to-stop-buttons-from-staying-depressed-with-bootstrap-3
* | | | | | | | | | | Merge branch 'labels-ui-fix' into 'master' Jacob Schatz2016-06-097-83/+107
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updated labels UI - Fixed alignment issues - Added dropdown to mobile to make the options look nicer & to save space ![Screen_Shot_2016-05-25_at_09.42.46](/uploads/ff59abd2310725965b388a62c6c1f2af/Screen_Shot_2016-05-25_at_09.42.46.png) Closes #14227 See merge request !4273
| * | | | | | | | | | Fixed failing label subscribe testlabels-ui-fixPhil Hughes2016-06-091-1/+1
| | | | | | | | | | |
| * | | | | | | | | | Tests updatePhil Hughes2016-06-091-1/+1
| | | | | | | | | | |
| * | | | | | | | | | Updated subscribe iconPhil Hughes2016-06-093-4/+27
| | | | | | | | | | |
| * | | | | | | | | | Fixed failing testsPhil Hughes2016-06-093-3/+3
| | | | | | | | | | |
| * | | | | | | | | | Updated labels UIPhil Hughes2016-06-094-78/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #14227
* | | | | | | | | | | Merge branch '17562-filter-issues-is-only-visible-when-user-is-logged-in' ↵Jacob Schatz2016-06-093-12/+4
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' #17562 Fixes issues list filter only visible when user is logged in ## What does this MR do? 1. Moves the issue/MR list search form out of the `if current_user` conditional, allowing guests to view the field. 2. Adds some margin to the search form, this is because in mobile view for guest users, the field was not supported by the RSS button and the New Issue button and would drop to meet the list. ## Are there points in the code the reviewer needs to double check? Are there any views where the `margin-bottom: 12px` will affect the styling? ## Why was this MR needed? Guest user UX. Nothing feels better than increasing intangible value! ## What are the relevant issue numbers? Fixes #17562. ## Screenshots (if relevant) ![Screen_Shot_2016-05-16_at_23.48.06](/uploads/cf0f0c48287517ac3e83b204b4ee09b2/Screen_Shot_2016-05-16_at_23.48.06.png) /cc @jschatz1 **UPDATE:** ![Screen_Shot_2016-05-20_at_16.13.22](/uploads/eb854838a514d0d54d0f13bde1636b8a/Screen_Shot_2016-05-20_at_16.13.22.png) See merge request !4171
| * | | | | | | | | | | Fixes issue search form hiding when current_user is nil (guest user)Luke Bennett2016-06-073-12/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes the bottom margin of .nav-controls > form (issues list search/filter form) so when a guest views on the field on mobile it is not squished against the issues list Updated CHANGELOG navigation tabs and navigation filter search will now stay on the same row until there is no space to Removed unneeded media queries
* | | | | | | | | | | | Merge branch 'rs-fix-ldap-2fa-login' into 'master' Robert Speicher2016-06-091-1/+2
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix 2FA-based login for LDAP users The OTP input form is shared by both LDAP and standard logins, but when coming from an LDAP-based form, the form parameters aren't nested in a Hash based on the `resource_name` value. Now we check for a nested `remember_me` parameter and use that if it exists, or fall back to the non-nested parameters if it doesn't. Somewhat confusingly, the OTP input form _does_ nest parameters under the `resource_name`, regardless of what type of login we're coming from, so that allows everything else to work as normal. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/18185 See merge request !4493
| * | | | | | | | | | | | Fix 2FA-based login for LDAP usersrs-fix-ldap-2fa-loginRobert Speicher2016-06-071-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The OTP input form is shared by both LDAP and standard logins, but when coming from an LDAP-based form, the form parameters aren't nested in a Hash based on the `resource_name` value. Now we check for a nested `remember_me` parameter and use that if it exists, or fall back to the non-nested parameters if it doesn't. Somewhat confusingly, the OTP input form _does_ nest parameters under the `resource_name`, regardless of what type of login we're coming from, so that allows everything else to work as normal.
* | | | | | | | | | | | | Merge branch 'fix-changelog' into 'master' Jacob Schatz2016-06-091-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update CHANGELOG Fixes wrong changelog entry for !4175 See merge request !4548
| * | | | | | | | | | | | Update CHANGELOGAlfredo Sumaran2016-06-091-1/+1
|/ / / / / / / / / / / /
* | | | | | | | | | | | Merge branch 'fix-git-http-routing' into 'master' Douwe Maan2016-06-092-18/+99
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ensure only IDs ending in .git perform git actions ## What does this MR do? Rails's routing is pretty strange. Previously, `GET /namespace/project/info/refs` would go to the Git HTTP controller (if the redirect for that case was taken out). ## Are there points in the code the reviewer needs to double check? The specs fail if the redirect is moved to above the Git HTTP routes, removed altogether, or the Git HTTP constraints are changed. But there might still be missing cases. ## Why was this MR needed? The master build and HTTP cloning were both broken. ## What are the relevant issue numbers? Closes #18376. ## Screenshots (if relevant) Nope. ## Does this MR meet the acceptance criteria? - [x] [not needed] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [not needed] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] (not needed) API support added - [ ] Tests - [x] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4558