| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Due to broken implementation of attribute_for_keys the runner information was not updated correctly.
This MR adds test to check that such scenario will never happen again.
|
|\
| |
| |
| |
| |
| |
| | |
Use generic method to checks if artifacts are available
Closes #12626
See merge request !2576
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix typo on artifacts doc
See merge request !2622
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | |
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Update ExternalIssue regex for JIRA integration
The pattern in the `::reference_pattern` class method in the
`ExternalIssue` model does not match all valid forms of JIRA project
names. I have updated the regex to match JIRA project names with numbers
and underscores. More information on valid JIRA project names can be
found here:
https://confluence.atlassian.com/jira/changing-the-project-key-format-192534.html
* The first character must be a letter,
* All letters used in the project key must be from the Modern Roman Alphabet and upper case, and
* Only letters, numbers or the underscore character can be used.
See merge request !2598
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The pattern in the `::reference_pattern` class method in the
ExternalIssue model does not match all valid forms of JIRA project
names. I have updated the regex to match JIRA project names with numbers
and underscores. More information on valid JIRA project names can be
found here:
https://confluence.atlassian.com/jira/changing-the-project-key-format-192534.html
* The first character must be a letter,
* All letters used in the project key must be from the Modern Roman Alphabet and upper case, and
* Only letters, numbers or the underscore character can be used.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Bug/jschatz1/file browser lines
Fixes #12725

See merge request !2615
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Uses `$border-color`
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit a14089485ff697d58dddb61e6da2d1b6c64a803e.
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit 111834883d287c89a24ae395900786d771214bdb.
|
| | | |
| | | |
| | | |
| | | | |
Fixes #12725
|
| | | |
| | | |
| | | |
| | | | |
New download btn WIP.
|
|\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Bump Workhorse version to 0.6.2
Fix for #12634 has been introduced in gitlab-org/gitlab-workhorse!34.
See merge request !2616
|
| | | |
| | | |
| | | |
| | | | |
This has been fixed in Workhorse [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
Fix for #12634 has been introduced in gitlab-org/gitlab-workhorse!34.
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
'search-box-in-group-members-view-is-too-small-for-placeholder-in-chrome' into 'master'
Fixes: Search box in Group Members view is too small for placeholder in Chrome
Fixes #2498

See merge request !2609
|
| | | |
| | | |
| | | |
| | | | |
Fixes #2498
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Monkey patch for mysql 5.7
See merge request !2597
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Clicks the edit button instead of opening the dropdown
Fixes #2307
Instead of opening the menu, this clicks the `edit` button.
See merge request !2607
|
| | |/ / /
| |/| | |
| | | | |
| | | | | |
Fixes #2307
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix visibility level texts on application settings
Introduced by me through !2005
Before:

After:

See merge request !2611
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Introduced by me through !2005
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Save button on app settings now btn-save
Some save buttons where `btn-primary` where throughout the application these usually are `btn-save`.
Before (Application settings)

After

See merge request !2612
|
| | |_|_|/
| |/| | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Track project import failure
Fixes #12512
This also help us on identify why the import process is returning the wrong status when the project was successfully imported. Like mentioned in the issue #12450
See merge request !2538
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add tests for clicking a row in build artifacts browser
This adds a feature tests for clicking a row, which is handled by javascript event.
/cc @ayufan
See merge request !2551
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Update text_color_for_bg helper to support RGB triplet color codes
Closes #12677
See merge request !2587
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Closes #12677
|
|\ \ \ \ \ \ \
| |_|_|_|/ / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Make the `/groups` route behave as expected
The route is supposed to redirect the Groups#index request based on
whether or not a user was logged in. If they are, we redirect them to
their groups dashboard; if they're not, we redirect them to the public
Explore page.
But due to overly aggressive `before_action`s that weren't excluding (or including) the
`index` action, the request always resulted in a 404, whether a user was
logged in or not.
Closes #12660
See merge request !2580
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The route is supposed to redirect the Groups#index request based on
whether or not a user was logged in. If they are, we redirect them to
their groups dashboard; if they're not, we redirect them to the public
Explore page.
But due to overly aggressive `before_action`s that weren't excluding the
`index` action, the request always resulted in a 404, whether a user was
logged in or not.
Closes #12660
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Update Slack integration configuration
Adjusted to the current Slack version (as of I 2016).
See merge request !2595
|
| | |_|_|_|_|/
| |/| | | | | |
|
| |_|_|_|_|/
|/| | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix import redirect loop
Fixes #11864
See merge request !2606
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Correct arity for instrumented methods w/o args
This should fix the problem of imports not working. See https://gitlab.com/gitlab-org/gitlab-ce/issues/12450#note_3380730 for the details/context of these changes.
See merge request !2602
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This ensures that an instrumented method that doesn't take arguments
reports an arity of 0, instead of -1.
If Ruby had a proper method for finding out the required arguments of a
method (e.g. Method#required_arguments) this would not have been an
issue. Sadly the only two methods we have are Method#parameters and
Method#arity, and both are equally painful to use.
Fixes gitlab-org/gitlab-ce#12450
|