| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the composite index on ci_pipelines (project_id, ref,
status) to also include the "id" column at the end. Adding this column
to the index drastically improves the performance of queries used for
getting the latest pipeline for a particular branch. For example, on
project dashboards we'll run a query like the following:
SELECT ci_pipelines.*
FROM ci_pipelines
WHERE ci_pipelines.project_id = 13083
AND ci_pipelines.ref = 'master'
AND ci_pipelines.status = 'success'
ORDER BY ci_pipelines.id DESC
LIMIT 1;
Limit (cost=0.43..58.88 rows=1 width=224) (actual time=26.956..26.956 rows=1 loops=1)
Buffers: shared hit=6544 dirtied=16
-> Index Scan Backward using ci_pipelines_pkey on ci_pipelines (cost=0.43..830922.89 rows=14216 width=224) (actual time=26.954..26.954 rows=1 loops=1)
Filter: ((project_id = 13083) AND ((ref)::text = 'master'::text) AND ((status)::text = 'success'::text))
Rows Removed by Filter: 6476
Buffers: shared hit=6544 dirtied=16
Planning time: 1.484 ms
Execution time: 27.000 ms
Because of the lack of "id" in the index we end up scanning over the
primary key index, then applying a filter to filter out any remaining
rows. The more pipelines a GitLab instance has the slower this will get.
By adding "id" to the mentioned composite index we can change the above
plan into the following:
Limit (cost=0.56..2.01 rows=1 width=224) (actual time=0.034..0.034 rows=1 loops=1)
Buffers: shared hit=5
-> Index Scan Backward using yorick_test on ci_pipelines (cost=0.56..16326.37 rows=11243 width=224) (actual time=0.033..0.033 rows=1 loops=1)
Index Cond: ((project_id = 13083) AND ((ref)::text = 'master'::text) AND ((status)::text = 'success'::text))
Buffers: shared hit=5
Planning time: 0.695 ms
Execution time: 0.061 ms
This in turn leads to a best-case improvement of roughly 25
milliseconds, give or take a millisecond or two.
|
| |\
| |
| |
| |
| |
| |
| | |
Resolve "TagsPage|Tags"
Closes #40367
See merge request gitlab-org/gitlab-ce!15512
|
| | |
| |
| |
| | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Batch load blobs for diff generation
Closes #37599
See merge request gitlab-org/gitlab-ce!15370
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
After installing a new gem, batch-loader, a construct can be used to
queue data to be fetched in bulk. The gem was also introduced in both
gitlab-org/gitlab-ce!14680 and gitlab-org/gitlab-ce!14846, but those mrs
are not merged yet.
For the generation of diffs, both the old blob and the new blob need to
be loaded. This for every file in the diff, too. Now we collect all
these so we do 1 fetch. Three `.allow_n_plus_1_calls` have been removed,
which I expect to be valid, but this needs to be confirmed by a full CI
run.
Possibly closes:
- https://gitlab.com/gitlab-org/gitlab-ce/issues/37445
- https://gitlab.com/gitlab-org/gitlab-ce/issues/37599
- https://gitlab.com/gitlab-org/gitlab-ce/issues/37431
|
| |\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Fix promoting milestone updating all issuables without milestone
Closes #40337
See merge request gitlab-org/gitlab-ce!15487
|
| | | | |
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
Fix slow gitaly dev test bundle
See merge request gitlab-org/gitlab-ce!15508
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | | |
Export code as ES6 modules
See merge request gitlab-org/gitlab-ce!15503
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Backport ability to enable/disable file attachments in issuable form
See merge request gitlab-org/gitlab-ce!15433
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Memoize GitlabShellAdapter for performance and ease of testing
See merge request gitlab-org/gitlab-ce!15507
|
| | | | |
| | | |
| | | |
| | | | |
Port of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3463#note_47990536
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix commits list 500 with multi-file editor new_repo cookie
Closes #39821
See merge request gitlab-org/gitlab-ce!15502
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/39821
/<namespace>/<project>/commmits/master
|
| |\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | | |
Remove a useless `allow_failure: no` and use `true` instead of `yes`
See merge request gitlab-org/gitlab-ce!15491
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Update gRPC to v1.7.2
Closes gitaly#742
See merge request gitlab-org/gitlab-ce!15439
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This solves a problem where Gitaly connections through Unix sockets
would not work when a proxy was configures, even if a no_proxy setting
was specified
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
remove the rake task `gitlab:sidekiq:drop_post_receive`
Closes #40290
See merge request gitlab-org/gitlab-ce!15493
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
This task is no longer being used and is not documented.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fix merge_requests.source_project_id migration
See merge request gitlab-org/gitlab-ce!15496
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
We need to make sure merge_requests.source_project_id allows NULL values
_before_ updating rows as otherwise this will lead to a NOT NULL
constraint failing.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[CE] Impersonation no longer gets stuck on password change.
Closes #13888
See merge request gitlab-org/gitlab-ce!15497
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[ci skip]
|
| | |/ / / / / / |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Add inline editing to issues on mobile
Closes #39497
See merge request gitlab-org/gitlab-ce!15438
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/39497
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Align retry button with job title with new grid size
Closes #40342
See merge request gitlab-org/gitlab-ce!15462
|
| |/ / / / / / / / |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Fix bitbucket wiki import with hashed storage enabled
Closes #40292
See merge request gitlab-org/gitlab-ce!15490
|
| | | |_|/ / / / /
| |/| | | | | | |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
improve requirements details
See merge request gitlab-org/gitlab-ce!15265
|
| | | | | | | | | | |
|
| |\ \ \ \ \ \ \ \ \
| |_|_|_|/ / / / /
|/| | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Clarify wording of protected branch settings for the default branch
See merge request gitlab-org/gitlab-ce!15492
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
No-one is allowed to force push to a protected branch, or delete it. That's
correct in the documentation, but was wrong in the drop-down.
|
| |\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Make Issue Boards sidebar subscriptions async
Closes #39167 and #40094
See merge request gitlab-org/gitlab-ce!15364
|
| | | | | | | | | | | |
|
| | | |_|_|_|/ / / /
| |/| | | | | | | |
|
| |\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Implement a workaround for QA mattermost failures
Closes gitlab-qa#102
See merge request gitlab-org/gitlab-ce!15486
|
| | |/ / / / / / / / |
|
| |\ \ \ \ \ \ \ \ \
| |_|_|_|_|_|/ / /
|/| | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Remove pretty time from main.js
See merge request gitlab-org/gitlab-ce!15459
|
| |/ / / / / / / / |
|
| |\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | | |
Add Docker binaries to instance image of GitLab QA
See merge request gitlab-org/gitlab-ce!15489
|
| | |/ / / / / / |
|
| |\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Incorporate Gitaly's RefService.DeleteRefs RPC
Closes gitaly#740
See merge request gitlab-org/gitlab-ce!15460
|
| | | | | | | | |
|
