| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Without this change, we get a NoMethodError on nil
|
|\
| |
| |
| |
| |
| |
| | |
Fix outbound_local_requests_whitelist nil for existing ApplicationSetting records
Closes #65096
See merge request gitlab-org/gitlab-ce!31123
|
|/
|
|
| |
It needs to default to an empty array logically.
|
|\
| |
| |
| |
| | |
Add doc about incident issue labels
See merge request gitlab-org/gitlab-ce!31107
|
|/ |
|
|\
| |
| |
| |
| | |
Add namespace label toggle
See merge request gitlab-org/gitlab-ce!30935
|
|/
|
|
| |
Added the ability to update the namespace label text for gitlab-managed
|
|\
| |
| |
| |
| | |
Add frozen_string_literal to spec/support
See merge request gitlab-org/gitlab-ce!31132
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was shown in specs but surely this will be happening in application
code as well if this method is passes a frozen string.
We were also trying to force_encode a OmniAuth::AuthHash which had the
very confusing behaviour of returning nil when it was sent a method that
it did not define. Fix that by only force_encoding a String.
|
| | |
|
| |
| |
| |
| |
| | |
Using the sed script from
https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
|
|\ \
| | |
| | |
| | |
| | | |
Remove \ from unicorn\_stderr.log
See merge request gitlab-org/gitlab-ce!31159
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
Support title and desc on merge w/ push option
See merge request gitlab-org/gitlab-ce!31068
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
MergeRequests::PushOptionsHandlerService has been updated to allow
creating and updating merge requests with the `title` and
`description` set using git push options.
To create a new merge request and set its title and description:
git push -u origin -o merge_request.create \
-o merge_request.title="My title" \
-o merge_request.description="My description"
To update an existing merge request and set its title and
description:
git push -u origin -o merge_request.title="My title" \
-o merge_request.description="My description"
Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/64320
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Resolve "table_exists? not compatible with Rails 5.1"
Closes #54478
See merge request gitlab-org/gitlab-ce!30832
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Changes all calls to data_source_exists? to table_exists?
since that is the intent of these calls
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Remove duplicate content about auto-devops customization
See merge request gitlab-org/gitlab-ce!30929
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Update guidance for EE doc submissions
See merge request gitlab-org/gitlab-ce!31042
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Note GitLab University may be out of date in parts
See merge request gitlab-org/gitlab-ce!31034
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Update documentation for current state
Closes #64710
See merge request gitlab-org/gitlab-ce!30873
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'qa-stop-printing-dots-while-retrieving-pod-names-in-review-deploy' into 'master'
Stop printing dots while retrieving pod in review-apps.sh
See merge request gitlab-org/gitlab-ce!31062
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Improve steps for setting commit email
Closes #54881
See merge request gitlab-org/gitlab-ce!30833
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Refine topics for Phase 2 of SSoT audit
Closes #64682
See merge request gitlab-org/gitlab-ce!30831
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Includes admin_area and application_security
topics.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Restructure project cluster topic
See merge request gitlab-org/gitlab-ce!31081
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Also fixes links to section headings that
have changed.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Add a section of examples to code review docs
Closes #64194
See merge request gitlab-org/gitlab-ce!30825
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We have a fairly good guide to Code Reviews, but can be improved
by adding a few examples of what a good code review looks like
at GitLab, specifically ones where there is a bit of back and
forth, "nit-picking," etc. This would:
+ help set expectations of newly hired engineers around what our
process looks like when it is functioning what level of scrutiny
their code will be under
+ how we have technical conversations
+ show by example how after you're done crafting a solution, there
can still be extra work done either tidying up code and/or managing
the communication and conversations about your proposed MR
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fix typo in param name
See merge request gitlab-org/gitlab-ce!31100
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Clarify difference between project name and project path for API usage
See merge request gitlab-org/gitlab-ce!31019
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Support Docker OCI images
Closes gitlab-ee#12877 and #58685
See merge request gitlab-org/gitlab-ce!31127
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Docker Distribution v2.7.0 shipped with OCI support, but our container
registry client was not updated to handle the manifest format in the
HTTP `Accept` header. As a result, API calls to retrieve a manifest
would return with an error, "OCI manifest found, but accept header does
not support OCI manifests". This would result in blank fields in the
container registry page and prevent tags from being deleted.
To fix this, we just need to add
`application/vnd.oci.image.manifest.v1+json` to the `Accept` header and
configure Faraday to parse the response as JSON. The response structure
is the same as the standard Docker Distribution V2 manifest.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58685
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/12877
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Vue-i18n: Autofix additional i18n lints for vue files
See merge request gitlab-org/gitlab-ce!31125
|
|/ / / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Autofixes additional linting errors
found in vue files.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Refactor usage data counters specs
See merge request gitlab-org/gitlab-ce!31013
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
This makes these tests available for other implementations
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
[CE] Create serializer for Jira API JSON payload
See merge request gitlab-org/gitlab-ce!31139
|
| | | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Revert "Workaround for Rails 5, where LIMIT..."
See merge request gitlab-org/gitlab-ce!30780
|
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
This reverts commit 6823e7defb45dfd86d5258b40d6f82482d1ef451.
Originally implemented in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21839, but an
error was reported in
https://gitlab.com/gitlab-org/gitlab-ce/issues/51729 resulting in a
workaround introduced in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21879.
Now Rails 5.2 is used, this workaround no longer seems needed, so this
reverts it.
|
|\ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Return an ETag header for the archive endpoint
See merge request gitlab-org/gitlab-ce!30581
|