summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Randomize metrics sample intervalsconfigure-randomize-metrics-sample-intervalYorick Peterse2016-01-132-4/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Sampling data at a fixed interval means we can potentially miss data from events occurring between sampling intervals. For example, say we sample data every 15 seconds but Unicorn workers get killed after 10 seconds. In this particular case it's possible to miss interesting data as the sampler will never get to actually submitting data. To work around this (at least for the most part) the sampling interval is randomized as following: 1. Take the user specified sampling interval (15 seconds by default) 2. Divide it by 2 (referred to as "half" below) 3. Generate a range (using a step of 0.1) from -"half" to "half" 4. Every time the sampler goes to sleep we'll grab the user provided interval and add a randomly chosen "adjustment" to it while making sure we don't pick the same value twice in a row. For a specified timeout of 15 this means the actual intervals can be anywhere between 7.5 and 22.5, but never can the same interval be used twice in a row. The rationale behind this change is that on dev.gitlab.org I'm sometimes seeing certain Gitlab::Git/Rugged objects being retained, but only for a few minutes every 24 hours. Knowing the code of Gitlab and how much memory it uses/leaks I suspect we're missing data due to workers getting terminated before the sampler can write its data to InfluxDB.
* Make the metrics sampler interval configurableYorick Peterse2016-01-136-255/+272
|
* Merge branch 'remove-application-frames-from-views' into 'master' Yorick Peterse2016-01-124-40/+2
|\ | | | | See merge request !2392
| * Stop tracking call stacks for instrumented viewsremove-application-frames-from-viewsYorick Peterse2016-01-124-40/+2
| | | | | | | | | | | | | | Where a vew is called from doesn't matter as much. We already know what action they belong to and this is more than enough information. By removing the file/line number from the list of tags we should also be able to reduce the number of series stored in InfluxDB.
* | Merge branch 'add_make' into 'master' Achilleas Pipinellis2016-01-121-0/+1
|\ \ | | | | | | | | | | | | | | | | | | added make command to docs The gitlab-workhose update docs are missing a make command See merge request !2281
| * | added make command to docsChristian Mehlmauer2016-01-041-0/+1
| | |
* | | Merge branch 'allocated-memory-per-transaction' into 'master' Yorick Peterse2016-01-122-7/+37
|\ \ \ | | | | | | | | See merge request !2389
| * | | Track memory allocated during a transactionYorick Peterse2016-01-122-7/+37
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | This gives a very rough estimate of how much memory is allocated during a transaction. This only works reliably when using a single-threaded application server and a Ruby implementation with a GIL as otherwise memory allocated by other threads might skew the statistics. Sadly there's no way around this as Ruby doesn't provide a reliable way of gathering accurate object sizes upon allocation on a per-thread basis.
* | | Merge branch 'show-ip-addresses' into 'master' Dmitriy Zaporozhets2016-01-122-0/+17
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add user's last used IP addresses to admin page This would help admins figure out from where spam is originating. Screenshot: ![image](/uploads/984005a3a35b7004bd0a363081eb53ba/image.png) See merge request !2381
| * | | Add user's last used IP addresses to admin pageStan Hu2016-01-122-0/+17
| | | | | | | | | | | | | | | | This would help admins figure out from where spam is originating.
* | | | Merge branch 'improve_button_styles' into 'master' Dmitriy Zaporozhets2016-01-123-4/+4
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve button styles I noticed a couple of buttons don't match the newer styles. ## Issue edit note form ### Current (cancel button is big) ![Screen_Shot_2016-01-08_at_2.18.29_PM](/uploads/c7928e6644e886090f55cb61076c9e89/Screen_Shot_2016-01-08_at_2.18.29_PM.png) ### Now ![Screen_Shot_2016-01-08_at_2.18.22_PM](/uploads/d15c3c458a08ce5a59c367c7fb379c31/Screen_Shot_2016-01-08_at_2.18.22_PM.png) ## Merge request code discussion ### Current ![Screen_Shot_2016-01-08_at_2.21.37_PM](/uploads/b970ff3e5d9ef5e62f83bb56d5505f8d/Screen_Shot_2016-01-08_at_2.21.37_PM.png) ### Now (Also changed to `btn-save` class which changes to green. This matches everything else) ![Screen_Shot_2016-01-08_at_2.22.01_PM](/uploads/ed520de72177de92efe21d236bb04d24/Screen_Shot_2016-01-08_at_2.22.01_PM.png) cc/ @jschatz1 @skyruler @creamzy See merge request !2350
| * | | Improve button stylesDrew Blessing2016-01-083-4/+4
| | | |
* | | | Merge branch 'changelog-metrics' into 'master' Yorick Peterse2016-01-121-0/+3
|\ \ \ \ | |_|/ / |/| | | See merge request !2385
| * | | Updated CHANGELOG with changes I madeYorick Peterse2016-01-121-0/+3
|/ / / | | | | | | | | | | | | | | | I forgot to add these in the respective MRs. [ci skip]
* | | Merge branch 'update-fog' into 'master' Dmitriy Zaporozhets2016-01-123-18/+65
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bump fog to 1.36.0 Updates AWS regions and fixes a number of bugs. Tested a GitLab AWS backup without any issues. Closes #4231 See merge request !2373
| * | | Bump fog to 1.36.0Stan Hu2016-01-113-18/+65
| | | | | | | | | | | | | | | | Closes #4231
* | | | Merge branch 'hover-descriptions' into 'master' Dmitriy Zaporozhets2016-01-121-5/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | adds hover titles to merge request and issue pages Fixes #5899 See merge request !2375
| * | | | adds hover titles to merge request and issue pageshover-descriptionsJacob Schatz2016-01-111-5/+9
| |/ / /
* | | | Merge branch 'active-state-on-button-makes-it-uppercase' into 'master' Dmitriy Zaporozhets2016-01-121-3/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | changes bolded on active for dropdowns, sitewide. Fixes #6056 <br/> **Note:** this change applies to all dropdowns. Currently all dropdowns using bootstrap's dropdown.js apply a bold and larger font for an active state. See merge request !2377
| * | | | changes bolded on active for dropdowns, sitewide.active-state-on-button-makes-it-uppercaseJacob Schatz2016-01-111-3/+2
| | | | |
* | | | | Merge branch 'rs-add-title-to-emoji' into 'master' Dmitriy Zaporozhets2016-01-121-3/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add title attribute to Emojis in award picker See merge request !2378
| * | | | | Add title attribute to Emojis in award pickerrs-add-title-to-emojiRobert Speicher2016-01-111-3/+6
| | | | | |
* | | | | | Merge branch 'rs-remove-coffee-filters' into 'master' Dmitriy Zaporozhets2016-01-121-0/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the `:coffee` and `:coffeescript` Haml filters See https://git.io/vztMu and http://stackoverflow.com/a/17571242/223897 See merge request !2380
| * | | | | | Remove the `:coffee` and `:coffeescript` Haml filtersrs-remove-coffee-filtersRobert Speicher2016-01-111-0/+6
|/ / / / / / | | | | | | | | | | | | | | | | | | See https://git.io/vztMu and http://stackoverflow.com/a/17571242/223897
* | | | | | Merge branch 'typo-fix' into 'master' Robert Schilling2016-01-121-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Fixed minor typo in docker documentation This change is self-explanatory. See merge request !2374
| * | | | | | [ci skip] Fixed minor typo in docker documentationJohn Galt2016-01-111-1/+1
| | |_|/ / / | |/| | | |
* | | | | | Merge branch 'rs-clear-current-timer' into 'master' Robert Speicher2016-01-111-0/+1
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Call clearInterval for the currentTimer if one exists Prevents a double-click from causing the logo to sweep forever after a load completes. See merge request !2379
| * | | | | Call clearInterval for the currentTimer if one existsRobert Speicher2016-01-111-0/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | Prevents a double-click from causing the logo to sweep forever after a load completes.
* | | | | Update CHANGELOGRobert Speicher2016-01-111-6/+6
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | Merge branch 'fix/ci-linter-sequence-validations' into 'master' Robert Speicher2016-01-114-5/+16
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | Allow subsequent validations in CI Linter Closes #5851 See merge request !2368
| * | | | Allow subsequent validations in CI Linterfix/ci-linter-sequence-validationsGrzegorz Bizon2016-01-114-5/+16
| | | | | | | | | | | | | | | | | | | | Closes #5851
* | | | | Merge branch 'fix-ci-builds-for-tags' into 'master' Robert Speicher2016-01-112-0/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Generate builds when creating tag using web interface Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/4296 See merge request !2366
| * | | | | Generate builds when creating tag using web interfacefix-ci-builds-for-tagsKamil Trzcinski2016-01-112-0/+2
| | | | | |
* | | | | | Merge branch 'gitlab-workhorse-0.5.3' into 'master' Robert Speicher2016-01-113-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use gitlab-workhorse 0.5.3 See merge request !2367
| * | | | | | Use gitlab-workhorse 0.5.3gitlab-workhorse-0.5.3Jacob Vosmaer2016-01-113-3/+3
| | | | | | |
* | | | | | | Merge branch 'optimize_ldap' into 'master' Douwe Maan2016-01-117-11/+37
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Optimize LDAP and add a search timeout Related to #4282 This merge request arranges some things in `access.rb` to facilitate some optimizations in EE (to come later). It also adds a 10 second timeout to all LDAP searches so the entire worker is not blocked if some query doesn't return in a reasonable amount of time. This timeout is configurable per LDAP server. See merge request !2267
| * | | | | | | Optimize LDAP and add a search timeoutDrew Blessing2016-01-117-11/+37
| | | | | | | |
* | | | | | | | Merge branch 'add-action-to-all-metrics' into 'master' Yorick Peterse2016-01-116-25/+41
|\ \ \ \ \ \ \ \ | |_|_|_|_|/ / / |/| | | | | | | See merge request !2370
| * | | | | | | Tag all transaction metrics with an "action" tagYorick Peterse2016-01-116-25/+41
| | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this it's impossible to find out what methods/views/queries are executed by a certain controller or Sidekiq worker. While this will increase the total number of series it should stay within reasonable limits due to the amount of "actions" being small enough.
* | | | | | | Merge branch 'rs-omniauth-client-versions' into 'master' Dmitriy Zaporozhets2016-01-112-4/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add versions to omniauth_crowd and omniauth-azure-oauth2 Also sorts them alphabetically, because OCD. See merge request !2364
| * | | | | | | Add versions to omniauth_crowd and omniauth-azure-oauth2rs-omniauth-client-versionsRobert Speicher2016-01-102-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also sorts them alphabetically, because OCD.
* | | | | | | | Merge branch 'group-issues-sorting' into 'master' Dmitriy Zaporozhets2016-01-118-13/+23
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve performance of getting issues on group level For testing I used the URL http://localhost:3000/groups/gitlab-org/issues?milestone_title=8.1. Prior to these changes said URL would take about 10-12 seconds to load. By applying these changes the loading time has been reduced to roughly 2-3 seconds. There's still some stuff going on in some views that I have to look at, resolving those changes might reduce the loading time a bit more. I also still have to check if I didn't break too many tests. Fixes: gitlab-org/gitlab-ce#3707 gitlab-org/gitlab-ce#4071 See merge request !2318
| * | | | | | | | Removed ORDER BY in "of_group" scopesgroup-issues-sortingYorick Peterse2016-01-072-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These scopes don't care about the order. Removing the explicit "ORDER BY" can speed up the queries by a little bit.
| * | | | | | | | Fixed issue sorting specs for ID changesYorick Peterse2016-01-071-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These specs assumed data was still sorted by timestamp, instead of by ID.
| * | | | | | | | Updated Gemfile.lock due to Bundler re-orderingYorick Peterse2016-01-071-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bundler keeps re-ordering this particular Gem every time something is executed using "bundle exec".
| * | | | | | | | Drop projects order in IssuableFinderYorick Peterse2016-01-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When grabbing the projects to filter issues by we don't care about the order they're returned in. By removing the ORDER BY the resulting query can be quite a bit faster.
| * | | | | | | | Don't pluck IDs when getting issues/MRs per groupYorick Peterse2016-01-072-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This replaces plucking of IDs with a sub-query, saving the overhead of loading the data in Ruby and then mapping the rows to an Array of IDs. This also scales much better when dealing with a large amount of IDs that would be involved.
| * | | | | | | | Sort by ID when sorting using "Recently created"Yorick Peterse2016-01-073-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sorting by "id" has the same effect as sorting by created_at while performing far better and without the need of an extra index (in case one wanted to speed up sorting by "created_at"). Sorting by "Recently updated" still uses the physical "updated_at" column as there's no way to use the "id" column for this instead.
| * | | | | | | | Added an index on milestones.titleYorick Peterse2016-01-071-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Certain pages (e.g. the group wide issues page) filter miletones by their title. Without an index this will result in a sequence scan on a large dataset increasing the total loading time of a page.
* | | | | | | | | Merge branch 'rs-woff-fonts' into 'master' Dmitriy Zaporozhets2016-01-1132-7/+8
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use WOFF versions of SourceSansPro See https://gitlab.com/gitlab-org/gitlab-ce/issues/6023 See merge request !2357
View Lorry Controller Status