summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Don't validate reserved words if the format doesn't match30272-bvl-reject-more-namespacesBob Van Landuyt2017-05-021-0/+1
| | | | | | Because it also won't match the sophisticated format we have for detecting reserved names. We don't want to confuse the user with 2 error messages
* Refresh the markdown cache if it was `nil`Bob Van Landuyt2017-05-022-0/+9
| | | | | If the cached html_field for a markdown_field is `nil` while the mfarkdown_field is not, it needs to be refreshed.
* Add some documentation for the new migration helpersBob Van Landuyt2017-05-021-0/+25
|
* Update commentsBob Van Landuyt2017-05-022-5/+26
|
* Add a better error message when a certain path is missingBob Van Landuyt2017-05-021-3/+34
|
* Update path validation & specsBob Van Landuyt2017-05-022-16/+58
|
* Reuse Gitlab::Regex.full_namespace_regex in the DynamicPathValidatorBob Van Landuyt2017-05-024-28/+34
|
* Rename child namespaces in migrationhelpersBob Van Landuyt2017-05-015-16/+40
|
* Reject group-routes as names of child namespacesBob Van Landuyt2017-05-015-43/+147
|
* Reject paths following namespace for paths including 2 `*`Bob Van Landuyt2017-05-012-14/+16
| | | | | Reject the part following `/*namespace_id/:project_id` for paths containing 2 wildcard parameters
* Allow `graphs` & `refs` project namesBob Van Landuyt2017-05-011-2/+0
|
* Clear html cache for a projects milestonesBob Van Landuyt2017-05-012-0/+14
|
* Remove dependecy on `User`Bob Van Landuyt2017-05-011-20/+0
|
* Move ReservedPathsMigration into V1 namespaceBob Van Landuyt2017-05-0116-378/+391
|
* Minor style adjustmentsBob Van Landuyt2017-05-014-28/+45
|
* Use `%r{}` regexes to avoid having to escape `/`Bob Van Landuyt2017-05-012-6/+6
|
* Clear cached markdown after renaming projectsBob Van Landuyt2017-05-016-6/+88
|
* Rename Projects & Namespaces based on entire pathsBob Van Landuyt2017-05-016-9/+38
|
* The dynamic path validator can block out partial pathsBob Van Landuyt2017-05-016-95/+120
| | | | So we can block `objects` only when it is contained in `info/lfs` or `gitlab-lfs`
* Rename namespaces called `Users`Bob Van Landuyt2017-05-011-0/+1
| | | | | This should rename the already created namespace that snuck trough because the validation was case sensitive
* Make path validation case-insensitiveBob Van Landuyt2017-05-012-1/+8
|
* Use objects for renaming namespaces and projectsBob Van Landuyt2017-05-0110-248/+306
|
* Add a WIP spec for clearing the cacheBob Van Landuyt2017-05-012-0/+4
|
* Rename projects in a migrationhelperBob Van Landuyt2017-05-016-62/+201
|
* Make renaming records in the database reusableBob Van Landuyt2017-05-015-94/+174
| | | | So we can use it for projects
* Rename forbidden paths in a single migrationBob Van Landuyt2017-05-016-958/+39
|
* Rename namespace-paths in a migration helperBob Van Landuyt2017-05-015-0/+469
|
* Reject `-` as a pathBob Van Landuyt2017-05-011-0/+1
|
* Move `replace_sql` into `Database::MigrationHelpers`Bob Van Landuyt2017-05-012-0/+56
|
* Rename `NamespaceValidator` to `DynamicPathValidator`Bob Van Landuyt2017-05-018-10/+13
| | | | This reflects better that it validates paths instead of a namespace model
* Use the namespace validator for validating all pathsBob Van Landuyt2017-05-013-29/+2
| | | | | Since the namespacevalidator now knows the difference between a top-level and another path, this could all be handled there.
* Check `has_parent?` for determining validation typeBob Van Landuyt2017-05-013-3/+8
|
* Split off validating full pathsBob Van Landuyt2017-05-012-6/+28
| | | | | The first part of a full path needs to be validated as a `top_level` while the rest need to be validated as `wildcard`
* Improve detection of reserved words from routesBob Van Landuyt2017-05-012-27/+69
|
* Streamline the path validation in groups & projectsBob Van Landuyt2017-05-019-61/+167
| | | | | | | | | | | | `Project` uses `ProjectPathValidator` which is now a `NamespaceValidator` that skips the format validation. That way we're sure we are using the same collection of reserved paths. I updated the path constraints to reflect the changes: We now allow some values that are only used on a top level namespace as a name for a nested group/project.
* Add forbidden paths to the namespace validatorBob Van Landuyt2017-05-012-1/+42
|
* Add migration to rename all namespaces with forbidden nameBob Van Landuyt2017-05-015-0/+958
| | | | | | This is based on a migration in https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2073 Rename forbidden child namespaces
* Disallow some more namespacesBob Van Landuyt2017-05-012-0/+20
| | | | These routes seem to be taken
* Merge branch 'rs-add_column_with_default_cops' into 'master' Sean McGivern2017-05-0116-13/+121
|\ | | | | | | | | | | | | Add cop to blacklist specific tables for `add_column_with_default` Closes #31293 See merge request !10892
| * Disable AddColumnWithDefaultToLargeTable cop for pre-existing migrationsrs-add_column_with_default_copsRobert Speicher2017-04-2811-0/+11
| |
| * Add AddColumnWithDefaultToLargeTable copRobert Speicher2017-04-283-0/+96
| |
| * Rename AddColumnWithDefault to ReversibleAddColumnWithDefaultRobert Speicher2017-04-283-4/+4
| | | | | | | | | | We're going to add another cop that deals with another aspect of `add_column_with_default`, so we need to separate them.
| * Refactor the AddColumnWithDefault cop to use node matchersRobert Speicher2017-04-281-9/+10
| |
* | Merge branch 'patch-18' into 'master' Douwe Maan2017-04-301-1/+1
|\ \ | | | | | | | | | | | | Fix typo See merge request !11003
| * | Fix typoTsvi Mostovicz2017-04-301-1/+1
|/ /
* | Merge branch 'revert-c3c465ac' into 'master' Robert Speicher2017-04-296-48/+30
|\ \ | | | | | | | | | | | | Revert "Merge branch 'tc-no-todo-service-select' into 'master'" See merge request !10997
| * | Revert "Merge branch 'tc-no-todo-service-select' into 'master'"revert-c3c465acStan Hu2017-04-296-48/+30
|/ / | | | | This reverts merge request !10845
* | Merge branch '31595-emoji-btn' into 'master' Alfredo Sumaran2017-04-291-2/+2
|\ \ | | | | | | | | | | | | | | | | | | Fix emoji alignment Closes #31595 See merge request !10993
| * | Fix emoji alignment31595-emoji-btnAnnabel Dunstone Gray2017-04-281-2/+2
| |/
* | Merge branch 'patch-21' into 'master' Stan Hu2017-04-291-1/+1
|\ \ | | | | | | | | | | | | fix link in health check docs See merge request !10996