Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Don't validate reserved words if the format doesn't match30272-bvl-reject-more-namespaces | Bob Van Landuyt | 2017-05-02 | 1 | -0/+1 |
| | | | | | | Because it also won't match the sophisticated format we have for detecting reserved names. We don't want to confuse the user with 2 error messages | ||||
* | Refresh the markdown cache if it was `nil` | Bob Van Landuyt | 2017-05-02 | 2 | -0/+9 |
| | | | | | If the cached html_field for a markdown_field is `nil` while the mfarkdown_field is not, it needs to be refreshed. | ||||
* | Add some documentation for the new migration helpers | Bob Van Landuyt | 2017-05-02 | 1 | -0/+25 |
| | |||||
* | Update comments | Bob Van Landuyt | 2017-05-02 | 2 | -5/+26 |
| | |||||
* | Add a better error message when a certain path is missing | Bob Van Landuyt | 2017-05-02 | 1 | -3/+34 |
| | |||||
* | Update path validation & specs | Bob Van Landuyt | 2017-05-02 | 2 | -16/+58 |
| | |||||
* | Reuse Gitlab::Regex.full_namespace_regex in the DynamicPathValidator | Bob Van Landuyt | 2017-05-02 | 4 | -28/+34 |
| | |||||
* | Rename child namespaces in migrationhelpers | Bob Van Landuyt | 2017-05-01 | 5 | -16/+40 |
| | |||||
* | Reject group-routes as names of child namespaces | Bob Van Landuyt | 2017-05-01 | 5 | -43/+147 |
| | |||||
* | Reject paths following namespace for paths including 2 `*` | Bob Van Landuyt | 2017-05-01 | 2 | -14/+16 |
| | | | | | Reject the part following `/*namespace_id/:project_id` for paths containing 2 wildcard parameters | ||||
* | Allow `graphs` & `refs` project names | Bob Van Landuyt | 2017-05-01 | 1 | -2/+0 |
| | |||||
* | Clear html cache for a projects milestones | Bob Van Landuyt | 2017-05-01 | 2 | -0/+14 |
| | |||||
* | Remove dependecy on `User` | Bob Van Landuyt | 2017-05-01 | 1 | -20/+0 |
| | |||||
* | Move ReservedPathsMigration into V1 namespace | Bob Van Landuyt | 2017-05-01 | 16 | -378/+391 |
| | |||||
* | Minor style adjustments | Bob Van Landuyt | 2017-05-01 | 4 | -28/+45 |
| | |||||
* | Use `%r{}` regexes to avoid having to escape `/` | Bob Van Landuyt | 2017-05-01 | 2 | -6/+6 |
| | |||||
* | Clear cached markdown after renaming projects | Bob Van Landuyt | 2017-05-01 | 6 | -6/+88 |
| | |||||
* | Rename Projects & Namespaces based on entire paths | Bob Van Landuyt | 2017-05-01 | 6 | -9/+38 |
| | |||||
* | The dynamic path validator can block out partial paths | Bob Van Landuyt | 2017-05-01 | 6 | -95/+120 |
| | | | | So we can block `objects` only when it is contained in `info/lfs` or `gitlab-lfs` | ||||
* | Rename namespaces called `Users` | Bob Van Landuyt | 2017-05-01 | 1 | -0/+1 |
| | | | | | This should rename the already created namespace that snuck trough because the validation was case sensitive | ||||
* | Make path validation case-insensitive | Bob Van Landuyt | 2017-05-01 | 2 | -1/+8 |
| | |||||
* | Use objects for renaming namespaces and projects | Bob Van Landuyt | 2017-05-01 | 10 | -248/+306 |
| | |||||
* | Add a WIP spec for clearing the cache | Bob Van Landuyt | 2017-05-01 | 2 | -0/+4 |
| | |||||
* | Rename projects in a migrationhelper | Bob Van Landuyt | 2017-05-01 | 6 | -62/+201 |
| | |||||
* | Make renaming records in the database reusable | Bob Van Landuyt | 2017-05-01 | 5 | -94/+174 |
| | | | | So we can use it for projects | ||||
* | Rename forbidden paths in a single migration | Bob Van Landuyt | 2017-05-01 | 6 | -958/+39 |
| | |||||
* | Rename namespace-paths in a migration helper | Bob Van Landuyt | 2017-05-01 | 5 | -0/+469 |
| | |||||
* | Reject `-` as a path | Bob Van Landuyt | 2017-05-01 | 1 | -0/+1 |
| | |||||
* | Move `replace_sql` into `Database::MigrationHelpers` | Bob Van Landuyt | 2017-05-01 | 2 | -0/+56 |
| | |||||
* | Rename `NamespaceValidator` to `DynamicPathValidator` | Bob Van Landuyt | 2017-05-01 | 8 | -10/+13 |
| | | | | This reflects better that it validates paths instead of a namespace model | ||||
* | Use the namespace validator for validating all paths | Bob Van Landuyt | 2017-05-01 | 3 | -29/+2 |
| | | | | | Since the namespacevalidator now knows the difference between a top-level and another path, this could all be handled there. | ||||
* | Check `has_parent?` for determining validation type | Bob Van Landuyt | 2017-05-01 | 3 | -3/+8 |
| | |||||
* | Split off validating full paths | Bob Van Landuyt | 2017-05-01 | 2 | -6/+28 |
| | | | | | The first part of a full path needs to be validated as a `top_level` while the rest need to be validated as `wildcard` | ||||
* | Improve detection of reserved words from routes | Bob Van Landuyt | 2017-05-01 | 2 | -27/+69 |
| | |||||
* | Streamline the path validation in groups & projects | Bob Van Landuyt | 2017-05-01 | 9 | -61/+167 |
| | | | | | | | | | | | | `Project` uses `ProjectPathValidator` which is now a `NamespaceValidator` that skips the format validation. That way we're sure we are using the same collection of reserved paths. I updated the path constraints to reflect the changes: We now allow some values that are only used on a top level namespace as a name for a nested group/project. | ||||
* | Add forbidden paths to the namespace validator | Bob Van Landuyt | 2017-05-01 | 2 | -1/+42 |
| | |||||
* | Add migration to rename all namespaces with forbidden name | Bob Van Landuyt | 2017-05-01 | 5 | -0/+958 |
| | | | | | | This is based on a migration in https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2073 Rename forbidden child namespaces | ||||
* | Disallow some more namespaces | Bob Van Landuyt | 2017-05-01 | 2 | -0/+20 |
| | | | | These routes seem to be taken | ||||
* | Merge branch 'rs-add_column_with_default_cops' into 'master' | Sean McGivern | 2017-05-01 | 16 | -13/+121 |
|\ | | | | | | | | | | | | | Add cop to blacklist specific tables for `add_column_with_default` Closes #31293 See merge request !10892 | ||||
| * | Disable AddColumnWithDefaultToLargeTable cop for pre-existing migrationsrs-add_column_with_default_cops | Robert Speicher | 2017-04-28 | 11 | -0/+11 |
| | | |||||
| * | Add AddColumnWithDefaultToLargeTable cop | Robert Speicher | 2017-04-28 | 3 | -0/+96 |
| | | |||||
| * | Rename AddColumnWithDefault to ReversibleAddColumnWithDefault | Robert Speicher | 2017-04-28 | 3 | -4/+4 |
| | | | | | | | | | | We're going to add another cop that deals with another aspect of `add_column_with_default`, so we need to separate them. | ||||
| * | Refactor the AddColumnWithDefault cop to use node matchers | Robert Speicher | 2017-04-28 | 1 | -9/+10 |
| | | |||||
* | | Merge branch 'patch-18' into 'master' | Douwe Maan | 2017-04-30 | 1 | -1/+1 |
|\ \ | | | | | | | | | | | | | Fix typo See merge request !11003 | ||||
| * | | Fix typo | Tsvi Mostovicz | 2017-04-30 | 1 | -1/+1 |
|/ / | |||||
* | | Merge branch 'revert-c3c465ac' into 'master' | Robert Speicher | 2017-04-29 | 6 | -48/+30 |
|\ \ | | | | | | | | | | | | | Revert "Merge branch 'tc-no-todo-service-select' into 'master'" See merge request !10997 | ||||
| * | | Revert "Merge branch 'tc-no-todo-service-select' into 'master'"revert-c3c465ac | Stan Hu | 2017-04-29 | 6 | -48/+30 |
|/ / | | | | | This reverts merge request !10845 | ||||
* | | Merge branch '31595-emoji-btn' into 'master' | Alfredo Sumaran | 2017-04-29 | 1 | -2/+2 |
|\ \ | | | | | | | | | | | | | | | | | | | Fix emoji alignment Closes #31595 See merge request !10993 | ||||
| * | | Fix emoji alignment31595-emoji-btn | Annabel Dunstone Gray | 2017-04-28 | 1 | -2/+2 |
| |/ | |||||
* | | Merge branch 'patch-21' into 'master' | Stan Hu | 2017-04-29 | 1 | -1/+1 |
|\ \ | | | | | | | | | | | | | fix link in health check docs See merge request !10996 |