Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Enable RSpec/DescribeSymbol; update .rubocop_todo.yml | Robert Speicher | 2017-04-07 | 1 | -50/+76 |
| | |||||
* | Enable Style/Proc cop for rubocop | mhasbini | 2017-04-02 | 1 | -5/+0 |
| | |||||
* | Revert "Enable Style/DotPosition" | Douwe Maan | 2017-02-23 | 1 | -1/+8 |
| | | | | | | | | | | | | | | | This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9. # Conflicts: # .rubocop.yml # .rubocop_todo.yml # lib/gitlab/ci/config/entry/global.rb # lib/gitlab/ci/config/entry/jobs.rb # spec/lib/gitlab/ci/config/entry/factory_spec.rb # spec/lib/gitlab/ci/config/entry/global_spec.rb # spec/lib/gitlab/ci/config/entry/job_spec.rb # spec/lib/gitlab/ci/status/build/factory_spec.rb # spec/lib/gitlab/incoming_email_spec.rb | ||||
* | Revert "Enable Style/BarePercentLiterals" | Douwe Maan | 2017-02-23 | 1 | -0/+7 |
| | | | | This reverts commit 96bef54154e669f9a3e92c3a4bc76c0be3a52e48. | ||||
* | Update rubocop and rubocop-rspec and regenerate .rubocop_todo.yml | Douwe Maan | 2017-02-23 | 1 | -5/+1 |
| | |||||
* | Update rubocop and rubocop-rspec and regenerate .rubocop_todo.yml | Douwe Maan | 2017-02-23 | 1 | -46/+65 |
| | |||||
* | Regenerate .rubocop_todo.yml | Douwe Maan | 2017-02-23 | 1 | -276/+61 |
| | |||||
* | Enable Style/ConditionalAssignment | Douwe Maan | 2017-02-23 | 1 | -7/+0 |
| | |||||
* | Enable Style/ColonMethodCall | Douwe Maan | 2017-02-23 | 1 | -5/+0 |
| | |||||
* | Disable Style/BracesAroundHashParameters | Douwe Maan | 2017-02-23 | 1 | -7/+0 |
| | |||||
* | Enable Style/BarePercentLiterals | Douwe Maan | 2017-02-23 | 1 | -7/+0 |
| | |||||
* | Enable Security/JSONLoad | Douwe Maan | 2017-02-23 | 1 | -12/+0 |
| | |||||
* | Enable Rails/Validation | Douwe Maan | 2017-02-23 | 1 | -17/+0 |
| | |||||
* | Disable Rails/DynamicFindBy | Douwe Maan | 2017-02-23 | 1 | -7/+0 |
| | |||||
* | Enable Performance/RedundantMatch | Douwe Maan | 2017-02-23 | 1 | -10/+0 |
| | |||||
* | Enable Performance/RedundantBlockCall | Douwe Maan | 2017-02-23 | 1 | -8/+0 |
| | |||||
* | Disable Lint/UnneededSplatExpansion | Douwe Maan | 2017-02-23 | 1 | -17/+0 |
| | |||||
* | Enable Lint/UnifiedInteger | Douwe Maan | 2017-02-23 | 1 | -10/+0 |
| | |||||
* | Enable Performance/RedundantMerge | Douwe Maan | 2017-02-23 | 1 | -6/+0 |
| | |||||
* | Disable some more cops | Douwe Maan | 2017-02-23 | 1 | -104/+0 |
| | |||||
* | Disable a few RSpec cops | Douwe Maan | 2017-02-23 | 1 | -63/+0 |
| | |||||
* | Disable Lint/UnusedMethodArgument | Douwe Maan | 2017-02-23 | 1 | -6/+0 |
| | |||||
* | Disable Style/TrailingCommaInLiteral | Douwe Maan | 2017-02-23 | 1 | -7/+0 |
| | |||||
* | Enable Style/SpaceInsideBrackets | Douwe Maan | 2017-02-23 | 1 | -5/+0 |
| | |||||
* | Enable Style/MutableConstant | Douwe Maan | 2017-02-23 | 1 | -5/+0 |
| | |||||
* | Enable Style/DotPosition | Douwe Maan | 2017-02-23 | 1 | -7/+0 |
| | |||||
* | Update .rubocop_todo.yml | Douwe Maan | 2017-02-23 | 1 | -128/+445 |
| | |||||
* | No more and/or | Douwe Maan | 2017-02-21 | 1 | -7/+0 |
| | |||||
* | Enable `Lint/EmptyWhen` cop and correct offense | Robert Speicher | 2017-02-13 | 1 | -4/+0 |
| | |||||
* | Enable `Style/RedundantException` cop and correct offense | Robert Speicher | 2017-02-10 | 1 | -5/+0 |
| | |||||
* | Enable the `RSpec/ExpectActual` cop and correct offenses | Robert Speicher | 2017-02-10 | 1 | -4/+0 |
| | |||||
* | Explicitly disable the RSpec/BeEql cop | Robert Speicher | 2017-02-10 | 1 | -4/+0 |
| | | | | This is a little too picky, even for us. | ||||
* | Disable all cops in .rubocop_todo.ymlrubocop-todo | Sean McGivern | 2017-01-17 | 1 | -2/+2 |
| | | | | | | Cops with a max level are auto-generated with that set to the current maximum, even when they're supposed to be ignored. For now, the best option is to manually disable them. | ||||
* | Fix Rubocop YAML config files to avoid CE->EE issues | Grzegorz Bizon | 2017-01-11 | 1 | -406/+85 |
| | |||||
* | Update rubocop and rubocop-rspec to fix build errorsupdate-rubocop | Brian Neel | 2017-01-06 | 1 | -134/+521 |
| | |||||
* | Update RuboCop to 0.43.0 and update configurationrs-update-rubocop | Robert Speicher | 2016-10-04 | 1 | -51/+120 |
| | | | | | `Style/VariableNumber` is explicitly disabled because I don't think we care if we name a variable `var_1` or `var1`. | ||||
* | Enable Lint/StringConversionInInterpolation cop and autocorrect offensesrs-string-conversion-in-interpolation | Robert Speicher | 2016-10-03 | 1 | -5/+0 |
| | |||||
* | Regenerate .rubocop_todo.yml based on rubocop 0.42.0 | Robert Speicher | 2016-09-14 | 1 | -53/+72 |
| | |||||
* | Enable Style/SpaceAroundEqualsInParameterDefault coprubocop/SpaceAroundEqualsInParameterDefault | Gabriel Mazetto | 2016-08-06 | 1 | -7/+0 |
| | |||||
* | Merge branch 'rubocop/enable-access-modifiers-cops' into 'master' | Robert Speicher | 2016-07-29 | 1 | -8/+0 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable Rubocop cops that check access modifiers ## What does this MR do? This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly. This also fixes existing offenses. ## Why was this MR needed? Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis. ## What are the relevant issue numbers? See #17478 Closes #17372 See merge request !5014 | ||||
| * | Enable Rubocop cops for invalid access modifiersrubocop/enable-access-modifiers-cops | Grzegorz Bizon | 2016-07-19 | 1 | -8/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This enables following cops: Check for useless access modifiers Lint/UselessAccessModifier Checks for attempts to use `private` or `protected` to set the visibility of a class method, which does not work. Lint/IneffectiveAccessModifier This also disables two false possitives in concerns. | ||||
* | | Enable Style/MultilineTernaryOperator rubocop coprubocop/enable-multiline-ternary-operator-cop | Grzegorz Bizon | 2016-07-20 | 1 | -4/+0 |
|/ | | | | | | Avoid multi-line ?: (the ternary operator). Use if/unless instead. See #17478 | ||||
* | Disable all cops with offenses. | Connor Shea | 2016-07-13 | 1 | -149/+34 |
| | |||||
* | Resolve feedback. | Connor Shea | 2016-07-13 | 1 | -53/+42 |
| | |||||
* | Disable two cops as recommended. | Connor Shea | 2016-07-13 | 1 | -26/+16 |
| | |||||
* | Remove some disabled cops. | Connor Shea | 2016-07-13 | 1 | -17/+550 |
| | |||||
* | Update rubocop to 0.41.2 | Z.J. van de Weg | 2016-07-13 | 1 | -0/+65 |
https://github.com/bbatsov/rubocop/blob/v0.41.2/CHANGELOG.md |