summaryrefslogtreecommitdiff
path: root/.rubocop.yml
Commit message (Collapse)AuthorAgeFilesLines
...
* | Enable Style/ClassCheckDouwe Maan2017-02-231-1/+1
| |
* | Prefer leading style for Style/DotPositionDouwe Maan2017-02-231-1/+1
| |
* | Enable Style/ConditionalAssignmentDouwe Maan2017-02-231-0/+3
| |
* | Enable Style/ColonMethodCallDouwe Maan2017-02-231-0/+3
| |
* | Disable Style/BracesAroundHashParametersDouwe Maan2017-02-231-1/+3
| |
* | Enable Style/BarePercentLiteralsDouwe Maan2017-02-231-0/+4
| |
* | Enable Security/JSONLoadDouwe Maan2017-02-231-0/+3
| |
* | Enable Rails/ValidationDouwe Maan2017-02-231-0/+3
| |
* | Disable Rails/OutputSafetyDouwe Maan2017-02-231-0/+3
| |
* | Disable Rails/DynamicFindByDouwe Maan2017-02-231-0/+3
| |
* | Enable Performance/RedundantMatchDouwe Maan2017-02-231-0/+3
| |
* | Enable Performance/RedundantBlockCallDouwe Maan2017-02-231-0/+3
| |
* | Disable Lint/UnneededSplatExpansionDouwe Maan2017-02-231-0/+2
| |
* | Enable Lint/UnifiedIntegerDouwe Maan2017-02-231-0/+4
| |
* | Enable Performance/RedundantMergeDouwe Maan2017-02-231-0/+4
| |
* | Disable some more copsDouwe Maan2017-02-231-0/+42
| |
* | Disable a few RSpec copsDouwe Maan2017-02-231-0/+27
| |
* | Custom cops don’t need to be mentioned in .rubocop.ymlDouwe Maan2017-02-231-6/+0
| |
* | Disable Lint/UnusedMethodArgumentDouwe Maan2017-02-231-0/+3
| |
* | Disable Style/TrailingCommaInLiteralDouwe Maan2017-02-231-0/+3
| |
* | Enable Style/SpaceInsideBracketsDouwe Maan2017-02-231-0/+3
| |
* | Enable Style/MutableConstantDouwe Maan2017-02-231-0/+3
| |
* | Enable Style/DotPositionDouwe Maan2017-02-231-0/+4
|/
* No more and/orDouwe Maan2017-02-211-0/+5
|
* Merge branch 'rs-rubocop-rspec' into 'master' Rémy Coutable2017-02-131-0/+16
|\ | | | | | | | | Enable Style/RedundantException, Lint/EmptyWhen, and RSpec/ExpectActual cops See merge request !9151
| * Enable `Lint/EmptyWhen` cop and correct offenseRobert Speicher2017-02-131-0/+4
| |
| * Enable `Style/RedundantException` cop and correct offenseRobert Speicher2017-02-101-0/+4
| |
| * Enable the `RSpec/ExpectActual` cop and correct offensesRobert Speicher2017-02-101-0/+4
| |
| * Explicitly disable the RSpec/BeEql copRobert Speicher2017-02-101-0/+4
| | | | | | | | This is a little too picky, even for us.
* | Merge branch 'zj-drop-ruby-21-tests' into 'master' Rémy Coutable2017-02-131-1/+1
|\ \ | |/ |/| | | | | Update Rubocop to Ruby 2.3 See merge request !8994
| * Update Rubocop to ruby 2.3zj-drop-ruby-21-testsZ.J. van de Weg2017-02-071-1/+1
| |
* | Add a spec for our custom GemFetcher coprs-gemfetcher-cop-specRobert Speicher2017-02-091-10/+12
|/
* ignore node_modules in rubocoprubocop-ignore-node-modulesMike Greiling2017-02-021-0/+1
|
* Fix Rubocop YAML config files to avoid CE->EE issuesGrzegorz Bizon2017-01-111-4/+0
|
* Enable Style/MultilineOperationIndentation in Rubocop, fixes #25741Rydkin Maxim2016-12-161-1/+2
|
* Change target Ruby version for Rubocop to 2.1.change-rubocop-to-2-1Adam Niedzielski2016-10-201-1/+1
| | | | | | | We have to use the lowest common denominator to check the supported syntax and in our case it is Ruby 2.1. Please note that it will not help with unsupported syntax in HAML files because they are not checked by Rubocop.
* Update RuboCop to 0.43.0 and update configurationrs-update-rubocopRobert Speicher2016-10-041-0/+4
| | | | | `Style/VariableNumber` is explicitly disabled because I don't think we care if we name a variable `var_1` or `var1`.
* Enable Lint/StringConversionInInterpolation cop and autocorrect offensesrs-string-conversion-in-interpolationRobert Speicher2016-10-031-0/+4
|
* Revert "Merge branch 'rs-update-rubocop-rspec' into 'master'"rs-revert-rubocop-rspec-1-7Robert Speicher2016-09-211-67/+10
| | | | | This reverts commit 70faf5fdfbfa0e427b12d4181a9302394974c3cf, reversing changes made to 2307eb84dcd1748cc231719017551111310d1bf9.
* Update `.rubocop.yml` for rubocop-rspec 1.7.0rs-update-rubocop-rspecRobert Speicher2016-09-151-10/+67
|
* Rubocop syntax 2.3Z.J. van de Weg2016-09-011-2/+5
|
* Merge branch 'rubocop/enable-more-cops-for-empty-lines' into 'master' Robert Speicher2016-08-081-2/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable some Rubocop cops related to new lines ## What does this MR do? This MR enabled two additional Rubocop cops: Keeps track of empty lines around block bodies. `Style/EmptyLinesAroundBlockBody` Keeps track of empty lines around method bodies. ` Style/EmptyLinesAroundMethodBody` See merge request !5637
| * Enable some Rubocop cops related to new linesGrzegorz Bizon2016-08-031-2/+2
| |
* | Merge branch 'rubocop/EmptyLinesAroundModuleBody' into 'master' Douwe Maan2016-08-081-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable Style/EmptyLinesAround Module/Class Body cop ## What does this MR do? Enable a new rubocop cops as discussed here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1877/diffs#note_13021078 ## Are there points in the code the reviewer needs to double check? May be a good idea to send a message to people to prevent `master` red because of the new cop. ## Why was this MR needed? We want to improve code style and not waste endbosses time checking style manually ## What are the relevant issue numbers? ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5692
| * | Enable Style/EmptyLinesAroundClassBody coprubocop/EmptyLinesAroundModuleBodyGabriel Mazetto2016-08-061-1/+1
| | |
| * | Enable Style/EmptyLinesAroundModuleBody copGabriel Mazetto2016-08-061-1/+1
| |/
* | Enable Style/SpaceAroundEqualsInParameterDefault coprubocop/SpaceAroundEqualsInParameterDefaultGabriel Mazetto2016-08-061-0/+4
|/
* Merge branch 'rubocop/enable-access-modifiers-cops' into 'master' Robert Speicher2016-07-291-0/+9
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable Rubocop cops that check access modifiers ## What does this MR do? This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly. This also fixes existing offenses. ## Why was this MR needed? Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis. ## What are the relevant issue numbers? See #17478 Closes #17372 See merge request !5014
| * Enable Rubocop cops for invalid access modifiersrubocop/enable-access-modifiers-copsGrzegorz Bizon2016-07-191-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This enables following cops: Check for useless access modifiers Lint/UselessAccessModifier Checks for attempts to use `private` or `protected` to set the visibility of a class method, which does not work. Lint/IneffectiveAccessModifier This also disables two false possitives in concerns.
* | Enable Style/MultilineTernaryOperator rubocop coprubocop/enable-multiline-ternary-operator-copGrzegorz Bizon2016-07-201-0/+4
|/ | | | | | Avoid multi-line ?: (the ternary operator). Use if/unless instead. See #17478
View Lorry Controller Status