diff options
Diffstat (limited to 'app/helpers/notes_helper.rb')
-rw-r--r-- | app/helpers/notes_helper.rb | 34 |
1 files changed, 21 insertions, 13 deletions
diff --git a/app/helpers/notes_helper.rb b/app/helpers/notes_helper.rb index ffcc7acc8da..7a0ed251aa8 100644 --- a/app/helpers/notes_helper.rb +++ b/app/helpers/notes_helper.rb @@ -1,24 +1,32 @@ module NotesHelper - def loading_more_notes? - params[:loading_more].present? + # Helps to distinguish e.g. commit notes in mr notes list + def note_for_main_target?(note) + note.for_wall? || + (@target_type.camelize == note.noteable_type && !note.for_diff_line?) end - def loading_new_notes? - params[:loading_new].present? + def note_target_fields + hidden_field_tag(:target_type, @target_type) + + hidden_field_tag(:target_id, @target_id) end - # Helps to distinguish e.g. commit notes in mr notes list - def note_for_main_target?(note) - !@mixed_targets || @main_target_type == note.noteable_type + def link_to_commit_diff_line_note(note) + if note.for_commit_diff_line? + link_to "#{note.diff_file_name}:L#{note.diff_new_line}", project_commit_path(@project, note.noteable, anchor: note.line_code) + end end - def link_to_commit_diff_line_note(note) - commit = note.noteable - diff_index, diff_old_line, diff_new_line = note.line_code.split('_') + def link_to_merge_request_diff_line_note(note) + if note.for_merge_request_diff_line? and note.diff + link_to "#{note.diff_file_name}:L#{note.diff_new_line}", diffs_project_merge_request_path(note.project, note.noteable_id, anchor: note.line_code) + end + end - link_file = commit.diffs[diff_index.to_i].new_path - link_line = diff_new_line + def loading_more_notes? + params[:loading_more].present? + end - link_to "#{link_file}:L#{link_line}", project_commit_path(@project, commit, anchor: note.line_code) + def loading_new_notes? + params[:loading_new].present? end end |