diff options
| -rw-r--r-- | app/models/commit_range.rb | 13 | ||||
| -rw-r--r-- | spec/models/commit_range_spec.rb | 27 |
2 files changed, 0 insertions, 40 deletions
diff --git a/app/models/commit_range.rb b/app/models/commit_range.rb index dce1bfcc198..1b4b12e70e9 100644 --- a/app/models/commit_range.rb +++ b/app/models/commit_range.rb @@ -15,7 +15,6 @@ # # Assuming `project` is a Project with a repository containing both commits: # range.project = project # range.valid_commits? # => true -# range.to_a # => [#<Commit ...>, #<Commit ...>] # class CommitRange include ActiveModel::Conversion @@ -55,18 +54,6 @@ class CommitRange %(#<#{self.class}:#{object_id} #{to_s}>) end - # Returns an Array of Commit objects, where the first value is the starting - # commit, and the second value is the ending commit - # - # Returns `[nil, nil]` if `valid_commits?` is falsey - def to_a - if valid_commits? - [commit_from, commit_to] - else - [nil, nil] - end - end - def to_s "#{sha_from[0..7]}#{notation}#{sha_to[0..7]}" end diff --git a/spec/models/commit_range_spec.rb b/spec/models/commit_range_spec.rb index fe7ede92bc9..fc2982b9a33 100644 --- a/spec/models/commit_range_spec.rb +++ b/spec/models/commit_range_spec.rb @@ -11,33 +11,6 @@ describe CommitRange do expect { described_class.new("Foo") }.to raise_error end - describe '#to_a' do - context 'when valid' do - let(:commit1) { double('commit1') } - let(:commit2) { double('commit2') } - - before do - expect(range).to receive(:valid_commits?).and_return(true) - allow(range).to receive(:commit_from).and_return(commit1) - allow(range).to receive(:commit_to).and_return(commit2) - end - - it 'returns an Array of Commits' do - expect(range.to_a).to eq [commit1, commit2] - end - end - - context 'when invalid' do - before do - expect(range).to receive(:valid_commits?).and_return(false) - end - - it 'returns [nil, nil]' do - expect(range.to_a).to eq [nil, nil] - end - end - end - describe '#to_s' do it 'is correct for three-dot syntax' do expect(range.to_s).to eq "#{sha_from[0..7]}...#{sha_to[0..7]}" |