Remove reduntant method for building pipeline builds

2 files changed, 4 insertions, 0 deletions

diff --git a/spec/models/ci/pipeline_spec.rb b/spec/models/ci/pipeline_spec.rb
index 458013ad9f2..34507cf5083 100644
--- a/spec/models/ci/pipeline_spec.rb
+++ b/spec/models/ci/pipeline_spec.rb
@@ -260,12 +260,15 @@ describe Ci::Pipeline, models: true do
     end
 
     context 'when no builds created' do
+      let(:pipeline) { build(:ci_pipeline) }
+
       before do
         stub_ci_pipeline_yaml_file(YAML.dump(before_script: ['ls']))
       end
 
       it 'returns false' do
         expect(pipeline.create_builds(nil)).to be_falsey
+        expect(pipeline).not_to be_persisted
       end
     end
   end
diff --git a/spec/services/create_commit_builds_service_spec.rb b/spec/services/create_commit_builds_service_spec.rb
index 50ce9659c10..deab242f45a 100644
--- a/spec/services/create_commit_builds_service_spec.rb
+++ b/spec/services/create_commit_builds_service_spec.rb
@@ -184,6 +184,7 @@ describe CreateCommitBuildsService, services: true do
                                  before: '00000000',
                                  after: '31das312',
                                  commits: [{ message: 'some msg' }])
+
         expect(result).to be_falsey
         expect(Ci::Build.all).to be_empty
         expect(Ci::Pipeline.count).to eq(0)