Improve predefined variables collection methods

1 files changed, 10 insertions, 0 deletions

diff --git a/spec/lib/gitlab/ci/variables/collection_spec.rb b/spec/lib/gitlab/ci/variables/collection_spec.rb
index 005e2bb17b4..90b6e178242 100644
--- a/spec/lib/gitlab/ci/variables/collection_spec.rb
+++ b/spec/lib/gitlab/ci/variables/collection_spec.rb
@@ -35,6 +35,11 @@ describe Gitlab::Ci::Variables::Collection do
 
       expect(subject).to be_one
     end
+
+    it 'returns self' do
+      expect(subject.append(key: 'VAR', value: 'test'))
+        .to eq subject
+    end
   end
 
   describe '#concat' do
@@ -60,6 +65,11 @@ describe Gitlab::Ci::Variables::Collection do
       expect(collection).to include(key: 'VAR_2', value: '2', public: true)
       expect(collection).to include(key: 'VAR_3', value: '3', public: true)
     end
+
+    it 'returns self' do
+      expect(subject.concat([key: 'VAR', value: 'test']))
+        .to eq subject
+    end
   end
 
   describe '#+' do