diff options
author | Grzegorz Bizon <grzegorz@gitlab.com> | 2017-09-28 08:52:00 +0000 |
---|---|---|
committer | Grzegorz Bizon <grzegorz@gitlab.com> | 2017-09-28 08:52:00 +0000 |
commit | 355a1d8a6f3dc930911ab61646eb9b3d85d4d01e (patch) | |
tree | 26a3b0a72bc0662a705e8dc7e2271f13f4b1a0b6 /spec | |
parent | 7e314d61807ab28f595b7f9e6b7cf343b495d3b7 (diff) | |
parent | 1dcb7111107ed5a6b6258613d804b8da56af8b35 (diff) | |
download | gitlab-ce-355a1d8a6f3dc930911ab61646eb9b3d85d4d01e.tar.gz |
Merge branch 'refactor-services' into 'master'
Refactor services to match EE signature
See merge request gitlab-org/gitlab-ce!14385
Diffstat (limited to 'spec')
-rw-r--r-- | spec/services/emails/create_service_spec.rb | 2 | ||||
-rw-r--r-- | spec/services/emails/destroy_service_spec.rb | 2 | ||||
-rw-r--r-- | spec/services/users/update_service_spec.rb | 8 |
3 files changed, 6 insertions, 6 deletions
diff --git a/spec/services/emails/create_service_spec.rb b/spec/services/emails/create_service_spec.rb index 641d5538de8..75812c17309 100644 --- a/spec/services/emails/create_service_spec.rb +++ b/spec/services/emails/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' describe Emails::CreateService do let(:user) { create(:user) } - let(:opts) { { email: 'new@email.com' } } + let(:opts) { { email: 'new@email.com', user: user } } subject(:service) { described_class.new(user, opts) } diff --git a/spec/services/emails/destroy_service_spec.rb b/spec/services/emails/destroy_service_spec.rb index 1f4294dd905..7726fc0ef81 100644 --- a/spec/services/emails/destroy_service_spec.rb +++ b/spec/services/emails/destroy_service_spec.rb @@ -4,7 +4,7 @@ describe Emails::DestroyService do let!(:user) { create(:user) } let!(:email) { create(:email, user: user) } - subject(:service) { described_class.new(user, email: email.email) } + subject(:service) { described_class.new(user, user: user, email: email.email) } describe '#execute' do it 'removes an email' do diff --git a/spec/services/users/update_service_spec.rb b/spec/services/users/update_service_spec.rb index 6ee35a33b2d..f8d4a47b212 100644 --- a/spec/services/users/update_service_spec.rb +++ b/spec/services/users/update_service_spec.rb @@ -31,13 +31,13 @@ describe Users::UpdateService do end def update_user(user, opts) - described_class.new(user, opts).execute + described_class.new(user, opts.merge(user: user)).execute end end describe '#execute!' do it 'updates the name' do - service = described_class.new(user, name: 'New Name') + service = described_class.new(user, user: user, name: 'New Name') expect(service).not_to receive(:notify_new_user) result = service.execute! @@ -55,7 +55,7 @@ describe Users::UpdateService do it 'fires system hooks when a new user is saved' do system_hook_service = spy(:system_hook_service) user = build(:user) - service = described_class.new(user, name: 'John Doe') + service = described_class.new(user, user: user, name: 'John Doe') expect(service).to receive(:notify_new_user).and_call_original expect(service).to receive(:system_hook_service).and_return(system_hook_service) @@ -65,7 +65,7 @@ describe Users::UpdateService do end def update_user(user, opts) - described_class.new(user, opts).execute! + described_class.new(user, opts.merge(user: user)).execute! end end end |