summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2018-03-28 12:44:09 +0000
committerRémy Coutable <remy@rymai.me>2018-03-28 12:44:09 +0000
commit11048808528898dc69ecec3fa1a5129fcec1b3ba (patch)
tree89c3ca0983d154d4ff3f5a9941e12c69604d8521 /spec
parentcb94afc561c08db1b2312020e9d0a3e2f5837494 (diff)
parenta48ac407109862c16ed57d3a10e8256aff394a07 (diff)
downloadgitlab-ce-11048808528898dc69ecec3fa1a5129fcec1b3ba.tar.gz
Merge branch '33803-drop-json-support-in-project-milestone' into 'master'
Drop JSON support from Projects::MilestonesController#show Closes #33803 See merge request gitlab-org/gitlab-ce!17977
Diffstat (limited to 'spec')
-rw-r--r--spec/controllers/projects/milestones_controller_spec.rb13
1 files changed, 11 insertions, 2 deletions
diff --git a/spec/controllers/projects/milestones_controller_spec.rb b/spec/controllers/projects/milestones_controller_spec.rb
index 306094f7ffb..5b2614163ff 100644
--- a/spec/controllers/projects/milestones_controller_spec.rb
+++ b/spec/controllers/projects/milestones_controller_spec.rb
@@ -20,14 +20,23 @@ describe Projects::MilestonesController do
describe "#show" do
render_views
- def view_milestone
- get :show, namespace_id: project.namespace.id, project_id: project.id, id: milestone.iid
+ def view_milestone(options = {})
+ params = { namespace_id: project.namespace.id, project_id: project.id, id: milestone.iid }
+ get :show, params.merge(options)
end
it 'shows milestone page' do
view_milestone
expect(response).to have_gitlab_http_status(200)
+ expect(response.content_type).to eq 'text/html'
+ end
+
+ it 'returns milestone json' do
+ view_milestone format: :json
+
+ expect(response).to have_http_status(404)
+ expect(response.content_type).to eq 'application/json'
end
end