Merge branch '52300-pool-repositories' into 'master'

Start tracking pool repositories

Closes #38238 and #52300

See merge request gitlab-org/gitlab-ce!22482

3 files changed, 52 insertions, 0 deletions

diff --git a/spec/lib/gitlab/import_export/all_models.yml b/spec/lib/gitlab/import_export/all_models.yml
index a63f34b5536..f4efa450cca 100644
--- a/spec/lib/gitlab/import_export/all_models.yml
+++ b/spec/lib/gitlab/import_export/all_models.yml
@@ -299,6 +299,7 @@ project:
 - ci_cd_settings
 - import_export_upload
 - repository_languages
+- pool_repository
 award_emoji:
 - awardable
 - user
diff --git a/spec/models/project_spec.rb b/spec/models/project_spec.rb
index d059854214f..84326724118 100644
--- a/spec/models/project_spec.rb
+++ b/spec/models/project_spec.rb
@@ -8,6 +8,7 @@ describe Project do
     it { is_expected.to belong_to(:group) }
     it { is_expected.to belong_to(:namespace) }
     it { is_expected.to belong_to(:creator).class_name('User') }
+    it { is_expected.to belong_to(:pool_repository) }
     it { is_expected.to have_many(:users) }
     it { is_expected.to have_many(:services) }
     it { is_expected.to have_many(:events) }
diff --git a/spec/models/shard_spec.rb b/spec/models/shard_spec.rb
new file mode 100644
index 00000000000..83104711b55
--- /dev/null
+++ b/spec/models/shard_spec.rb
@@ -0,0 +1,50 @@
+# frozen_string_literals: true
+require 'spec_helper'
+
+describe Shard do
+  describe '.populate!' do
+    it 'creates shards based on the config file' do
+      expect(described_class.all).to be_empty
+
+      stub_storage_settings(foo: {}, bar: {}, baz: {})
+
+      described_class.populate!
+
+      expect(described_class.all.map(&:name)).to match_array(%w[default foo bar baz])
+    end
+  end
+
+  describe '.by_name' do
+    let(:default_shard) { described_class.find_by(name: 'default') }
+
+    before do
+      described_class.populate!
+    end
+
+    it 'returns an existing shard' do
+      expect(described_class.by_name('default')).to eq(default_shard)
+    end
+
+    it 'creates a new shard' do
+      result = described_class.by_name('foo')
+
+      expect(result).not_to eq(default_shard)
+      expect(result.name).to eq('foo')
+    end
+
+    it 'retries if creation races' do
+      expect(described_class)
+        .to receive(:find_or_create_by)
+        .with(name: 'default')
+        .and_raise(ActiveRecord::RecordNotUnique, 'fail')
+        .once
+
+      expect(described_class)
+        .to receive(:find_or_create_by)
+        .with(name: 'default')
+        .and_call_original
+
+      expect(described_class.by_name('default')).to eq(default_shard)
+    end
+  end
+end