diff options
author | Kamil Trzcinski <ayufan@ayufan.eu> | 2016-12-07 19:30:14 +0100 |
---|---|---|
committer | Kamil Trzcinski <ayufan@ayufan.eu> | 2016-12-07 19:30:14 +0100 |
commit | 8842f55201ae4725b307336686f8ab168fa0effb (patch) | |
tree | 9fd3079231ad2258374e54e6ff26168e5809be43 /spec | |
parent | 93c72e0f71919968972e874519e01370edcce022 (diff) | |
download | gitlab-ce-8842f55201ae4725b307336686f8ab168fa0effb.tar.gz |
Code review
Diffstat (limited to 'spec')
-rw-r--r-- | spec/lib/gitlab/ci/status/factory_spec.rb | 6 | ||||
-rw-r--r-- | spec/lib/gitlab/ci/status/pipeline/factory_spec.rb | 4 |
2 files changed, 3 insertions, 7 deletions
diff --git a/spec/lib/gitlab/ci/status/factory_spec.rb b/spec/lib/gitlab/ci/status/factory_spec.rb index 8ebdbddb001..d5bd7f7102b 100644 --- a/spec/lib/gitlab/ci/status/factory_spec.rb +++ b/spec/lib/gitlab/ci/status/factory_spec.rb @@ -1,15 +1,11 @@ require 'spec_helper' describe Gitlab::Ci::Status::Factory do - let(:object) { double(status: :created) } - subject do described_class.new(object) end - let(:status) do - subject.fabricate! - end + let(:status) { subject.fabricate! } context 'when object has a core status' do HasStatus::AVAILABLE_STATUSES.each do |core_status| diff --git a/spec/lib/gitlab/ci/status/pipeline/factory_spec.rb b/spec/lib/gitlab/ci/status/pipeline/factory_spec.rb index 939ad2edf04..d6243940f2e 100644 --- a/spec/lib/gitlab/ci/status/pipeline/factory_spec.rb +++ b/spec/lib/gitlab/ci/status/pipeline/factory_spec.rb @@ -21,7 +21,7 @@ describe Gitlab::Ci::Status::Pipeline::Factory do Gitlab::Ci::Status.const_get(core_status.capitalize)) end - it 'extends core status with common stage methods' do + it 'extends core status with common pipeline methods' do expect(status).to have_details expect(status).not_to have_action expect(status.details_path) @@ -45,7 +45,7 @@ describe Gitlab::Ci::Status::Pipeline::Factory do .to be_a Gitlab::Ci::Status::Pipeline::SuccessWithWarnings end - it 'extends core status with common stage methods' do + it 'extends core status with common pipeline methods' do expect(status).to have_details end end |