diff options
author | Michael Kozono <mkozono@gmail.com> | 2017-10-31 14:12:30 -0700 |
---|---|---|
committer | Francisco Lopez <fjlopez@gitlab.com> | 2017-11-17 09:58:18 +0100 |
commit | 987e7b774403e0ebd7ebe2faed4f2ed276504a69 (patch) | |
tree | dcbc39b7398ca5e078fd3b31920fd85c059b541c /spec | |
parent | 91628170c7ed6d6f9ad0e6a19c6ca8fc69672b1d (diff) | |
download | gitlab-ce-987e7b774403e0ebd7ebe2faed4f2ed276504a69.tar.gz |
Add link to discussion
Diffstat (limited to 'spec')
-rw-r--r-- | spec/requests/rack_attack_global_spec.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/spec/requests/rack_attack_global_spec.rb b/spec/requests/rack_attack_global_spec.rb index 7db8264f12b..95a607ac8fd 100644 --- a/spec/requests/rack_attack_global_spec.rb +++ b/spec/requests/rack_attack_global_spec.rb @@ -9,6 +9,8 @@ describe 'Rack Attack global throttles' do # while time is stopped) we expect a 429. But sometimes we get a 200, # sometimes for more than one request, but eventually we get a 429. This # constant and its usages should be removed if we figure out why this happens. + # More on this: + # https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14708#note_45151688 NUM_TRIES_FOR_REJECTION = 1 # Extra time travel past what should be strictly necessary to ensure the @@ -16,6 +18,8 @@ describe 'Rack Attack global throttles' do # # Why add this? Sometimes we get a 429 when we expect a 200. This constant and # its usages should be removed if we figure out why this happens. + # More on this: + # https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14708#note_45151688 NEXT_TIME_PERIOD_BUFFER = 0.seconds let(:settings) { Gitlab::CurrentSettings.current_application_settings } |